)]}'
{"cinder/api/contrib/qos_specs_manage.py":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"6cf229132ac5dd0c66d35d21bb6e590794b49daf","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self._notify_qos_specs_error(context,"},{"line_number":135,"context_line":"                                         \u0027qos_specs.update\u0027,"},{"line_number":136,"context_line":"                                         notifier_err)"},{"line_number":137,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":138,"context_line":"            raise"},{"line_number":139,"context_line":"        except exception.QoSSpecsUpdateFailed as err:"},{"line_number":140,"context_line":"            notifier_err \u003d dict(id\u003did, error_message\u003derr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_d8aa1670","line":137,"updated":"2016-05-18 17:43:30.000000000","message":"Is this right? Will InvalidQosSpecs be handled correctly? It used to return HTTPBadRequest...That gets handled properly by wsgi?","commit_id":"fda0882517a0756331ea05eab2f6386d4045081d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f1b49ba5e9f0719c44374297d06f4f348b7dd105","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            self._notify_qos_specs_error(context,"},{"line_number":135,"context_line":"                                         \u0027qos_specs.update\u0027,"},{"line_number":136,"context_line":"                                         notifier_err)"},{"line_number":137,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":138,"context_line":"            raise"},{"line_number":139,"context_line":"        except exception.QoSSpecsUpdateFailed as err:"},{"line_number":140,"context_line":"            notifier_err \u003d dict(id\u003did, error_message\u003derr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_034ed595","line":137,"in_reply_to":"bab6814e_d8aa1670","updated":"2016-05-19 08:11:22.000000000","message":"Yes, any NotFound and Invalid exceptions are properly converted to a webob WSGIHTTPException with the same error code as specified in the cinder exception.\n\nIf you look at the NotFound cinder base exception, code is 404, and for Invalid, code is 400 (which is HTTPBadRequest).\n\nSo we really don\u0027t have to worry about handling those exceptions at every single point at the API, only when we want to hide the information.","commit_id":"fda0882517a0756331ea05eab2f6386d4045081d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"6cf229132ac5dd0c66d35d21bb6e590794b49daf","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                                         \u0027qos_specs.delete_keys\u0027,"},{"line_number":219,"context_line":"                                         notifier_err)"},{"line_number":220,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":221,"context_line":"            raise"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_d84696be","line":221,"updated":"2016-05-18 17:43:30.000000000","message":"Does this change the return value for QosSpecsKeyNotFound from HTTPBadRequest to NotFound?","commit_id":"fda0882517a0756331ea05eab2f6386d4045081d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f1b49ba5e9f0719c44374297d06f4f348b7dd105","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                                         \u0027qos_specs.delete_keys\u0027,"},{"line_number":219,"context_line":"                                         notifier_err)"},{"line_number":220,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":221,"context_line":"            raise"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_3e5b2e30","line":221,"in_reply_to":"bab6814e_d84696be","updated":"2016-05-19 08:11:22.000000000","message":"In this case it does, but as I see it, it is a bug to return BadRequest, as the error that should be returned is Not Found. (Unless I\u0027m missing something)","commit_id":"fda0882517a0756331ea05eab2f6386d4045081d"}]}