)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"30858c0b8c5b3b48c3f66c4e966974bc018d53eb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"context checks run first."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This also removes an extra volume_get() for"},{"line_number":19,"context_line":"volume_admin_metadata_update() which was loading the volume"},{"line_number":20,"context_line":"twice."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia6432de766b22e80e337b67a994cdb921ea14cc6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dab17558_ecefe784","line":19,"updated":"2016-05-10 15:46:48.000000000","message":"nit: And also for `volume_admin_metadata_get`","commit_id":"b50907b17decbab7b3bb73ded314592305f77a87"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3863066ee18348cee351db64caaffb5ab29a0ea9","unresolved":false,"context_lines":[{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":""},{"line_number":2105,"context_line":"@require_admin_context"},{"line_number":2106,"context_line":"@require_volume_exists"},{"line_number":2107,"context_line":"def volume_admin_metadata_get(context, volume_id):"},{"line_number":2108,"context_line":"    return _volume_admin_metadata_get(context, volume_id)"},{"line_number":2109,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_a004c817","line":2106,"updated":"2016-05-10 14:53:35.000000000","message":"-1: You missed this one","commit_id":"f32c1fef6169f8251d261c39b2229f4f85afb109"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"532ea254af794d0198549934dd12d447a66ad8b9","unresolved":false,"context_lines":[{"line_number":4188,"context_line":""},{"line_number":4189,"context_line":""},{"line_number":4190,"context_line":"@require_context"},{"line_number":4191,"context_line":"@handle_db_data_error"},{"line_number":4192,"context_line":"def cgsnapshot_update(context, cgsnapshot_id, values):"},{"line_number":4193,"context_line":"    session \u003d get_session()"},{"line_number":4194,"context_line":"    with session.begin():"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_d1cd6032","line":4191,"range":{"start_line":4191,"start_character":1,"end_line":4191,"end_character":21},"updated":"2016-05-10 15:32:54.000000000","message":"Sorry, I didn\u0027t catch the reson of changing order\n\n@get_called_last\n@get_called_second\n@get_called_first\ndef decorated_function():\n    do_smth\n\nThe commit message reads that context should be checked first.","commit_id":"f32c1fef6169f8251d261c39b2229f4f85afb109"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"16c1de5d877e038c812eab8e116e3d1234c51f9a","unresolved":false,"context_lines":[{"line_number":4188,"context_line":""},{"line_number":4189,"context_line":""},{"line_number":4190,"context_line":"@require_context"},{"line_number":4191,"context_line":"@handle_db_data_error"},{"line_number":4192,"context_line":"def cgsnapshot_update(context, cgsnapshot_id, values):"},{"line_number":4193,"context_line":"    session \u003d get_session()"},{"line_number":4194,"context_line":"    with session.begin():"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_463c0fc8","line":4191,"range":{"start_line":4191,"start_character":1,"end_line":4191,"end_character":21},"in_reply_to":"dab17558_8c1bbbc9","updated":"2016-05-10 16:21:29.000000000","message":"Please look at https://docs.python.org/2/reference/compound_stmts.html#function-definitions\n\nIn this case:\n decorated_function \u003d get_called_last(get_called_second(\n    get_called_first(decorated_function))\n\nIn code: \n   cgsnapshot_update \u003d require_context(\n          handle_db_data_error(cgsnapshot_update))","commit_id":"f32c1fef6169f8251d261c39b2229f4f85afb109"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"83101d9ed08962d245179ccec22ef706dd98d843","unresolved":false,"context_lines":[{"line_number":4188,"context_line":""},{"line_number":4189,"context_line":""},{"line_number":4190,"context_line":"@require_context"},{"line_number":4191,"context_line":"@handle_db_data_error"},{"line_number":4192,"context_line":"def cgsnapshot_update(context, cgsnapshot_id, values):"},{"line_number":4193,"context_line":"    session \u003d get_session()"},{"line_number":4194,"context_line":"    with session.begin():"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_8c1bbbc9","line":4191,"range":{"start_line":4191,"start_character":1,"end_line":4191,"end_character":21},"in_reply_to":"dab17558_d1cd6032","updated":"2016-05-10 15:45:43.000000000","message":"The sequence is not as you say, it\u0027s the complete opposite as I mention in the general comments.","commit_id":"f32c1fef6169f8251d261c39b2229f4f85afb109"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3863066ee18348cee351db64caaffb5ab29a0ea9","unresolved":false,"context_lines":[{"line_number":4563,"context_line":""},{"line_number":4564,"context_line":""},{"line_number":4565,"context_line":"@require_context"},{"line_number":4566,"context_line":"@_retry_on_deadlock"},{"line_number":4567,"context_line":"def conditional_update(context, model, values, expected_values, filters\u003d(),"},{"line_number":4568,"context_line":"                       include_deleted\u003d\u0027no\u0027, project_only\u003dFalse):"},{"line_number":4569,"context_line":"    \"\"\"Compare-and-swap conditional update SQLAlchemy implementation.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_4076bcd7","line":4566,"updated":"2016-05-10 14:53:35.000000000","message":"My bad   ;-)","commit_id":"f32c1fef6169f8251d261c39b2229f4f85afb109"}]}
