)]}'
{"cinder/api/v3/volumes.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6f5f1d87de2841d0c6c33db566a60d360f5e95bf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"The Volumes API controller for the OpenStack API V3.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, ext_mgr):"},{"line_number":26,"context_line":"        super(VolumeController, self).__init__(ext_mgr)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _get_volumes(self, req, is_detail):"},{"line_number":29,"context_line":"        \"\"\"Returns a list of volumes, transformed through view builder.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_55fb13c1","line":26,"updated":"2016-05-10 17:51:14.000000000","message":"-1: If __init__ isn\u0027t doing anything else it can directly use inherited method, so we can just delete L25-L27","commit_id":"278715b48e650595a9468650e2139b064b4d3dab"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"675b62cfb36693dfef5664a9d4b08745600eb205","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"The Volumes API controller for the OpenStack API V3.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, ext_mgr):"},{"line_number":26,"context_line":"        super(VolumeController, self).__init__(ext_mgr)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _get_volumes(self, req, is_detail):"},{"line_number":29,"context_line":"        \"\"\"Returns a list of volumes, transformed through view builder.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_b5bcffbb","line":26,"in_reply_to":"dab17558_55fb13c1","updated":"2016-05-10 17:55:12.000000000","message":"Good point. At least as of right now, there is no reason __init__ even needs to be defined in this class.","commit_id":"278715b48e650595a9468650e2139b064b4d3dab"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"a8308fcb317f5cc2f83f7de3bfb2c491d79ff9e8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"The Volumes API controller for the OpenStack API V3.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, ext_mgr):"},{"line_number":26,"context_line":"        super(VolumeController, self).__init__(ext_mgr)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _get_volumes(self, req, is_detail):"},{"line_number":29,"context_line":"        \"\"\"Returns a list of volumes, transformed through view builder.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_30ae5de6","line":26,"in_reply_to":"dab17558_55fb13c1","updated":"2016-05-10 18:05:31.000000000","message":"OK. I\u0027m running unit tests, then I\u0027ll push that up.","commit_id":"278715b48e650595a9468650e2139b064b4d3dab"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"89fea9f459b891052f4959b5189275a8aec4effc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"The Volumes API controller for the OpenStack API V3.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, ext_mgr):"},{"line_number":26,"context_line":"        super(VolumeController, self).__init__(ext_mgr)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _get_volumes(self, req, is_detail):"},{"line_number":29,"context_line":"        \"\"\"Returns a list of volumes, transformed through view builder.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_b5e35fd8","line":26,"in_reply_to":"dab17558_55fb13c1","updated":"2016-05-10 17:55:48.000000000","message":"That would seem to be cleaner.","commit_id":"278715b48e650595a9468650e2139b064b4d3dab"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d0d7258bb12a161d39ba9f9b1b9fb81740fbe7eb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \"\"\"The Volumes API controller for the OpenStack API V3.\"\"\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def __init__(self, ext_mgr):"},{"line_number":26,"context_line":"        super(VolumeController, self).__init__(ext_mgr)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _get_volumes(self, req, is_detail):"},{"line_number":29,"context_line":"        \"\"\"Returns a list of volumes, transformed through view builder.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_503cc1c7","line":26,"in_reply_to":"dab17558_b5e35fd8","updated":"2016-05-10 18:03:40.000000000","message":"Since I was too slow in making my comment I have created a dependent patch that removes these lines.","commit_id":"278715b48e650595a9468650e2139b064b4d3dab"}]}