)]}'
{"cinder/tests/unit/test_hpe3par.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"35811f8c6afba917c77c462c5b25f512d8219aee","unresolved":false,"context_lines":[{"line_number":6636,"context_line":"        mock_client \u003d self.setup_driver(config\u003dconfig)"},{"line_number":6637,"context_line":""},{"line_number":6638,"context_line":"        volume \u003d {\u0027host\u0027: \u0027test-host@3pariscsi\u0027,"},{"line_number":6639,"context_line":"                  \u0027id\u0027: \u0027d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027}"},{"line_number":6640,"context_line":"        mock_utils.return_value \u003d \u0027random-pass\u0027"},{"line_number":6641,"context_line":""},{"line_number":6642,"context_line":"        mock_client.getHost.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_acc39a89","line":6639,"range":{"start_line":6639,"start_character":19,"end_line":6639,"end_character":62},"updated":"2016-05-12 20:00:33.000000000","message":"You could use fake_constants here.","commit_id":"977584f8dc497ca8bfe0e8157b19f5806b6dd846"},{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"cd18fad8989401ab6ad5c3530168ff2de64f3649","unresolved":false,"context_lines":[{"line_number":6711,"context_line":"                \u0027osv-0DM4qZEVSKON-DXN-NwVpw\u0027, CHAP_PASS_KEY, \u0027random-pass\u0027)]"},{"line_number":6712,"context_line":"        expected_model \u003d {\u0027provider_auth\u0027: \u0027CHAP test-host random-pass\u0027}"},{"line_number":6713,"context_line":""},{"line_number":6714,"context_line":"        with mock.patch.object(hpecommon.HPE3PARCommon,"},{"line_number":6715,"context_line":"                               \u0027_create_client\u0027) as mock_create_client:"},{"line_number":6716,"context_line":"            mock_create_client.return_value \u003d mock_client"},{"line_number":6717,"context_line":"            model \u003d self.driver.create_export(None, volume, None)"},{"line_number":6718,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":6719,"context_line":"            self.assertDictMatch(expected_model, model)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_bf126307","line":6716,"range":{"start_line":6714,"start_character":8,"end_line":6716,"end_character":57},"updated":"2016-05-13 20:19:44.000000000","message":"nit: You can use \u0027mock_object\u0027 instead of \u0027with mock.patch\u0027 here:\nself.mock_object(hpecommon.HPE3PARCommon, \u0027_create_client\u0027, mock.Mock(return_value\u003dmock_client))\nI think its more beautiful :D","commit_id":"89accefb4b74d6427bcc394055e9df5f38cf0e41"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c0e9b71c9f9f80fc29866f3ba18ad30c7cefb173","unresolved":false,"context_lines":[{"line_number":6666,"context_line":"            mock_client.getHostVLUNs.return_value \u003d ["},{"line_number":6667,"context_line":"                {\u0027active\u0027: True, \u0027volumeName\u0027: self.VOLUME_3PAR_NAME,"},{"line_number":6668,"context_line":"                 \u0027lun\u0027: None, \u0027type\u0027: 0,"},{"line_number":6669,"context_line":"                 \u0027remoteName\u0027: \u0027iqn.1993-08.org.debian:01:222\u0027}]"},{"line_number":6670,"context_line":""},{"line_number":6671,"context_line":"            model_with_remote_name \u003d self.driver._do_export(common, volume)"},{"line_number":6672,"context_line":"            mock_client.assert_has_calls(expected)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_dea41f4c","line":6669,"updated":"2016-06-09 22:28:07.000000000","message":"if a VLUN has a remoteName, it\u0027s going to have a LUN number.\nThe type is going to be 3.","commit_id":"769e37a441774e51a7108f1226e893f063f35eaa"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"c0512f7227bd8a1a27a5fd216cd230a3f9e6c061","unresolved":false,"context_lines":[{"line_number":6666,"context_line":"            mock_client.getHostVLUNs.return_value \u003d ["},{"line_number":6667,"context_line":"                {\u0027active\u0027: True, \u0027volumeName\u0027: self.VOLUME_3PAR_NAME,"},{"line_number":6668,"context_line":"                 \u0027lun\u0027: None, \u0027type\u0027: 0,"},{"line_number":6669,"context_line":"                 \u0027remoteName\u0027: \u0027iqn.1993-08.org.debian:01:222\u0027}]"},{"line_number":6670,"context_line":""},{"line_number":6671,"context_line":"            model_with_remote_name \u003d self.driver._do_export(common, volume)"},{"line_number":6672,"context_line":"            mock_client.assert_has_calls(expected)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_a72a832a","line":6669,"in_reply_to":"7aa08908_dea41f4c","updated":"2016-06-10 05:57:17.000000000","message":"done","commit_id":"769e37a441774e51a7108f1226e893f063f35eaa"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c0e9b71c9f9f80fc29866f3ba18ad30c7cefb173","unresolved":false,"context_lines":[{"line_number":6675,"context_line":"            # vlun does not has remoteName"},{"line_number":6676,"context_line":"            mock_client.getHostVLUNs.return_value \u003d ["},{"line_number":6677,"context_line":"                {\u0027active\u0027: True, \u0027volumeName\u0027: self.VOLUME_3PAR_NAME,"},{"line_number":6678,"context_line":"                 \u0027lun\u0027: None, \u0027type\u0027: 0}]"},{"line_number":6679,"context_line":""},{"line_number":6680,"context_line":"            model_without_remote_name \u003d self.driver._do_export(common, volume)"},{"line_number":6681,"context_line":"            mock_client.assert_has_calls(expected)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_4d302e08","line":6678,"updated":"2016-06-09 22:28:07.000000000","message":"a VLUN with a LUN of None will be type 1, and active: False.\nThis is a VLUN template.","commit_id":"769e37a441774e51a7108f1226e893f063f35eaa"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"c0512f7227bd8a1a27a5fd216cd230a3f9e6c061","unresolved":false,"context_lines":[{"line_number":6675,"context_line":"            # vlun does not has remoteName"},{"line_number":6676,"context_line":"            mock_client.getHostVLUNs.return_value \u003d ["},{"line_number":6677,"context_line":"                {\u0027active\u0027: True, \u0027volumeName\u0027: self.VOLUME_3PAR_NAME,"},{"line_number":6678,"context_line":"                 \u0027lun\u0027: None, \u0027type\u0027: 0}]"},{"line_number":6679,"context_line":""},{"line_number":6680,"context_line":"            model_without_remote_name \u003d self.driver._do_export(common, volume)"},{"line_number":6681,"context_line":"            mock_client.assert_has_calls(expected)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_0720b748","line":6678,"in_reply_to":"7aa08908_4d302e08","updated":"2016-06-10 05:57:17.000000000","message":"done","commit_id":"769e37a441774e51a7108f1226e893f063f35eaa"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"622f3f01309a93640527b16f2dc8203c133f06ce","unresolved":false,"context_lines":[{"line_number":6693,"context_line":"            {\u0027active\u0027: True,"},{"line_number":6694,"context_line":"             \u0027volumeName\u0027: self.VOLUME_3PAR_NAME,"},{"line_number":6695,"context_line":"             \u0027lun\u0027: None, \u0027type\u0027: 0,"},{"line_number":6696,"context_line":"             \u0027remoteName\u0027: \u0027iqn.1993-08.org.debian:01:222\u0027}]"},{"line_number":6697,"context_line":"        mock_client.getHost.return_value \u003d {"},{"line_number":6698,"context_line":"            \u0027name\u0027: \u0027osv-0DM4qZEVSKON-DXN-NwVpw\u0027,"},{"line_number":6699,"context_line":"            \u0027initiatorChapEnabled\u0027: True}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f14b7b29","line":6696,"updated":"2016-06-10 21:34:28.000000000","message":"an active VLUN has a valid LUN, and is type 3","commit_id":"afacd943ff6c034878a4b52c0f51ba677d76ea69"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"c2f28d25efb1d80461b8fc5b87458fbf43414b0c","unresolved":false,"context_lines":[{"line_number":6693,"context_line":"            {\u0027active\u0027: True,"},{"line_number":6694,"context_line":"             \u0027volumeName\u0027: self.VOLUME_3PAR_NAME,"},{"line_number":6695,"context_line":"             \u0027lun\u0027: None, \u0027type\u0027: 0,"},{"line_number":6696,"context_line":"             \u0027remoteName\u0027: \u0027iqn.1993-08.org.debian:01:222\u0027}]"},{"line_number":6697,"context_line":"        mock_client.getHost.return_value \u003d {"},{"line_number":6698,"context_line":"            \u0027name\u0027: \u0027osv-0DM4qZEVSKON-DXN-NwVpw\u0027,"},{"line_number":6699,"context_line":"            \u0027initiatorChapEnabled\u0027: True}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_a671610e","line":6696,"in_reply_to":"7aa08908_f14b7b29","updated":"2016-06-14 05:42:57.000000000","message":"Done","commit_id":"afacd943ff6c034878a4b52c0f51ba677d76ea69"}]}