)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"e6db78ca342a2f3d8a12c5d74d10be461c555b86","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support new osprofiler API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add connection_string config option that allows to specify the address of the notifier\u0027s storage engine."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ifdfe2649020c610c76b318351e9448ad777352d5"},{"line_number":12,"context_line":"Depends-On: I3e904d0e456aa6999cd9a02a268f54e6d8b729de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_d37cd4ed","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":42},"updated":"2016-06-27 18:06:54.000000000","message":"You need to limit this line to 80 chars.","commit_id":"a6d655bb220f16a8f4f94585419a38a993feadb6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c907580373c96274a9256ccc1dd385e9c58c8d92","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support new osprofiler API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add connection_string config option that allows to specify the address"},{"line_number":10,"context_line":"of the notifier\u0027s storage engine."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifdfe2649020c610c76b318351e9448ad777352d5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da7fb54a_6a20abf8","line":9,"updated":"2016-09-02 16:18:04.000000000","message":"We need a release note for this change.\n\nSee http://docs.openstack.org/developer/cinder/devref/releasenotes.html","commit_id":"361a01aa60b4c7e0dce628a46eccd46aa35df094"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"82c70ceb93cbd0ec27e0dd28b24ffdf2fdcb7992","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add connection_string config option that allows to specify the address"},{"line_number":10,"context_line":"of the notifier\u0027s storage engine."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifdfe2649020c610c76b318351e9448ad777352d5"},{"line_number":13,"context_line":"Depends-On: I77d0d3b5e9e725507916724dcd28d5fbc6f7f5c7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a8ec9b2_ffef90e6","line":11,"updated":"2016-09-15 20:26:44.000000000","message":"If you\u0027re adding a new config option, don\u0027t you need a docImpact tag?","commit_id":"97ef26c0bb6d1fcfae9d327503bb90c4a2c3b16d"}],"cinder/service.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a34bee9c6cdf8bc6e5ab284384426c35e883859b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        return"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    if CONF.profiler.enabled:"},{"line_number":88,"context_line":"        osprofiler_initializer.init_from_conf("},{"line_number":89,"context_line":"            conf\u003dCONF,"},{"line_number":90,"context_line":"            context\u003dcontext.get_admin_context().to_dict(),"},{"line_number":91,"context_line":"            project\u003d\"cinder\","}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_2f1edf6f","line":88,"updated":"2016-07-21 11:42:47.000000000","message":"The latest osprofiler version is 1.3.0 and it doesn\u0027t have this function. I think we should merge the \"new init method\" osprofiler patch and then release a new version of osprofiler (say 1.4.0) and update the requirements.","commit_id":"da9ead2617e5f8fd8634a9d9353e7eb8ec8b2e97"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"27008ede08b85d43814ebb307caa9f3cc0878063","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    if (osprofiler_initializer is None or"},{"line_number":90,"context_line":"            profiler is None or"},{"line_number":91,"context_line":"            profiler_opts is None):"},{"line_number":92,"context_line":"        LOG.debug(\u0027osprofiler is not present\u0027)"},{"line_number":93,"context_line":"        return"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    if CONF.profiler.enabled:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_5e3072e8","line":92,"range":{"start_line":92,"start_character":19,"end_line":92,"end_character":29},"updated":"2016-12-15 07:32:32.000000000","message":"OSProfiler","commit_id":"0df06459d4e0bc17bc875c334ee5ee76aa1f6515"}],"cinder/tests/unit/test_setup_profiler.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c907580373c96274a9256ccc1dd385e9c58c8d92","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from cinder import service,test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SetupProfilerTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da7fb54a_8a032f0f","line":18,"updated":"2016-09-02 16:18:04.000000000","message":"We shouldn\u0027t import more than one module per line.","commit_id":"361a01aa60b4c7e0dce628a46eccd46aa35df094"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c907580373c96274a9256ccc1dd385e9c58c8d92","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        service.setup_profiler(\"cinder-volume\", \"localhost\")"},{"line_number":26,"context_line":"        service.LOG.debug.assert_called_once_with(\"osprofiler is not present\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_profiler_enabled(self):"},{"line_number":29,"context_line":"        service.osprofiler_initializer \u003d mock.MagicMock()"},{"line_number":30,"context_line":"        service.profiler \u003d mock.MagicMock()        "},{"line_number":31,"context_line":"        service.profiler_opts \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da7fb54a_f5f2e005","line":28,"updated":"2016-09-02 16:18:04.000000000","message":"Please add a test for profiler disabled case.","commit_id":"361a01aa60b4c7e0dce628a46eccd46aa35df094"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"f24e7e0875b5f42c509f595f434cd9961af48033","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_profiler_enabled(self):"},{"line_number":29,"context_line":"        service.osprofiler_initializer \u003d mock.MagicMock()"},{"line_number":30,"context_line":"        service.profiler \u003d mock.MagicMock()        "},{"line_number":31,"context_line":"        service.profiler_opts \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        service.osprofiler_initializer.init_from_conf \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        service.CONF.profiler.enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_b45658d0","line":30,"updated":"2016-08-26 19:14:27.000000000","message":"please remove trailing tab","commit_id":"361a01aa60b4c7e0dce628a46eccd46aa35df094"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"47351362883025d5a1f58c98554770ec6224c037","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        service.LOG.debug.assert_called_once_with(\"osprofiler is not present\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_profiler_enabled(self):"},{"line_number":30,"context_line":"        service.osprofiler_initializer \u003d mock.MagicMock()"},{"line_number":31,"context_line":"        service.profiler \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        service.profiler_opts \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        service.osprofiler_initializer.init_from_conf \u003d mock.MagicMock()"},{"line_number":34,"context_line":"        service.CONF.profiler.enabled \u003d True"},{"line_number":35,"context_line":"        service.context \u003d mock.MagicMock()"},{"line_number":36,"context_line":"        service.context.get_admin_context().to_dict.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_0317e9ed","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":72},"updated":"2016-09-28 12:04:37.000000000","message":"I think we should move this to setUp().","commit_id":"115670fddb79f86943dd5a957ff98239f9908ad0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"47351362883025d5a1f58c98554770ec6224c037","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        service.profiler_opts \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        service.osprofiler_initializer.init_from_conf \u003d mock.MagicMock()"},{"line_number":34,"context_line":"        service.CONF.profiler.enabled \u003d True"},{"line_number":35,"context_line":"        service.context \u003d mock.MagicMock()"},{"line_number":36,"context_line":"        service.context.get_admin_context().to_dict.return_value \u003d {"},{"line_number":37,"context_line":"            \u0027resource_uuid\u0027: None,"},{"line_number":38,"context_line":"            \u0027user_domain\u0027: None,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_23a065a5","line":35,"updated":"2016-09-28 12:04:37.000000000","message":"We can use mock.patch(\u0027cinder.context\u0027) decorator instead.","commit_id":"115670fddb79f86943dd5a957ff98239f9908ad0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8116979c85666d8a6ba40f968ecad59ed9e21c2b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        service.profiler \u003d None"},{"line_number":32,"context_line":"        service.LOG.debug \u003d mock.MagicMock()"},{"line_number":33,"context_line":"        service.setup_profiler(\"cinder-volume\", \"localhost\")"},{"line_number":34,"context_line":"        service.LOG.debug.assert_called_once_with(\"osprofiler is not present\")"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @mock.patch(\"cinder.service.context\")"},{"line_number":37,"context_line":"    def test_profiler_enabled(self, context):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5da102_1bc4df90","line":34,"updated":"2016-10-26 07:15:03.000000000","message":"I\u0027d rather see asserts that methods were not called due to this, rather than checking log levels and log strings. Not major in this case though, so will not downvote on that.","commit_id":"53dfbe7809386dc902573788f6e4b8dcbaf9050b"}],"releasenotes/notes/new-osprofiler-call-0bb1a305c8e8f9cc.yaml":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"47351362883025d5a1f58c98554770ec6224c037","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - Cinder can use external OSprofiler drivers to store"},{"line_number":5,"context_line":"    profiling data"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a8bc5a2_a388f5c7","line":2,"updated":"2016-09-28 12:04:37.000000000","message":"Do we need this?","commit_id":"115670fddb79f86943dd5a957ff98239f9908ad0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"47351362883025d5a1f58c98554770ec6224c037","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - Cinder can use external OSprofiler drivers to store"},{"line_number":5,"context_line":"    profiling data"},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - New config option added. \"connection_string\" in [profiler]"},{"line_number":8,"context_line":"    section is used to specify OSprofiler driver connection"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a8bc5a2_43c011e1","line":5,"updated":"2016-09-28 12:04:37.000000000","message":"We should also mention how it can be done by referring to the upgrade section.","commit_id":"115670fddb79f86943dd5a957ff98239f9908ad0"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"47351362883025d5a1f58c98554770ec6224c037","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - New config option added. \"connection_string\" in [profiler]"},{"line_number":8,"context_line":"    section is used to specify OSprofiler driver connection"},{"line_number":9,"context_line":"    string, e.g."},{"line_number":10,"context_line":"    ```\"connection_string \u003d messaging://\"```,"},{"line_number":11,"context_line":"    ```\"connection_string \u003d mongodb://localhost\"```"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5a8bc5a2_23306507","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":7},"updated":"2016-09-28 12:04:37.000000000","message":"Do we need three quotes?","commit_id":"115670fddb79f86943dd5a957ff98239f9908ad0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8116979c85666d8a6ba40f968ecad59ed9e21c2b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - Cinder can use external OSprofiler drivers to store"},{"line_number":5,"context_line":"    profiling data"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba5da102_3bc1a381","line":2,"updated":"2016-10-26 07:15:03.000000000","message":"Remove.","commit_id":"53dfbe7809386dc902573788f6e4b8dcbaf9050b"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8116979c85666d8a6ba40f968ecad59ed9e21c2b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"features:"},{"line_number":4,"context_line":"  - Cinder can use external OSprofiler drivers to store"},{"line_number":5,"context_line":"    profiling data"},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - New config option added. \"connection_string\" in [profiler]"},{"line_number":8,"context_line":"    section is used to specify OSprofiler driver connection"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba5da102_db40a70a","line":5,"range":{"start_line":3,"start_character":1,"end_line":5,"end_character":17},"updated":"2016-10-26 07:15:03.000000000","message":"This should be removed as well.","commit_id":"53dfbe7809386dc902573788f6e4b8dcbaf9050b"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"43f40a9d351c1d47f03f77b2407033c93b6fbd31","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - New config option added. ``\"connection_string\"`` in [profiler]"},{"line_number":4,"context_line":"    section is used to specify OSProfiler driver connection"},{"line_number":5,"context_line":"    string, for example,"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_17c41d8f","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":8},"updated":"2016-12-15 09:13:19.000000000","message":"The work type should be upgrade or feature? I think this one should be upgrade :)","commit_id":"d48e9670270305beeaba57ffcfd61b14792d8097"}]}