)]}'
{"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7c6f85868576b95ab347dabf69c4f8d8089079dd","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # make sure the default CPG exists"},{"line_number":150,"context_line":"        self.validate_cpg(self.config.hp3par_cpg)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.client_logout()"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def validate_cpg(self, cpg_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FbxI%3D","line":151,"updated":"2013-06-04 01:50:32.000000000","message":"Since you\u0027ve moved the validate and the possibility of raising here, do you want to add a finally or another except here to make sure the logout is performed?","commit_id":"3f7b3fe4ee2a855f5ec8365093784e14f82e12bd"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"32c9f81e1685b5a435a44110930fc8e899988c00","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        # make sure the default CPG exists"},{"line_number":150,"context_line":"        self.validate_cpg(self.config.hp3par_cpg)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        self.client_logout()"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def validate_cpg(self, cpg_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F%2B08%3D","line":151,"in_reply_to":"AAAAPH%2F%2FbxI%3D","updated":"2013-06-04 16:37:20.000000000","message":"Done","commit_id":"3f7b3fe4ee2a855f5ec8365093784e14f82e12bd"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"92b8d9dc2bae2ede1976d09604565d0b6290c61e","unresolved":false,"context_lines":[{"line_number":585,"context_line":"                snap_cpg \u003d self.config.hp3par_cpg_snap"},{"line_number":586,"context_line":"                # if it\u0027s still not set or empty then set it to the cpg"},{"line_number":587,"context_line":"                # specified in the cinder.conf file."},{"line_number":588,"context_line":"                if self.config.hp3par_cpg_snap \u003d\u003d \"\":"},{"line_number":589,"context_line":"                    snap_cpg \u003d cpg"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"            # if provisioning is not set use thin"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2BlQ%3D","line":588,"updated":"2013-06-04 18:17:08.000000000","message":"if not self.config.hp3par_cpg_snap:","commit_id":"08e3e70058748326cc851bb1bfb28cd9e278a6ae"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"426486d9c5f0a38b1ab020daafb70ba49afe3394","unresolved":false,"context_lines":[{"line_number":585,"context_line":"                snap_cpg \u003d self.config.hp3par_cpg_snap"},{"line_number":586,"context_line":"                # if it\u0027s still not set or empty then set it to the cpg"},{"line_number":587,"context_line":"                # specified in the cinder.conf file."},{"line_number":588,"context_line":"                if self.config.hp3par_cpg_snap \u003d\u003d \"\":"},{"line_number":589,"context_line":"                    snap_cpg \u003d cpg"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"            # if provisioning is not set use thin"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2Ba4%3D","line":588,"in_reply_to":"AAAAPX%2F%2F%2BlQ%3D","updated":"2013-06-04 19:33:24.000000000","message":"Done","commit_id":"08e3e70058748326cc851bb1bfb28cd9e278a6ae"}]}