)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ccc80c8864c5192c06109c9fe37461f28711ecd1","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        if volume_name:"},{"line_number":733,"context_line":"            hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)"},{"line_number":734,"context_line":"            host_list \u003d (list(hosts_map_info.select(\u0027host_name\u0027)) +"},{"line_number":735,"context_line":"                         list(hosts_info.select(\u0027name\u0027)))"},{"line_number":736,"context_line":"        else:"},{"line_number":737,"context_line":"            host_list \u003d list(hosts_info.select(\u0027name\u0027))"},{"line_number":738,"context_line":"        found \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_e14ea036","line":735,"updated":"2016-05-17 11:22:36.000000000","message":"-1: You should remove the one you move to the top of the list from the other list.","commit_id":"8838574610bef8d6df4fce4cc88e6548cc6c776b"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"538474c7282f7e4213c125366ccc730cf9ce329d","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        if volume_name:"},{"line_number":733,"context_line":"            hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)"},{"line_number":734,"context_line":"            host_list \u003d (list(hosts_map_info.select(\u0027host_name\u0027)) +"},{"line_number":735,"context_line":"                         list(hosts_info.select(\u0027name\u0027)))"},{"line_number":736,"context_line":"        else:"},{"line_number":737,"context_line":"            host_list \u003d list(hosts_info.select(\u0027name\u0027))"},{"line_number":738,"context_line":"        found \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_8999a37b","line":735,"in_reply_to":"dab17558_e14ea036","updated":"2016-05-23 14:59:39.000000000","message":"Sounds good. Will make that change.","commit_id":"8838574610bef8d6df4fce4cc88e6548cc6c776b"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e9f20621d823d2061bef147fffb946466bde7dd5","unresolved":false,"context_lines":[{"line_number":736,"context_line":"            # remove the fast path host names from the end of the list"},{"line_number":737,"context_line":"            # so they are only searched for once."},{"line_number":738,"context_line":"            for host in hosts_map_info_list:"},{"line_number":739,"context_line":"                idx \u003d hosts_info_list.index(host)"},{"line_number":740,"context_line":"                del hosts_info_list[idx]"},{"line_number":741,"context_line":"            host_list \u003d hosts_map_info_list + hosts_info_list"},{"line_number":742,"context_line":"        else:"},{"line_number":743,"context_line":"            host_list \u003d list(hosts_info.select(\u0027name\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_39a48ca4","line":740,"range":{"start_line":739,"start_character":16,"end_line":740,"end_character":40},"updated":"2016-05-26 14:18:38.000000000","message":"nit: This would be faster and easier to read as:\n\n hosts_info_list.remove(host)","commit_id":"c5057af51fc739739ae64c506f943c93d4056822"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e9f20621d823d2061bef147fffb946466bde7dd5","unresolved":false,"context_lines":[{"line_number":738,"context_line":"            for host in hosts_map_info_list:"},{"line_number":739,"context_line":"                idx \u003d hosts_info_list.index(host)"},{"line_number":740,"context_line":"                del hosts_info_list[idx]"},{"line_number":741,"context_line":"            host_list \u003d hosts_map_info_list + hosts_info_list"},{"line_number":742,"context_line":"        else:"},{"line_number":743,"context_line":"            host_list \u003d list(hosts_info.select(\u0027name\u0027))"},{"line_number":744,"context_line":"        found \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_59007002","line":741,"range":{"start_line":741,"start_character":12,"end_line":741,"end_character":61},"updated":"2016-05-26 14:18:38.000000000","message":"nit: I think L733-L741 would be more efficient like this:\n\n hosts_map_info \u003d self.ssh.lsvdiskhostmap(volume_name)\n host_list \u003d list(hosts_map_info.select(\u0027host_name\u0027))\n host_list.extend(host for host in hosts_map_info\n                  if host not in host_list)","commit_id":"c5057af51fc739739ae64c506f943c93d4056822"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_fc.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ccc80c8864c5192c06109c9fe37461f28711ecd1","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                    \u0027data\u0027: {}}"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"            host_name \u003d self._helpers.get_host_from_connector("},{"line_number":270,"context_line":"                connector, volume_name\u003dvolume[\u0027name\u0027])"},{"line_number":271,"context_line":"            if host_name is None:"},{"line_number":272,"context_line":"                msg \u003d (_(\u0027terminate_connection: Failed to get host name from\u0027"},{"line_number":273,"context_line":"                         \u0027 connector.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_c1e9dce7","line":270,"updated":"2016-05-17 11:22:36.000000000","message":"-1: Please use vol_name defined on L259 for consistency with existing code.","commit_id":"8838574610bef8d6df4fce4cc88e6548cc6c776b"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"538474c7282f7e4213c125366ccc730cf9ce329d","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                    \u0027data\u0027: {}}"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"            host_name \u003d self._helpers.get_host_from_connector("},{"line_number":270,"context_line":"                connector, volume_name\u003dvolume[\u0027name\u0027])"},{"line_number":271,"context_line":"            if host_name is None:"},{"line_number":272,"context_line":"                msg \u003d (_(\u0027terminate_connection: Failed to get host name from\u0027"},{"line_number":273,"context_line":"                         \u0027 connector.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_09b2d3e4","line":270,"in_reply_to":"dab17558_c1e9dce7","updated":"2016-05-23 14:59:39.000000000","message":"Yep","commit_id":"8838574610bef8d6df4fce4cc88e6548cc6c776b"}]}