)]}'
{"cinder/transfer/api.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"f9d8736c09dcc9fa1fb540c42b20e22781470547","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            # Transfer ownership of the volume now, must use an elevated"},{"line_number":180,"context_line":"            # context."},{"line_number":181,"context_line":"            self.volume_api.accept_transfer(context, vol_ref)"},{"line_number":182,"context_line":"            self.db.transfer_accept(context.elevated(),"},{"line_number":183,"context_line":"                                    transfer_id,"},{"line_number":184,"context_line":"                                    context.user_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F9GU%3D","line":181,"updated":"2013-06-05 09:14:43.000000000","message":"Would it not be better to make the call to the driver after the database has been updated?","commit_id":"d03c94f2b0e3a6d15e404d245fdfa895ca6430de"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"da7e0313e5d82721778eee16188326cca35ffdf6","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            # Transfer ownership of the volume now, must use an elevated"},{"line_number":180,"context_line":"            # context."},{"line_number":181,"context_line":"            self.volume_api.accept_transfer(context, vol_ref)"},{"line_number":182,"context_line":"            self.db.transfer_accept(context.elevated(),"},{"line_number":183,"context_line":"                                    transfer_id,"},{"line_number":184,"context_line":"                                    context.user_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F7gg%3D","line":181,"in_reply_to":"AAAAPX%2F%2F8EA%3D","updated":"2013-06-05 20:26:42.000000000","message":"My initial thought was that it would be easier to \"undo\" the driver call (of course considering no driver implements a real operation yet), however after further thought I think it might be easier to do the DB change first as we have mechanisms to easily undo/revert that one rather than have to implement an undo in the volume drivers.\n\nI\u0027ll make a note to adjust this when we add the first driver implementation, thanks!!","commit_id":"d03c94f2b0e3a6d15e404d245fdfa895ca6430de"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e93cd1c20d3b1134cd1c95cab2a21f5b7c4128a8","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            # Transfer ownership of the volume now, must use an elevated"},{"line_number":180,"context_line":"            # context."},{"line_number":181,"context_line":"            self.volume_api.accept_transfer(context, vol_ref)"},{"line_number":182,"context_line":"            self.db.transfer_accept(context.elevated(),"},{"line_number":183,"context_line":"                                    transfer_id,"},{"line_number":184,"context_line":"                                    context.user_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F8EA%3D","line":181,"in_reply_to":"AAAAPX%2F%2F9GU%3D","updated":"2013-06-05 17:37:34.000000000","message":"either order has some issues, this seemed like the better option at the time so that the manager etc didn\u0027t have to worry about context switches but I could be convinced either way.\n\nI\u0027ll take another look at the testing to see exactly what the problem I ran into was.","commit_id":"d03c94f2b0e3a6d15e404d245fdfa895ca6430de"}],"cinder/volume/api.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"74ecfc5c77a127d2551bb0ca31e0955cb2c574d5","unresolved":false,"context_lines":[{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def accept_transfer(self, context, volume):"},{"line_number":522,"context_line":"        return self.volume_rpcapi.accept_transfer(context,"},{"line_number":523,"context_line":"                                                  volume)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def _create_snapshot(self, context,"},{"line_number":526,"context_line":"                         volume, name, description,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F8EE%3D","line":523,"updated":"2013-06-05 17:37:45.000000000","message":"Policy check?","commit_id":"d03c94f2b0e3a6d15e404d245fdfa895ca6430de"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"93e6438de596349ee0d1f48c7c8304fe65069c84","unresolved":false,"context_lines":[{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def accept_transfer(self, context, volume):"},{"line_number":522,"context_line":"        return self.volume_rpcapi.accept_transfer(context,"},{"line_number":523,"context_line":"                                                  volume)"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    def _create_snapshot(self, context,"},{"line_number":526,"context_line":"                         volume, name, description,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2F8CU%3D","line":523,"in_reply_to":"AAAAPX%2F%2F8EE%3D","updated":"2013-06-05 17:42:57.000000000","message":"No thank you, why?","commit_id":"d03c94f2b0e3a6d15e404d245fdfa895ca6430de"}],"cinder/volume/driver.py":[{"author":{"_account_id":6094,"name":"Navneet Singh","email":"navsinghnitd@gmail.com","username":"singn"},"change_message_id":"3325a97f7052ed07e7cffa565e76071f1a7dc5b2","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        data[\u0027QoS_support\u0027] \u003d False"},{"line_number":481,"context_line":"        self._stats \u003d data"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    def accept_transfer(self, volume):"},{"line_number":484,"context_line":"        pass"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FwAQ%3D","line":483,"updated":"2013-06-11 13:00:19.000000000","message":"This method is being called by volume manager on volume drivers. I think this should also be declared in VolumeDriver class. It needs to be there for all volume drivers to inherit it.","commit_id":"d03c94f2b0e3a6d15e404d245fdfa895ca6430de"}]}