)]}'
{"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"5242f80c8afce7eb772c7092e9c313ae13d5a790","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            pass"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def assert_notify_called(self, mock_notify, calls):"},{"line_number":163,"context_line":"        for i in range(0, len(calls)):"},{"line_number":164,"context_line":"            mock_call \u003d mock_notify.call_args_list[i]"},{"line_number":165,"context_line":"            call \u003d calls[i]"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_bbdfa967","line":163,"range":{"start_line":163,"start_character":35,"end_line":163,"end_character":38},"updated":"2016-05-17 10:46:56.000000000","message":"Why not just range(len(calls))? The start argument defaults to 0.","commit_id":"b2174454e7bd126872c335b3cdc784cdbd35d617"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"717e0e8d54b78f179a8b7629a02ce4b6c000265d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            pass"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def assert_notify_called(self, mock_notify, calls):"},{"line_number":163,"context_line":"        for i in range(0, len(calls)):"},{"line_number":164,"context_line":"            mock_call \u003d mock_notify.call_args_list[i]"},{"line_number":165,"context_line":"            call \u003d calls[i]"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_fb049118","line":163,"range":{"start_line":163,"start_character":35,"end_line":163,"end_character":38},"in_reply_to":"dab17558_bbdfa967","updated":"2016-05-17 11:11:42.000000000","message":"nit: I usually do it like Yuriy says, but this is correct as well.","commit_id":"b2174454e7bd126872c335b3cdc784cdbd35d617"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"5242f80c8afce7eb772c7092e9c313ae13d5a790","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            posargs \u003d mock_call[0]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"            self.assertEqual(call[0], posargs[0])"},{"line_number":170,"context_line":"            self.assertEqual(call[1], posargs[2])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def fake_get_all_volume_groups(obj, vg_name\u003dNone, no_suffix\u003dTrue):"},{"line_number":173,"context_line":"        return [{\u0027name\u0027: \u0027cinder-volumes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_7b3f0187","line":170,"range":{"start_line":170,"start_character":47,"end_line":170,"end_character":49},"updated":"2016-05-17 10:46:56.000000000","message":"self.assertEqual(call[1], posargs[2 ??])","commit_id":"b2174454e7bd126872c335b3cdc784cdbd35d617"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"717e0e8d54b78f179a8b7629a02ce4b6c000265d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            posargs \u003d mock_call[0]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"            self.assertEqual(call[0], posargs[0])"},{"line_number":170,"context_line":"            self.assertEqual(call[1], posargs[2])"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def fake_get_all_volume_groups(obj, vg_name\u003dNone, no_suffix\u003dTrue):"},{"line_number":173,"context_line":"        return [{\u0027name\u0027: \u0027cinder-volumes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_fb2db1a8","line":170,"range":{"start_line":170,"start_character":47,"end_line":170,"end_character":49},"in_reply_to":"dab17558_7b3f0187","updated":"2016-05-17 11:11:42.000000000","message":"Because posargs[1] is the context, which we don\u0027t check, and posargs[3] is the payload that we are not checking anymore.","commit_id":"b2174454e7bd126872c335b3cdc784cdbd35d617"}]}