)]}'
{"cinder/tests/unit/test_emc_vmax.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"6c3b76149772a62fbfcb18d73d654bebc7d2562c","unresolved":false,"context_lines":[{"line_number":7901,"context_line":"        self.driver.common.provision.remove_device_from_storage_group("},{"line_number":7902,"context_line":"            conn, controllerConfigService, self.data.default_sg_instance_name,"},{"line_number":7903,"context_line":"            volumeInstanceName, volumeName, extraSpecs)"},{"line_number":7904,"context_line":""},{"line_number":7905,"context_line":"    def test_add_members_to_masking_group(self):"},{"line_number":7906,"context_line":"        conn \u003d FakeEcomConnection()"},{"line_number":7907,"context_line":"        controllerConfigService \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_825adf81","line":7904,"updated":"2016-05-18 16:23:30.000000000","message":"Any asserts? What are you validating by these tests?","commit_id":"1764bcb40c5458ff0e4515f39dfc0d8201276f06"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c9e2b0994cb5fea097c99b36e91a4ea90fcf7b3e","unresolved":false,"context_lines":[{"line_number":7901,"context_line":"        self.driver.common.provision.remove_device_from_storage_group("},{"line_number":7902,"context_line":"            conn, controllerConfigService, self.data.default_sg_instance_name,"},{"line_number":7903,"context_line":"            volumeInstanceName, volumeName, extraSpecs)"},{"line_number":7904,"context_line":""},{"line_number":7905,"context_line":"    def test_add_members_to_masking_group(self):"},{"line_number":7906,"context_line":"        conn \u003d FakeEcomConnection()"},{"line_number":7907,"context_line":"        controllerConfigService \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_6bc32858","line":7904,"in_reply_to":"bab6814e_825adf81","updated":"2016-05-25 10:26:24.000000000","message":"We will put in assert_called_with.  Thanks","commit_id":"1764bcb40c5458ff0e4515f39dfc0d8201276f06"}],"cinder/volume/drivers/emc/emc_vmax_provision.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"6c3b76149772a62fbfcb18d73d654bebc7d2562c","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            storageGroupInstance \u003d conn.GetInstance(sgInstanceName)"},{"line_number":287,"context_line":"        except Exception:"},{"line_number":288,"context_line":"            exceptionMessage \u003d (_("},{"line_number":289,"context_line":"                \"Unable to get the name of the storage group\"))"},{"line_number":290,"context_line":"            LOG.error(exceptionMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_62ed3b8b","line":287,"updated":"2016-05-18 16:23:30.000000000","message":"You lose the original exception message here. Maybe add it to the error raised below?  Same for other method.","commit_id":"1764bcb40c5458ff0e4515f39dfc0d8201276f06"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1088b03010da097d1fd6511c3e78deee594619ef","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            storageGroupInstance \u003d conn.GetInstance(sgInstanceName)"},{"line_number":287,"context_line":"        except Exception:"},{"line_number":288,"context_line":"            exceptionMessage \u003d (_("},{"line_number":289,"context_line":"                \"Unable to get the name of the storage group\"))"},{"line_number":290,"context_line":"            LOG.error(exceptionMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_8b580c58","line":287,"in_reply_to":"bab6814e_62ed3b8b","updated":"2016-05-25 10:27:59.000000000","message":"Ok.  Thanks","commit_id":"1764bcb40c5458ff0e4515f39dfc0d8201276f06"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7d16d6a29efea757b19e6d2a34317b6993723c73","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            storageGroupInstance \u003d conn.GetInstance(sgInstanceName)"},{"line_number":287,"context_line":"        except Exception:"},{"line_number":288,"context_line":"            exceptionMessage \u003d (_("},{"line_number":289,"context_line":"                \"Unable to get the name of the storage group\"))"},{"line_number":290,"context_line":"            LOG.error(exceptionMessage)"},{"line_number":291,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":292,"context_line":"                data\u003dexceptionMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_5fda094c","line":289,"range":{"start_line":289,"start_character":55,"end_line":289,"end_character":60},"updated":"2016-05-16 19:33:55.000000000","message":"Suggest adding \u0027.\u0027 at EOL.","commit_id":"1764bcb40c5458ff0e4515f39dfc0d8201276f06"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1088b03010da097d1fd6511c3e78deee594619ef","unresolved":false,"context_lines":[{"line_number":286,"context_line":"            storageGroupInstance \u003d conn.GetInstance(sgInstanceName)"},{"line_number":287,"context_line":"        except Exception:"},{"line_number":288,"context_line":"            exceptionMessage \u003d (_("},{"line_number":289,"context_line":"                \"Unable to get the name of the storage group\"))"},{"line_number":290,"context_line":"            LOG.error(exceptionMessage)"},{"line_number":291,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":292,"context_line":"                data\u003dexceptionMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_eb3d58de","line":289,"range":{"start_line":289,"start_character":55,"end_line":289,"end_character":60},"in_reply_to":"dab17558_5fda094c","updated":"2016-05-25 10:27:59.000000000","message":"Ok.  Thanks","commit_id":"1764bcb40c5458ff0e4515f39dfc0d8201276f06"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7d16d6a29efea757b19e6d2a34317b6993723c73","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            storageGroupInstance \u003d conn.GetInstance(storageGroupInstanceName)"},{"line_number":336,"context_line":"        except Exception:"},{"line_number":337,"context_line":"            exceptionMessage \u003d (_("},{"line_number":338,"context_line":"                \"Unable to get the name of the storage group\"))"},{"line_number":339,"context_line":"            LOG.error(exceptionMessage)"},{"line_number":340,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":341,"context_line":"                data\u003dexceptionMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_bfeb35db","line":338,"range":{"start_line":338,"start_character":55,"end_line":338,"end_character":61},"updated":"2016-05-16 19:33:55.000000000","message":"Suggest adding \u0027.\u0027 at EOL.","commit_id":"1764bcb40c5458ff0e4515f39dfc0d8201276f06"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"1088b03010da097d1fd6511c3e78deee594619ef","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            storageGroupInstance \u003d conn.GetInstance(storageGroupInstanceName)"},{"line_number":336,"context_line":"        except Exception:"},{"line_number":337,"context_line":"            exceptionMessage \u003d (_("},{"line_number":338,"context_line":"                \"Unable to get the name of the storage group\"))"},{"line_number":339,"context_line":"            LOG.error(exceptionMessage)"},{"line_number":340,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":341,"context_line":"                data\u003dexceptionMessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_6b2a0892","line":338,"range":{"start_line":338,"start_character":55,"end_line":338,"end_character":61},"in_reply_to":"dab17558_bfeb35db","updated":"2016-05-25 10:27:59.000000000","message":"Will do.  Thanks","commit_id":"1764bcb40c5458ff0e4515f39dfc0d8201276f06"}]}