)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"00a683cd61ff67da1d2eaeff4f7343c6930fed41","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        updates, snapshot_updates \u003d self.driver.update_provider_info("},{"line_number":390,"context_line":"            volumes, snapshots)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        if updates:"},{"line_number":393,"context_line":"            host_vols \u003d utils.list_of_dicts_to_dict(volumes, \u0027id\u0027)"},{"line_number":394,"context_line":"            for u in updates:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_ec44b473","line":391,"updated":"2016-05-17 22:06:55.000000000","message":"seems reasonable, I am curious why that enumeration might be taking so long.  Should probably optimize that a bit","commit_id":"56c38787be6d7ae2466a6ebaaa71399ae46621ee"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"8ef92290b86c75dd9bf59d35c682da04580f9439","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        updates, snapshot_updates \u003d self.driver.update_provider_info("},{"line_number":390,"context_line":"            volumes, snapshots)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        if updates:"},{"line_number":393,"context_line":"            host_vols \u003d utils.list_of_dicts_to_dict(volumes, \u0027id\u0027)"},{"line_number":394,"context_line":"            for u in updates:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_762d2fa7","line":391,"in_reply_to":"dab17558_ec44b473","updated":"2016-05-18 00:38:26.000000000","message":"Umm, good point. Actually I\u0027m not sure the reason why enumerate is slow...\n\nI changed volume iteration operation to use same logic as snapshot ones. Could you try the patch set 2 again?","commit_id":"56c38787be6d7ae2466a6ebaaa71399ae46621ee"}]}