)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":18378,"name":"Jeremy Arnold","email":"arnoldje@us.ibm.com","username":"arnoldje"},"change_message_id":"d53f8b19ac6a0230db34434cf0f2896f5d6d2396","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                return"},{"line_number":984,"context_line":""},{"line_number":985,"context_line":"            self._notify_about_volume_usage(context, volume, \"attach.start\","},{"line_number":986,"context_line":"                                            attachment\u003dattachment)"},{"line_number":987,"context_line":"            values \u003d {\u0027volume_id\u0027: volume_id,"},{"line_number":988,"context_line":"                      \u0027attach_status\u0027: \u0027attaching\u0027, }"},{"line_number":989,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_812461af","line":986,"updated":"2016-05-19 15:36:29.000000000","message":"In the lines above, we just guaranteed that attachment is None at this point.  So it would be more clear if we either passed None explicitly or just relied on the default parameter value.","commit_id":"242362317bd1fd9e95a7b5da0dd1079c649ac761"}],"cinder/volume/utils.py":[{"author":{"_account_id":18378,"name":"Jeremy Arnold","email":"arnoldje@us.ibm.com","username":"arnoldje"},"change_message_id":"d53f8b19ac6a0230db34434cf0f2896f5d6d2396","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        host \u003d CONF.host"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    if attachment:"},{"line_number":125,"context_line":"        usage_info \u003d attachment"},{"line_number":126,"context_line":"    else:"},{"line_number":127,"context_line":"        if not extra_usage_info:"},{"line_number":128,"context_line":"            extra_usage_info \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_8e3f70d5","line":125,"updated":"2016-05-19 15:36:29.000000000","message":"In the original code (with no attachment parameter), the usage_info provided by _usage_from_volume includes attachment information, but also several other values.  In the new code, all we get is the attachment.  That seems like it would be a problem for the event consumers.","commit_id":"242362317bd1fd9e95a7b5da0dd1079c649ac761"}]}