)]}'
{"cinder/tests/unit/test_volume_rpcapi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b9d7e2dcba9406359ed0cb221b8f54b686fa3016","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Unit Tests for cinder.volume.rpcapi"},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":"import copy"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":40,"id":"7a77a97e_1361e6a8","line":19,"updated":"2016-11-22 12:45:25.000000000","message":"Why people don\u0027t place libraries in the right section?  Mock is not a standard python library.  :-(","commit_id":"74370b7a0e5170ab6e1077d857bb865a07827448"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5456f7b8c652b473a739a445fa79c7e1e92eb802","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        self.fake_volume_obj.cluster_name \u003d \u0027my_cluster\u0027"},{"line_number":418,"context_line":"        self.fake_volume_obj.obj_reset_changes([\u0027cluster_name\u0027])"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def test_attach_volume_to_cluster(self):"},{"line_number":421,"context_line":"        self._set_cluster()"},{"line_number":422,"context_line":"        self._test_volume_api(\u0027attach_volume\u0027,"},{"line_number":423,"context_line":"                              rpc_method\u003d\u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a74a57a_ddfe31ad","line":420,"range":{"start_line":420,"start_character":8,"end_line":420,"end_character":37},"updated":"2016-11-28 10:40:05.000000000","message":"I would remove _to_ part - it suggests that this is similar to \"attach_volume_to_host\" and \"attach_volume_to_instance\".","commit_id":"aff65749b75f859162ff958b10b2cd0979fb82f0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a6266b5f3b1854c7edd2fb5ce9622ac88c29b606","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        self.fake_volume_obj.cluster_name \u003d \u0027my_cluster\u0027"},{"line_number":418,"context_line":"        self.fake_volume_obj.obj_reset_changes([\u0027cluster_name\u0027])"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def test_attach_volume_to_cluster(self):"},{"line_number":421,"context_line":"        self._set_cluster()"},{"line_number":422,"context_line":"        self._test_volume_api(\u0027attach_volume\u0027,"},{"line_number":423,"context_line":"                              rpc_method\u003d\u0027call\u0027,"}],"source_content_type":"text/x-python","patch_set":42,"id":"5a74a57a_c6fe5ead","line":420,"range":{"start_line":420,"start_character":8,"end_line":420,"end_character":37},"in_reply_to":"5a74a57a_ddfe31ad","updated":"2016-11-28 11:38:50.000000000","message":"Same thing would happen if I rename it to `test_attach_volume_cluster`, it may indicate that the method is `attach_volume_cluster` when it\u0027s not, so removing `_to` wouldn\u0027t remove all ambiguity either.","commit_id":"aff65749b75f859162ff958b10b2cd0979fb82f0"}]}