)]}'
{"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bb41fec45cc37ba88572af234b59d7ba558ccc89","unresolved":false,"context_lines":[{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    def _check_volume_type_for_lun(self, volume, lun, existing_ref,"},{"line_number":640,"context_line":"                                   extra_specs):"},{"line_number":641,"context_line":"        \"\"\"Checks if lun satifies the volume type.\"\"\""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":644,"context_line":"        \"\"\"Brings an existing storage object under Cinder management."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_4ae73bb0","line":641,"range":{"start_line":641,"start_character":25,"end_line":641,"end_character":34},"updated":"2016-05-19 14:08:46.000000000","message":"satisfies\n\nI know you didn\u0027t do it but I think the leave campground cleaner rule applies.  You camped here :)","commit_id":"525baf0d97c8971e9515086aa12494ccde39563f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"13208a794a517a9d3f43f3bcf9c8d1cd7abefe06","unresolved":false,"context_lines":[{"line_number":638,"context_line":""},{"line_number":639,"context_line":"    def _check_volume_type_for_lun(self, volume, lun, existing_ref,"},{"line_number":640,"context_line":"                                   extra_specs):"},{"line_number":641,"context_line":"        \"\"\"Checks if lun satifies the volume type.\"\"\""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":644,"context_line":"        \"\"\"Brings an existing storage object under Cinder management."}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_1e79f1c8","line":641,"range":{"start_line":641,"start_character":25,"end_line":641,"end_character":34},"in_reply_to":"bab6814e_4ae73bb0","updated":"2016-05-19 16:42:05.000000000","message":"Thanks, Tom, fixed.","commit_id":"525baf0d97c8971e9515086aa12494ccde39563f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bb41fec45cc37ba88572af234b59d7ba558ccc89","unresolved":false,"context_lines":[{"line_number":639,"context_line":"    def _check_volume_type_for_lun(self, volume, lun, existing_ref,"},{"line_number":640,"context_line":"                                   extra_specs):"},{"line_number":641,"context_line":"        \"\"\"Checks if lun satifies the volume type.\"\"\""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":644,"context_line":"        \"\"\"Brings an existing storage object under Cinder management."},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0d742d66","line":642,"updated":"2016-05-19 14:08:46.000000000","message":"pass ?  return None?\n\nI know this works because it has a doc string, but is that considered good style?","commit_id":"525baf0d97c8971e9515086aa12494ccde39563f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"13208a794a517a9d3f43f3bcf9c8d1cd7abefe06","unresolved":false,"context_lines":[{"line_number":639,"context_line":"    def _check_volume_type_for_lun(self, volume, lun, existing_ref,"},{"line_number":640,"context_line":"                                   extra_specs):"},{"line_number":641,"context_line":"        \"\"\"Checks if lun satifies the volume type.\"\"\""},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"    def manage_existing(self, volume, existing_ref):"},{"line_number":644,"context_line":"        \"\"\"Brings an existing storage object under Cinder management."},{"line_number":645,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_de6e4900","line":642,"in_reply_to":"bab6814e_0d742d66","updated":"2016-05-19 16:42:05.000000000","message":"I\u0027ve gotten -1 reviews in Manila from empty methods with both \u0027pass\u0027 and a docstring.  I don\u0027t see anything in a style guide about this, but according to the Python grammar specification, it\u0027s legal and not accidental.","commit_id":"525baf0d97c8971e9515086aa12494ccde39563f"}],"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bb41fec45cc37ba88572af234b59d7ba558ccc89","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        return capacity[\u0027size-total\u0027], capacity[\u0027size-available\u0027]"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def _check_volume_type(self, volume, share, file_name, extra_specs):"},{"line_number":819,"context_line":"        \"\"\"Match volume type for share file.\"\"\""},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def _convert_vol_ref_share_name_to_share_ip(self, vol_ref):"},{"line_number":822,"context_line":"        \"\"\"Converts the share point name to an IP address"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_aa450718","line":819,"updated":"2016-05-19 14:08:46.000000000","message":"pass ?  return None?\n\nI know this works because it has a doc string, but is that considered good style?","commit_id":"525baf0d97c8971e9515086aa12494ccde39563f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"13208a794a517a9d3f43f3bcf9c8d1cd7abefe06","unresolved":false,"context_lines":[{"line_number":816,"context_line":"        return capacity[\u0027size-total\u0027], capacity[\u0027size-available\u0027]"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def _check_volume_type(self, volume, share, file_name, extra_specs):"},{"line_number":819,"context_line":"        \"\"\"Match volume type for share file.\"\"\""},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def _convert_vol_ref_share_name_to_share_ip(self, vol_ref):"},{"line_number":822,"context_line":"        \"\"\"Converts the share point name to an IP address"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_5e31b904","line":819,"in_reply_to":"bab6814e_aa450718","updated":"2016-05-19 16:42:05.000000000","message":"Same answer.  Having both \u0027pass\u0027 and a docstring is redundant.","commit_id":"525baf0d97c8971e9515086aa12494ccde39563f"}]}