)]}'
{"cinder/tests/unit/test_hpelefthand.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"441358243a01df2317cfbc1801fb0daa7a84a571","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":611,"context_line":"            mock_client.reset_mock()"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        # setup_mock_client drive with CHAP enabled configuration"},{"line_number":614,"context_line":"        # and return the mock HTTP LeftHand client"},{"line_number":615,"context_line":"        conf \u003d self.default_mock_conf()"},{"line_number":616,"context_line":"        conf.hpelefthand_iscsi_chap_enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_f6230dbb","line":613,"updated":"2016-06-08 14:14:00.000000000","message":"These really should be two separate tests, one to validate CHAP enabled and one to validate it disabled.","commit_id":"c8a7de05b28c326c9d39e4c6738dbcf511758181"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"51575f5df6b3b018e5c1c171d0e985e5b54f1bf6","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":611,"context_line":"            mock_client.reset_mock()"},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        # setup_mock_client drive with CHAP enabled configuration"},{"line_number":614,"context_line":"        # and return the mock HTTP LeftHand client"},{"line_number":615,"context_line":"        conf \u003d self.default_mock_conf()"},{"line_number":616,"context_line":"        conf.hpelefthand_iscsi_chap_enabled \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_1e5cab24","line":613,"in_reply_to":"7aa08908_f6230dbb","updated":"2016-06-20 06:47:14.000000000","message":"Done","commit_id":"c8a7de05b28c326c9d39e4c6738dbcf511758181"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"441358243a01df2317cfbc1801fb0daa7a84a571","unresolved":false,"context_lines":[{"line_number":636,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"            # test initialize_connection with chapAuthenticationRequired"},{"line_number":639,"context_line":"            mock_client.getServerByName.side_effect \u003d \\"},{"line_number":640,"context_line":"                hpeexceptions.HTTPNotFound()"},{"line_number":641,"context_line":"            mock_client.createServer.return_value \u003d {"},{"line_number":642,"context_line":"                \u0027id\u0027: self.server_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_961ba980","line":639,"range":{"start_line":639,"start_character":54,"end_line":639,"end_character":55},"updated":"2016-06-08 14:14:00.000000000","message":"Try to avoid \\ for line continuation if possible.","commit_id":"c8a7de05b28c326c9d39e4c6738dbcf511758181"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"51575f5df6b3b018e5c1c171d0e985e5b54f1bf6","unresolved":false,"context_lines":[{"line_number":636,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"            # test initialize_connection with chapAuthenticationRequired"},{"line_number":639,"context_line":"            mock_client.getServerByName.side_effect \u003d \\"},{"line_number":640,"context_line":"                hpeexceptions.HTTPNotFound()"},{"line_number":641,"context_line":"            mock_client.createServer.return_value \u003d {"},{"line_number":642,"context_line":"                \u0027id\u0027: self.server_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_7e416f39","line":639,"range":{"start_line":639,"start_character":54,"end_line":639,"end_character":55},"in_reply_to":"7aa08908_961ba980","updated":"2016-06-20 06:47:14.000000000","message":"Done","commit_id":"c8a7de05b28c326c9d39e4c6738dbcf511758181"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b7497f3d628803ed5605fcd44bf48eb47b8c3b78","unresolved":false,"context_lines":[{"line_number":1368,"context_line":"                           \u0027provider_location\u0027: provider_location}"},{"line_number":1369,"context_line":"        original_volume_status \u003d \u0027available\u0027"},{"line_number":1370,"context_line":"        # mock HTTPServerError (array failure)"},{"line_number":1371,"context_line":"        mock_client.modifyVolume.side_effect \u003d\\"},{"line_number":1372,"context_line":"            hpeexceptions.HTTPServerError()"},{"line_number":1373,"context_line":"        with mock.patch.object(hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":1374,"context_line":"                               \u0027_create_client\u0027) as mock_do_setup:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_e570bc42","line":1371,"updated":"2016-06-29 12:58:10.000000000","message":"If you do an update, please reformat this to get rid of the \\ to span multiple lines. I think this should fit on one, or you can use () to wrap it.\n\nWe\u0027ve been a little more strict on the main code than the test code, but I think we need to start enforcing this more.","commit_id":"3d34ce0b33698b89aadad113c0f079e875e32747"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b7497f3d628803ed5605fcd44bf48eb47b8c3b78","unresolved":false,"context_lines":[{"line_number":1905,"context_line":"            mock_client.getSnapshotByName.return_value \u003d {\u0027id\u0027: \u00274\u0027}"},{"line_number":1906,"context_line":"            mock_client.getSnapshotParentVolume.return_value \u003d {"},{"line_number":1907,"context_line":"                \u0027name\u0027: \u0027volume-222\u0027}"},{"line_number":1908,"context_line":"            mock_client.modifySnapshot.side_effect \u003d \\"},{"line_number":1909,"context_line":"                hpeexceptions.HTTPServerError"},{"line_number":1910,"context_line":"            expected \u003d [mock.call.getSnapshotByName(\u0027fakeshapshot\u0027),"},{"line_number":1911,"context_line":"                        mock.call.getSnapshotParentVolume(\u0027fakeshapshot\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_25bc84ba","line":1908,"range":{"start_line":1908,"start_character":53,"end_line":1908,"end_character":54},"updated":"2016-06-29 12:58:10.000000000","message":"Same.","commit_id":"3d34ce0b33698b89aadad113c0f079e875e32747"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"9552a3e1f252ae3a3fecde446dc3f0828797f017","unresolved":false,"context_lines":[{"line_number":1935,"context_line":""},{"line_number":1936,"context_line":"            # Non existence of parent volume of a snapshot"},{"line_number":1937,"context_line":"            # raises HTTPNotFound exception"},{"line_number":1938,"context_line":"            mock_client.getSnapshotParentVolume.side_effect \u003d\\"},{"line_number":1939,"context_line":"                hpeexceptions.HTTPNotFound"},{"line_number":1940,"context_line":"            self.assertRaises(exception.InvalidInput,"},{"line_number":1941,"context_line":"                              self.driver._manage_snapshot,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_168edc78","line":1938,"range":{"start_line":1938,"start_character":61,"end_line":1938,"end_character":62},"updated":"2016-06-29 13:43:13.000000000","message":"Here\u0027s another one that could get cleaned up if you push another patchset.","commit_id":"3d34ce0b33698b89aadad113c0f079e875e32747"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"9552a3e1f252ae3a3fecde446dc3f0828797f017","unresolved":false,"context_lines":[{"line_number":1946,"context_line":"                              existing_ref\u003dexisting_ref)"},{"line_number":1947,"context_line":""},{"line_number":1948,"context_line":"            # Non existence of a snapshot raises HTTPNotFound exception"},{"line_number":1949,"context_line":"            mock_client.getSnapshotByName.side_effect \u003d\\"},{"line_number":1950,"context_line":"                hpeexceptions.HTTPNotFound"},{"line_number":1951,"context_line":"            self.assertRaises(exception.InvalidInput,"},{"line_number":1952,"context_line":"                              self.driver._manage_snapshot,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_56ea2410","line":1949,"range":{"start_line":1949,"start_character":55,"end_line":1949,"end_character":56},"updated":"2016-06-29 13:43:13.000000000","message":"Ditto.","commit_id":"3d34ce0b33698b89aadad113c0f079e875e32747"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b7497f3d628803ed5605fcd44bf48eb47b8c3b78","unresolved":false,"context_lines":[{"line_number":2562,"context_line":""},{"line_number":2563,"context_line":"        with mock.patch.object("},{"line_number":2564,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":2565,"context_line":"                \u0027_create_client\u0027) as mock_do_setup, \\"},{"line_number":2566,"context_line":"            mock.patch.object("},{"line_number":2567,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":2568,"context_line":"                \u0027_create_replication_client\u0027) as mock_replication_client:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_c5d2e0ff","line":2565,"updated":"2016-06-29 12:58:10.000000000","message":"Nested with statements are an exception to this. Last I tried I was not able to make this happy without using \\.","commit_id":"3d34ce0b33698b89aadad113c0f079e875e32747"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"9552a3e1f252ae3a3fecde446dc3f0828797f017","unresolved":false,"context_lines":[{"line_number":2629,"context_line":""},{"line_number":2630,"context_line":"        with mock.patch.object("},{"line_number":2631,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":2632,"context_line":"                \u0027_create_client\u0027) as mock_do_setup, \\"},{"line_number":2633,"context_line":"            mock.patch.object("},{"line_number":2634,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":2635,"context_line":"                \u0027_create_replication_client\u0027) as mock_replication_client:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_16e53c37","line":2632,"range":{"start_line":2632,"start_character":52,"end_line":2632,"end_character":53},"updated":"2016-06-29 13:43:13.000000000","message":"Ditto.","commit_id":"3d34ce0b33698b89aadad113c0f079e875e32747"}]}