)]}'
{"tox.ini":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"74fde52230826d721809c9d598a483b6a5768f55","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[testenv:pep8]"},{"line_number":50,"context_line":"commands \u003d"},{"line_number":51,"context_line":"  flake8 {posargs} ."},{"line_number":52,"context_line":"  # Check that .po and .pot files are valid:"},{"line_number":53,"context_line":"  bash -c \"find cinder -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":54,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh --checkopts"},{"line_number":55,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh"},{"line_number":56,"context_line":"  {toxinidir}/tools/check_exec.py {toxinidir}/cinder"}],"source_content_type":"text/x-properties","patch_set":2,"id":"bab6814e_a0b3ed08","side":"PARENT","line":53,"range":{"start_line":52,"start_character":2,"end_line":53,"end_character":106},"updated":"2016-05-23 09:56:09.000000000","message":"-1: Why is this considered to be obsolete?  I believe this should be kept.","commit_id":"45d0f6270ca73d3c21a1cfa378a8b445d0148792"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0f038530040493681ea54240832dec2c4d86efc7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[testenv:pep8]"},{"line_number":50,"context_line":"commands \u003d"},{"line_number":51,"context_line":"  flake8 {posargs} ."},{"line_number":52,"context_line":"  # Check that .po and .pot files are valid:"},{"line_number":53,"context_line":"  bash -c \"find cinder -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":54,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh --checkopts"},{"line_number":55,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh"},{"line_number":56,"context_line":"  {toxinidir}/tools/check_exec.py {toxinidir}/cinder"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1ac06dbe_25296a38","side":"PARENT","line":53,"range":{"start_line":52,"start_character":2,"end_line":53,"end_character":106},"in_reply_to":"9abb7d3a_2a24c5ad","updated":"2016-08-25 09:02:13.000000000","message":"Thanks for the explanation","commit_id":"45d0f6270ca73d3c21a1cfa378a8b445d0148792"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"98b59430ff6f791451748cbe61023ab902327eae","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[testenv:pep8]"},{"line_number":50,"context_line":"commands \u003d"},{"line_number":51,"context_line":"  flake8 {posargs} ."},{"line_number":52,"context_line":"  # Check that .po and .pot files are valid:"},{"line_number":53,"context_line":"  bash -c \"find cinder -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":54,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh --checkopts"},{"line_number":55,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh"},{"line_number":56,"context_line":"  {toxinidir}/tools/check_exec.py {toxinidir}/cinder"}],"source_content_type":"text/x-properties","patch_set":2,"id":"bab6814e_cf3dc4de","side":"PARENT","line":53,"range":{"start_line":52,"start_character":2,"end_line":53,"end_character":106},"in_reply_to":"bab6814e_a0b3ed08","updated":"2016-05-26 09:50:40.000000000","message":"In the nova version of this change sdague explicitly requested the removal. So I assume that this is valid for cinder as well. As far as I understand, pot files are removed anyways from the repo, and the po files are implicitly tested by calling compile_catalog command in CI.","commit_id":"45d0f6270ca73d3c21a1cfa378a8b445d0148792"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"e2ec42972bd73aeb72e9d54c1575572b0ab6b7f0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[testenv:pep8]"},{"line_number":50,"context_line":"commands \u003d"},{"line_number":51,"context_line":"  flake8 {posargs} ."},{"line_number":52,"context_line":"  # Check that .po and .pot files are valid:"},{"line_number":53,"context_line":"  bash -c \"find cinder -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":54,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh --checkopts"},{"line_number":55,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh"},{"line_number":56,"context_line":"  {toxinidir}/tools/check_exec.py {toxinidir}/cinder"}],"source_content_type":"text/x-properties","patch_set":2,"id":"bab6814e_d0655845","side":"PARENT","line":53,"range":{"start_line":52,"start_character":2,"end_line":53,"end_character":106},"in_reply_to":"bab6814e_cf3dc4de","updated":"2016-05-26 12:39:09.000000000","message":"I\u0027d suggest to replace this line by \u0027python setup.py compile_catalog\u0027 to validate .po files. msgfmt validation doesn\u0027t check headers properly and i\u0027ve seen cases where it passed and compile_catalog failed because of incorrect values for headers in .po files.","commit_id":"45d0f6270ca73d3c21a1cfa378a8b445d0148792"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"a2a178092f907895754fdd6186f9144e4a34f236","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[testenv:pep8]"},{"line_number":50,"context_line":"commands \u003d"},{"line_number":51,"context_line":"  flake8 {posargs} ."},{"line_number":52,"context_line":"  # Check that .po and .pot files are valid:"},{"line_number":53,"context_line":"  bash -c \"find cinder -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":54,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh --checkopts"},{"line_number":55,"context_line":"  {toxinidir}/tools/config/check_uptodate.sh"},{"line_number":56,"context_line":"  {toxinidir}/tools/check_exec.py {toxinidir}/cinder"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9abb7d3a_2a24c5ad","side":"PARENT","line":53,"range":{"start_line":52,"start_character":2,"end_line":53,"end_character":106},"in_reply_to":"bab6814e_d0655845","updated":"2016-06-02 13:08:28.000000000","message":"I understood sdague as this exactly is already happening, which is why the lines can be removed.","commit_id":"45d0f6270ca73d3c21a1cfa378a8b445d0148792"}]}