)]}'
{"cinder/tests/unit/test_hpelefthand.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":796,"context_line":"                \u0027replication_enabled\u0027: \u0027\u003cis\u003e True\u0027}}"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        import copy"},{"line_number":799,"context_line":"        volume \u003d copy.deepcopy(self.volume)"},{"line_number":800,"context_line":"        volume[\u0027volume_type_id\u0027] \u003d self.volume_type_id"},{"line_number":801,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f2efb2e6","line":798,"updated":"2016-06-24 10:25:29.000000000","message":"-1: I think this import is not necessary, but if it is, please move to the import section","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":796,"context_line":"                \u0027replication_enabled\u0027: \u0027\u003cis\u003e True\u0027}}"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        import copy"},{"line_number":799,"context_line":"        volume \u003d copy.deepcopy(self.volume)"},{"line_number":800,"context_line":"        volume[\u0027volume_type_id\u0027] \u003d self.volume_type_id"},{"line_number":801,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_7ba708bd","line":798,"in_reply_to":"3aaa91ec_f2efb2e6","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                \u0027replication_enabled\u0027: \u0027\u003cis\u003e True\u0027}}"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        import copy"},{"line_number":799,"context_line":"        volume \u003d copy.deepcopy(self.volume)"},{"line_number":800,"context_line":"        volume[\u0027volume_type_id\u0027] \u003d self.volume_type_id"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"        with mock.patch.object(hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_32913a48","line":799,"updated":"2016-06-24 10:25:29.000000000","message":"nit: You don\u0027t need to do a deepcopy since you are just changing volume_type_id, it would be enough doing\n\n volume \u003d self.volume.copy()","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":796,"context_line":"                \u0027replication_enabled\u0027: \u0027\u003cis\u003e True\u0027}}"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        import copy"},{"line_number":799,"context_line":"        volume \u003d copy.deepcopy(self.volume)"},{"line_number":800,"context_line":"        volume[\u0027volume_type_id\u0027] \u003d self.volume_type_id"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"        with mock.patch.object(hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_dbaa7c84","line":799,"in_reply_to":"3aaa91ec_32913a48","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            expected_location \u003d \"10.0.1.6:3260,1 %s\" % expected_iqn"},{"line_number":812,"context_line":"            self.assertEqual(expected_location,"},{"line_number":813,"context_line":"                             model_update[\u0027provider_location\u0027])"},{"line_number":814,"context_line":"            self.assertEqual(model_update[\u0027replication_status\u0027], \u0027enabled\u0027)"},{"line_number":815,"context_line":"            # expected calls"},{"line_number":816,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":817,"context_line":"                mock.call.getSnapshotByName(\u0027fakeshapshot\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_152d0895","line":814,"range":{"start_line":814,"start_character":12,"end_line":814,"end_character":75},"updated":"2016-06-24 10:25:29.000000000","message":"-1: assert arguments should be (expected, result)\n\n self.assertEqual(\u0027enabled\u0027, model_update[\u0027replication_status\u0027])","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":811,"context_line":"            expected_location \u003d \"10.0.1.6:3260,1 %s\" % expected_iqn"},{"line_number":812,"context_line":"            self.assertEqual(expected_location,"},{"line_number":813,"context_line":"                             model_update[\u0027provider_location\u0027])"},{"line_number":814,"context_line":"            self.assertEqual(model_update[\u0027replication_status\u0027], \u0027enabled\u0027)"},{"line_number":815,"context_line":"            # expected calls"},{"line_number":816,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":817,"context_line":"                mock.call.getSnapshotByName(\u0027fakeshapshot\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_fb7ad822","line":814,"range":{"start_line":814,"start_character":12,"end_line":814,"end_character":75},"in_reply_to":"3aaa91ec_152d0895","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9175c8d1334a04916e50321ebf2399ae94adbe72","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            # testing when getSnapshotByName returns an exception"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"            mock_client.reset_mock()"},{"line_number":828,"context_line":"            mock_client.getSnapshotByName.side_effect \u003d\\"},{"line_number":829,"context_line":"                hpeexceptions.HTTPNotFound()"},{"line_number":830,"context_line":"            self.assertRaises("},{"line_number":831,"context_line":"                exception.VolumeBackendAPIException,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d8291039","line":828,"updated":"2016-06-23 21:59:53.000000000","message":"Please use () instead of \\","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            # testing when getSnapshotByName returns an exception"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"            mock_client.reset_mock()"},{"line_number":828,"context_line":"            mock_client.getSnapshotByName.side_effect \u003d\\"},{"line_number":829,"context_line":"                hpeexceptions.HTTPNotFound()"},{"line_number":830,"context_line":"            self.assertRaises("},{"line_number":831,"context_line":"                exception.VolumeBackendAPIException,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_9b92b44a","line":828,"in_reply_to":"3aaa91ec_d8291039","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                mock.call.logout()]"},{"line_number":823,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"            # testing when getSnapshotByName returns an exception"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"            mock_client.reset_mock()"},{"line_number":828,"context_line":"            mock_client.getSnapshotByName.side_effect \u003d\\"},{"line_number":829,"context_line":"                hpeexceptions.HTTPNotFound()"},{"line_number":830,"context_line":"            self.assertRaises("},{"line_number":831,"context_line":"                exception.VolumeBackendAPIException,"},{"line_number":832,"context_line":"                self.driver.create_volume_from_snapshot, volume, self.snapshot)"},{"line_number":833,"context_line":"            # expected calls"},{"line_number":834,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":835,"context_line":"                mock.call.getSnapshotByName(\u0027fakeshapshot\u0027),"},{"line_number":836,"context_line":"                mock.call.logout()]"},{"line_number":837,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def test_create_cloned_volume(self):"},{"line_number":840,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_d546e04d","line":837,"range":{"start_line":825,"start_character":1,"end_line":837,"end_character":50},"updated":"2016-06-24 10:25:29.000000000","message":"nit: This should go in another method since it\u0027s a different test case.","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                mock.call.logout()]"},{"line_number":823,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"            # testing when getSnapshotByName returns an exception"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"            mock_client.reset_mock()"},{"line_number":828,"context_line":"            mock_client.getSnapshotByName.side_effect \u003d\\"},{"line_number":829,"context_line":"                hpeexceptions.HTTPNotFound()"},{"line_number":830,"context_line":"            self.assertRaises("},{"line_number":831,"context_line":"                exception.VolumeBackendAPIException,"},{"line_number":832,"context_line":"                self.driver.create_volume_from_snapshot, volume, self.snapshot)"},{"line_number":833,"context_line":"            # expected calls"},{"line_number":834,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":835,"context_line":"                mock.call.getSnapshotByName(\u0027fakeshapshot\u0027),"},{"line_number":836,"context_line":"                mock.call.logout()]"},{"line_number":837,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"    def test_create_cloned_volume(self):"},{"line_number":840,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_31b91f16","line":837,"range":{"start_line":825,"start_character":1,"end_line":837,"end_character":50},"in_reply_to":"3aaa91ec_d546e04d","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":885,"context_line":"            \u0027name\u0027: \u0027replicated\u0027,"},{"line_number":886,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":887,"context_line":"                \u0027replication_enabled\u0027: \u0027\u003cis\u003e True\u0027}}"},{"line_number":888,"context_line":"        cloned_volume \u003d {}"},{"line_number":889,"context_line":"        cloned_volume.update(self.cloned_volume)"},{"line_number":890,"context_line":"        cloned_volume[\u0027volume_type_id\u0027] \u003d self.volume_type_id"},{"line_number":891,"context_line":"        with mock.patch.object("},{"line_number":892,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_75f1ec00","line":889,"range":{"start_line":888,"start_character":0,"end_line":889,"end_character":48},"updated":"2016-06-24 10:25:29.000000000","message":"nit: cloned_volume \u003d self.cloned_volume.copy()","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":885,"context_line":"            \u0027name\u0027: \u0027replicated\u0027,"},{"line_number":886,"context_line":"            \u0027extra_specs\u0027: {"},{"line_number":887,"context_line":"                \u0027replication_enabled\u0027: \u0027\u003cis\u003e True\u0027}}"},{"line_number":888,"context_line":"        cloned_volume \u003d {}"},{"line_number":889,"context_line":"        cloned_volume.update(self.cloned_volume)"},{"line_number":890,"context_line":"        cloned_volume[\u0027volume_type_id\u0027] \u003d self.volume_type_id"},{"line_number":891,"context_line":"        with mock.patch.object("},{"line_number":892,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_719ba718","line":889,"range":{"start_line":888,"start_character":0,"end_line":889,"end_character":48},"in_reply_to":"3aaa91ec_75f1ec00","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":888,"context_line":"        cloned_volume \u003d {}"},{"line_number":889,"context_line":"        cloned_volume.update(self.cloned_volume)"},{"line_number":890,"context_line":"        cloned_volume[\u0027volume_type_id\u0027] \u003d self.volume_type_id"},{"line_number":891,"context_line":"        with mock.patch.object("},{"line_number":892,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":893,"context_line":"                \u0027_create_client\u0027) as mock_do_setup, \\"},{"line_number":894,"context_line":"            mock.patch.object("},{"line_number":895,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":896,"context_line":"                \u0027_create_replication_client\u0027) as mock_replication_client:"},{"line_number":897,"context_line":"            mock_do_setup.return_value \u003d mock_client"},{"line_number":898,"context_line":"            mock_replication_client.return_value \u003d mock_replicated_client"},{"line_number":899,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_75e56cda","line":896,"range":{"start_line":891,"start_character":0,"end_line":896,"end_character":73},"updated":"2016-06-24 10:25:29.000000000","message":"nit: This way of nesting makes code really hard to read","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":888,"context_line":"        cloned_volume \u003d {}"},{"line_number":889,"context_line":"        cloned_volume.update(self.cloned_volume)"},{"line_number":890,"context_line":"        cloned_volume[\u0027volume_type_id\u0027] \u003d self.volume_type_id"},{"line_number":891,"context_line":"        with mock.patch.object("},{"line_number":892,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":893,"context_line":"                \u0027_create_client\u0027) as mock_do_setup, \\"},{"line_number":894,"context_line":"            mock.patch.object("},{"line_number":895,"context_line":"                hpe_lefthand_iscsi.HPELeftHandISCSIDriver,"},{"line_number":896,"context_line":"                \u0027_create_replication_client\u0027) as mock_replication_client:"},{"line_number":897,"context_line":"            mock_do_setup.return_value \u003d mock_client"},{"line_number":898,"context_line":"            mock_replication_client.return_value \u003d mock_replicated_client"},{"line_number":899,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5493f9f9","line":896,"range":{"start_line":891,"start_character":0,"end_line":896,"end_character":73},"in_reply_to":"3aaa91ec_75e56cda","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":900,"context_line":"            # execute create_cloned_volume"},{"line_number":901,"context_line":"            model_update \u003d self.driver.create_cloned_volume("},{"line_number":902,"context_line":"                cloned_volume, self.volume)"},{"line_number":903,"context_line":"            self.assertEqual(model_update[\u0027replication_status\u0027], \u0027enabled\u0027)"},{"line_number":904,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":905,"context_line":"                mock.call.getVolumeByName(\u0027fakevolume\u0027),"},{"line_number":906,"context_line":"                mock.call.cloneVolume(\u0027clone_volume\u0027, 1),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_75fc4c72","line":903,"updated":"2016-06-24 10:25:29.000000000","message":"-1: assert arguments should be (expected, result)\n\n self.assertEqual(\u0027enabled\u0027, model_update[\u0027replication_status\u0027])","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":900,"context_line":"            # execute create_cloned_volume"},{"line_number":901,"context_line":"            model_update \u003d self.driver.create_cloned_volume("},{"line_number":902,"context_line":"                cloned_volume, self.volume)"},{"line_number":903,"context_line":"            self.assertEqual(model_update[\u0027replication_status\u0027], \u0027enabled\u0027)"},{"line_number":904,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":905,"context_line":"                mock.call.getVolumeByName(\u0027fakevolume\u0027),"},{"line_number":906,"context_line":"                mock.call.cloneVolume(\u0027clone_volume\u0027, 1),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_7450b532","line":903,"in_reply_to":"3aaa91ec_75fc4c72","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9175c8d1334a04916e50321ebf2399ae94adbe72","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"            # handling exception"},{"line_number":931,"context_line":"            mock_client.reset_mock()"},{"line_number":932,"context_line":"            mock_client.cloneVolume.side_effect \u003d\\"},{"line_number":933,"context_line":"                hpeexceptions.HTTPServerError()"},{"line_number":934,"context_line":"            self.assertRaises("},{"line_number":935,"context_line":"                exception.VolumeBackendAPIException,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5816c0f1","line":932,"updated":"2016-06-23 21:59:53.000000000","message":"Same","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":929,"context_line":""},{"line_number":930,"context_line":"            # handling exception"},{"line_number":931,"context_line":"            mock_client.reset_mock()"},{"line_number":932,"context_line":"            mock_client.cloneVolume.side_effect \u003d\\"},{"line_number":933,"context_line":"                hpeexceptions.HTTPServerError()"},{"line_number":934,"context_line":"            self.assertRaises("},{"line_number":935,"context_line":"                exception.VolumeBackendAPIException,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_20eb87e0","line":932,"in_reply_to":"3aaa91ec_5816c0f1","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            mock_replicated_client.assert_has_calls("},{"line_number":928,"context_line":"                expected_calls_replica_client)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"            # handling exception"},{"line_number":931,"context_line":"            mock_client.reset_mock()"},{"line_number":932,"context_line":"            mock_client.cloneVolume.side_effect \u003d\\"},{"line_number":933,"context_line":"                hpeexceptions.HTTPServerError()"},{"line_number":934,"context_line":"            self.assertRaises("},{"line_number":935,"context_line":"                exception.VolumeBackendAPIException,"},{"line_number":936,"context_line":"                self.driver.create_cloned_volume,"},{"line_number":937,"context_line":"                cloned_volume, self.volume)"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"    def test_create_cloned_volume_extend(self):"},{"line_number":940,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_15a228fd","line":937,"range":{"start_line":930,"start_character":0,"end_line":937,"end_character":43},"updated":"2016-06-24 10:25:29.000000000","message":"nit: This should go in another method since it\u0027s a different test case.","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            mock_replicated_client.assert_has_calls("},{"line_number":928,"context_line":"                expected_calls_replica_client)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"            # handling exception"},{"line_number":931,"context_line":"            mock_client.reset_mock()"},{"line_number":932,"context_line":"            mock_client.cloneVolume.side_effect \u003d\\"},{"line_number":933,"context_line":"                hpeexceptions.HTTPServerError()"},{"line_number":934,"context_line":"            self.assertRaises("},{"line_number":935,"context_line":"                exception.VolumeBackendAPIException,"},{"line_number":936,"context_line":"                self.driver.create_cloned_volume,"},{"line_number":937,"context_line":"                cloned_volume, self.volume)"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"    def test_create_cloned_volume_extend(self):"},{"line_number":940,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_00e64b14","line":937,"range":{"start_line":930,"start_character":0,"end_line":937,"end_character":43},"in_reply_to":"3aaa91ec_15a228fd","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"                host)"},{"line_number":1498,"context_line":"            self.assertFalse(migrated)"},{"line_number":1499,"context_line":""},{"line_number":1500,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":1501,"context_line":"                mock.call.getClusterByName(\u0027New_CloudCluster\u0027),"},{"line_number":1502,"context_line":"                mock.call.logout()] + self.driver_startup_call_stack + ["},{"line_number":1503,"context_line":"                mock.call.getVolumeByName(self.volume[\u0027name\u0027]),"},{"line_number":1504,"context_line":"                mock.call.getVolume("},{"line_number":1505,"context_line":"                    self.volume[\u0027id\u0027],"},{"line_number":1506,"context_line":"                    \u0027fields\u003dsnapshots,snapshots[resource[members[name]]]\u0027),"},{"line_number":1507,"context_line":"                mock.call.logout()]"},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":1510,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_5515d046","line":1507,"range":{"start_line":1500,"start_character":1,"end_line":1507,"end_character":35},"updated":"2016-06-24 10:25:29.000000000","message":"-1: expected already has that value, no need to assign it again.","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"                host)"},{"line_number":1498,"context_line":"            self.assertFalse(migrated)"},{"line_number":1499,"context_line":""},{"line_number":1500,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":1501,"context_line":"                mock.call.getClusterByName(\u0027New_CloudCluster\u0027),"},{"line_number":1502,"context_line":"                mock.call.logout()] + self.driver_startup_call_stack + ["},{"line_number":1503,"context_line":"                mock.call.getVolumeByName(self.volume[\u0027name\u0027]),"},{"line_number":1504,"context_line":"                mock.call.getVolume("},{"line_number":1505,"context_line":"                    self.volume[\u0027id\u0027],"},{"line_number":1506,"context_line":"                    \u0027fields\u003dsnapshots,snapshots[resource[members[name]]]\u0027),"},{"line_number":1507,"context_line":"                mock.call.logout()]"},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":1510,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ba6b1fb6","line":1507,"range":{"start_line":1500,"start_character":1,"end_line":1507,"end_character":35},"in_reply_to":"3aaa91ec_5515d046","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1095e8ce1322298aef63d38526d1c9825b4f16b5","unresolved":false,"context_lines":[{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":1490,"context_line":""},{"line_number":1491,"context_line":"            # Testing for any other HTTPServerError"},{"line_number":1492,"context_line":"            mock_client.reset_mock()"},{"line_number":1493,"context_line":"            mock_client.getVolume.side_effect \u003d hpeexceptions.HTTPServerError()"},{"line_number":1494,"context_line":"            (migrated, update) \u003d self.driver.migrate_volume("},{"line_number":1495,"context_line":"                None,"},{"line_number":1496,"context_line":"                self.volume,"},{"line_number":1497,"context_line":"                host)"},{"line_number":1498,"context_line":"            self.assertFalse(migrated)"},{"line_number":1499,"context_line":""},{"line_number":1500,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":1501,"context_line":"                mock.call.getClusterByName(\u0027New_CloudCluster\u0027),"},{"line_number":1502,"context_line":"                mock.call.logout()] + self.driver_startup_call_stack + ["},{"line_number":1503,"context_line":"                mock.call.getVolumeByName(self.volume[\u0027name\u0027]),"},{"line_number":1504,"context_line":"                mock.call.getVolume("},{"line_number":1505,"context_line":"                    self.volume[\u0027id\u0027],"},{"line_number":1506,"context_line":"                    \u0027fields\u003dsnapshots,snapshots[resource[members[name]]]\u0027),"},{"line_number":1507,"context_line":"                mock.call.logout()]"},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    def test_update_migrated_volume(self):"},{"line_number":1512,"context_line":"        mock_client \u003d self.setup_driver()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_f5567c28","line":1509,"range":{"start_line":1491,"start_character":0,"end_line":1509,"end_character":50},"updated":"2016-06-24 10:25:29.000000000","message":"nit: This should go in another method since it\u0027s a different test case.","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"},{"author":{"_account_id":21309,"name":"Jay Mehta","email":"jay87.mehta@gmail.com","username":"Jay"},"change_message_id":"90cc74be17a742f77425df30200cc34f251e5b08","unresolved":false,"context_lines":[{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":1490,"context_line":""},{"line_number":1491,"context_line":"            # Testing for any other HTTPServerError"},{"line_number":1492,"context_line":"            mock_client.reset_mock()"},{"line_number":1493,"context_line":"            mock_client.getVolume.side_effect \u003d hpeexceptions.HTTPServerError()"},{"line_number":1494,"context_line":"            (migrated, update) \u003d self.driver.migrate_volume("},{"line_number":1495,"context_line":"                None,"},{"line_number":1496,"context_line":"                self.volume,"},{"line_number":1497,"context_line":"                host)"},{"line_number":1498,"context_line":"            self.assertFalse(migrated)"},{"line_number":1499,"context_line":""},{"line_number":1500,"context_line":"            expected \u003d self.driver_startup_call_stack + ["},{"line_number":1501,"context_line":"                mock.call.getClusterByName(\u0027New_CloudCluster\u0027),"},{"line_number":1502,"context_line":"                mock.call.logout()] + self.driver_startup_call_stack + ["},{"line_number":1503,"context_line":"                mock.call.getVolumeByName(self.volume[\u0027name\u0027]),"},{"line_number":1504,"context_line":"                mock.call.getVolume("},{"line_number":1505,"context_line":"                    self.volume[\u0027id\u0027],"},{"line_number":1506,"context_line":"                    \u0027fields\u003dsnapshots,snapshots[resource[members[name]]]\u0027),"},{"line_number":1507,"context_line":"                mock.call.logout()]"},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    def test_update_migrated_volume(self):"},{"line_number":1512,"context_line":"        mock_client \u003d self.setup_driver()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_da5c2b1b","line":1509,"range":{"start_line":1491,"start_character":0,"end_line":1509,"end_character":50},"in_reply_to":"3aaa91ec_f5567c28","updated":"2016-06-24 23:20:39.000000000","message":"Done","commit_id":"37732917a4965df35e817bc767d3deddc5e91bef"}]}