)]}'
{"cinder/tests/unit/test_pure.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fea98c01970165411dacde599c16dce9394c4a18","unresolved":false,"context_lines":[{"line_number":1534,"context_line":"    def test_retype_non_repl_to_non_repl(self, mock_is_replicated_type):"},{"line_number":1535,"context_line":"        self._test_retype_repl(mock_is_replicated_type, False, False)"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._enable_replication\u0027)"},{"line_number":1538,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._disable_replication\u0027)"},{"line_number":1539,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._is_volume_replicated_type\u0027, autospec\u003dTrue)"},{"line_number":1540,"context_line":"    def test_retype_non_repl_to_repl(self,"},{"line_number":1541,"context_line":"                                     mock_is_replicated_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_09d6efc2","side":"PARENT","line":1538,"range":{"start_line":1537,"start_character":3,"end_line":1538,"end_character":58},"updated":"2016-05-25 07:54:28.000000000","message":"I don\u0027t think removing these mocks is a good idea, it help to better understand the test.","commit_id":"ee7f9ea093c3cb89be74e8929376aa572cf73184"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"f9b7376eac740baca318b7554cca018620690f76","unresolved":false,"context_lines":[{"line_number":1534,"context_line":"    def test_retype_non_repl_to_non_repl(self, mock_is_replicated_type):"},{"line_number":1535,"context_line":"        self._test_retype_repl(mock_is_replicated_type, False, False)"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._enable_replication\u0027)"},{"line_number":1538,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._disable_replication\u0027)"},{"line_number":1539,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._is_volume_replicated_type\u0027, autospec\u003dTrue)"},{"line_number":1540,"context_line":"    def test_retype_non_repl_to_repl(self,"},{"line_number":1541,"context_line":"                                     mock_is_replicated_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_26665251","side":"PARENT","line":1538,"range":{"start_line":1537,"start_character":3,"end_line":1538,"end_character":58},"in_reply_to":"bab6814e_09d6efc2","updated":"2016-05-25 20:29:38.000000000","message":"Those mocks were the reason the regression happened in the first place. We needed to test that they are actually doing the right thing, which we now do by looking at the mock array.","commit_id":"ee7f9ea093c3cb89be74e8929376aa572cf73184"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8fc2d905a880b857649f7180862b0dc39fb37762","unresolved":false,"context_lines":[{"line_number":1534,"context_line":"    def test_retype_non_repl_to_non_repl(self, mock_is_replicated_type):"},{"line_number":1535,"context_line":"        self._test_retype_repl(mock_is_replicated_type, False, False)"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._enable_replication\u0027)"},{"line_number":1538,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._disable_replication\u0027)"},{"line_number":1539,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._is_volume_replicated_type\u0027, autospec\u003dTrue)"},{"line_number":1540,"context_line":"    def test_retype_non_repl_to_repl(self,"},{"line_number":1541,"context_line":"                                     mock_is_replicated_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_baee08b2","side":"PARENT","line":1538,"range":{"start_line":1537,"start_character":3,"end_line":1538,"end_character":58},"in_reply_to":"bab6814e_26665251","updated":"2016-05-30 09:31:58.000000000","message":"I disagree, the problem was that the mocks didn\u0027t specify \"autospec\u003dTrue\" so anything passed and that the mock_check was clearly wrong and it was checking just for volume in the call.\n\nI think this should be fixed by adding autospec\u003dTrue to both mocks and doing the right assert, because like Vipin says, it\u0027s more clear what you are actually testing.\n\nSame thing with the next test.","commit_id":"ee7f9ea093c3cb89be74e8929376aa572cf73184"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"31f4d809ab3eb0c767d2332f13de40fe41144957","unresolved":false,"context_lines":[{"line_number":1534,"context_line":"    def test_retype_non_repl_to_non_repl(self, mock_is_replicated_type):"},{"line_number":1535,"context_line":"        self._test_retype_repl(mock_is_replicated_type, False, False)"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._enable_replication\u0027)"},{"line_number":1538,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._disable_replication\u0027)"},{"line_number":1539,"context_line":"    @mock.patch(BASE_DRIVER_OBJ + \u0027._is_volume_replicated_type\u0027, autospec\u003dTrue)"},{"line_number":1540,"context_line":"    def test_retype_non_repl_to_repl(self,"},{"line_number":1541,"context_line":"                                     mock_is_replicated_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_46a8a420","side":"PARENT","line":1538,"range":{"start_line":1537,"start_character":3,"end_line":1538,"end_character":58},"in_reply_to":"bab6814e_26665251","updated":"2016-05-26 07:38:16.000000000","message":"Thanks Patrick for the explanation, I did notice this in your commit message. I think it is probably ok not to mock a small helper method like _enable_replication.","commit_id":"ee7f9ea093c3cb89be74e8929376aa572cf73184"}]}