)]}'
{"cinder/volume/drivers/drbdmanagedrv.py":[{"author":{"_account_id":19153,"name":"jingtao liang","email":"liang.jingtao@zte.com.cn","username":"liangjingtao"},"change_message_id":"95477b18438ea794e5c47da03475024041641bf1","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        return self._return_connection_data(nodename, volume)"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def ensure_export(self, context, volume):"},{"line_number":948,"context_line":"        p_location \u003d volume[\u0027provider_location\u0027]"},{"line_number":949,"context_line":"        if p_location:"},{"line_number":950,"context_line":"            fields \u003d p_location.split(\" \")"},{"line_number":951,"context_line":"            nodename \u003d fields[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_58ce4c84","line":948,"updated":"2016-05-27 09:18:16.000000000","message":"If volume has no key \"provider_location\",it will raise exception.","commit_id":"8cb8cf5f906dd8e3b0ed76f815a57f7e092d45b7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7c182426acc47da59b105abee9e3fe8487a7ab44","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        return self._return_connection_data(nodename, volume)"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def ensure_export(self, context, volume):"},{"line_number":948,"context_line":"        p_location \u003d volume[\u0027provider_location\u0027]"},{"line_number":949,"context_line":"        if p_location:"},{"line_number":950,"context_line":"            fields \u003d p_location.split(\" \")"},{"line_number":951,"context_line":"            nodename \u003d fields[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_78363c53","line":948,"in_reply_to":"7aa08908_78a63c11","updated":"2016-06-07 14:02:31.000000000","message":"volume will always contain this field when calling this method, this isn\u0027t something we need to check for.","commit_id":"8cb8cf5f906dd8e3b0ed76f815a57f7e092d45b7"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"08e4e3b4eb50c4f20be50b15f0f9fb007c402fbd","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        return self._return_connection_data(nodename, volume)"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def ensure_export(self, context, volume):"},{"line_number":948,"context_line":"        p_location \u003d volume[\u0027provider_location\u0027]"},{"line_number":949,"context_line":"        if p_location:"},{"line_number":950,"context_line":"            fields \u003d p_location.split(\" \")"},{"line_number":951,"context_line":"            nodename \u003d fields[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_82731f4d","line":948,"in_reply_to":"9abb7d3a_58ce4c84","updated":"2016-05-27 11:26:38.000000000","message":"Yeah, right.\nBut it contains this key, with value \"None\".\n\nLots of other drivers do it the same way:\n  $ grep \u0027\\[.provider_location.]\u0027 -r cinder/volume/ | wc -l\n  230","commit_id":"8cb8cf5f906dd8e3b0ed76f815a57f7e092d45b7"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d31b44081a5dde2deb1b1e4bc6fb3822956ecb18","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        return self._return_connection_data(nodename, volume)"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"    def ensure_export(self, context, volume):"},{"line_number":948,"context_line":"        p_location \u003d volume[\u0027provider_location\u0027]"},{"line_number":949,"context_line":"        if p_location:"},{"line_number":950,"context_line":"            fields \u003d p_location.split(\" \")"},{"line_number":951,"context_line":"            nodename \u003d fields[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_78a63c11","line":948,"in_reply_to":"9abb7d3a_82731f4d","updated":"2016-06-07 13:56:39.000000000","message":"You\u0027re probably perfectly safe the way it is, but the if/else you added makes it stick out.  \n\nYou could just change it to a volume.get(\u0027provider_location\u0027, None) to be clear and safe.","commit_id":"8cb8cf5f906dd8e3b0ed76f815a57f7e092d45b7"}]}