)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"b8a6102f5b87e7aef3c06569d0978cad740938d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sheel Rana \u003cranasheel2000@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-25 07:45:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u0027display-name\u0027 is not used in snapshot_manage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently snapshot-manage operation uses name in request"},{"line_number":10,"context_line":"body."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_34b808c8","line":7,"updated":"2016-07-06 17:03:50.000000000","message":"If the request body does have \u0027display_name\u0027 in it rather that \u0027name\u0027, this changes would end up importing a snapshot without name?","commit_id":"c7259c1792e4b9547cfa31ab69acb70b2ee4abf9"}],"cinder/api/contrib/snapshot_manage.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"8ec1ae1aedee0c55e05c6fe970dbd987d15a4ed4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        snapshot_parameters[\u0027metadata\u0027] \u003d snapshot.get(\u0027metadata\u0027, None)"},{"line_number":115,"context_line":"        snapshot_parameters[\u0027description\u0027] \u003d snapshot.get(\u0027description\u0027, None)"},{"line_number":116,"context_line":"        # NOTE(wanghao) if name in request body, we are overriding the \u0027name\u0027"},{"line_number":117,"context_line":"        snapshot_parameters[\u0027name\u0027] \u003d snapshot.get(\u0027name\u0027,"},{"line_number":118,"context_line":"                                                   snapshot.get(\u0027display_name\u0027)"},{"line_number":119,"context_line":"                                                   )"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            new_snapshot \u003d self.volume_api.manage_existing_snapshot("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_ee34514b","side":"PARENT","line":119,"range":{"start_line":117,"start_character":0,"end_line":119,"end_character":52},"updated":"2016-05-25 07:23:30.000000000","message":"Emm, I think we should remove display_name here, not name, since v2 api we can use \u0027name\u0027 instead of \u0027display_name\u0027 in request body. So I feel manage_snapshot just use \u0027name\u0027 is fine.","commit_id":"a17d3e2961db0b40cb4c13d11d0e74ea27939dc6"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"a4ee769bfab7236981a2c41ea8c7bae298634f55","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        snapshot_parameters[\u0027metadata\u0027] \u003d snapshot.get(\u0027metadata\u0027, None)"},{"line_number":115,"context_line":"        snapshot_parameters[\u0027description\u0027] \u003d snapshot.get(\u0027description\u0027, None)"},{"line_number":116,"context_line":"        # NOTE(wanghao) if name in request body, we are overriding the \u0027name\u0027"},{"line_number":117,"context_line":"        snapshot_parameters[\u0027name\u0027] \u003d snapshot.get(\u0027name\u0027,"},{"line_number":118,"context_line":"                                                   snapshot.get(\u0027display_name\u0027)"},{"line_number":119,"context_line":"                                                   )"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            new_snapshot \u003d self.volume_api.manage_existing_snapshot("}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_89077fc8","side":"PARENT","line":119,"range":{"start_line":117,"start_character":0,"end_line":119,"end_character":52},"in_reply_to":"bab6814e_ee34514b","updated":"2016-05-25 07:45:34.000000000","message":"yep, I mistakenly mapped it with volume than snapshot..\nThis implementation difference in volume(display-name) and snapshot(name) is strage..\nThanks for pointing","commit_id":"a17d3e2961db0b40cb4c13d11d0e74ea27939dc6"}]}