)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":21970,"name":"Andras Kovi","email":"akovi@nokia.com","username":"andras.kovi"},"change_message_id":"635122f99e7cb412de70d6c02ca44bf27edd0af0","unresolved":false,"context_lines":[{"line_number":965,"context_line":"                raise exception.InvalidVolume("},{"line_number":966,"context_line":"                    reason\u003d_(\"volume is already attached\"))"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"            attachment \u003d None"},{"line_number":969,"context_line":"            host_name_sanitized \u003d utils.sanitize_hostname("},{"line_number":970,"context_line":"                host_name) if host_name else None"},{"line_number":971,"context_line":"            if instance_uuid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c7e5aea4","line":968,"updated":"2016-05-26 08:47:50.000000000","message":"Do you need the attachment variable at all? It seems so that line #982 could be rewritten like\n\nif attachments:\n  self......","commit_id":"d58f1f64305eecaea649944241c7fa5c0800fc70"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d1eb922cbff9ce9905b89c116ade16bc577a5ad3","unresolved":false,"context_lines":[{"line_number":973,"context_line":"                    self.db.volume_attachment_get_by_instance_uuid("},{"line_number":974,"context_line":"                        context, volume_id, instance_uuid)"},{"line_number":975,"context_line":"                if attachments:"},{"line_number":976,"context_line":"                    attachment \u003d attachments[0]"},{"line_number":977,"context_line":"            else:"},{"line_number":978,"context_line":"                attachments \u003d \\"},{"line_number":979,"context_line":"                    self.db.volume_attachment_get_by_host(context, volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_21e2aa2f","line":976,"range":{"start_line":976,"start_character":33,"end_line":976,"end_character":47},"updated":"2016-05-26 07:51:14.000000000","message":"Is attachment here is used only for determining whether the volume status needs to be updated to in-use?\n\nAs if yes I don\u0027t see why we need to get the first item from this list here.","commit_id":"d58f1f64305eecaea649944241c7fa5c0800fc70"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"834aeb5c3cbd32d7f8bef0dfeda3b22b1cac7892","unresolved":false,"context_lines":[{"line_number":973,"context_line":"                    self.db.volume_attachment_get_by_instance_uuid("},{"line_number":974,"context_line":"                        context, volume_id, instance_uuid)"},{"line_number":975,"context_line":"                if attachments:"},{"line_number":976,"context_line":"                    attachment \u003d attachments[0]"},{"line_number":977,"context_line":"            else:"},{"line_number":978,"context_line":"                attachments \u003d \\"},{"line_number":979,"context_line":"                    self.db.volume_attachment_get_by_host(context, volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_629e3f64","line":976,"range":{"start_line":976,"start_character":33,"end_line":976,"end_character":47},"in_reply_to":"bab6814e_21e2aa2f","updated":"2016-05-27 02:26:25.000000000","message":"I agree with Ildiko Vancsa.","commit_id":"d58f1f64305eecaea649944241c7fa5c0800fc70"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d1eb922cbff9ce9905b89c116ade16bc577a5ad3","unresolved":false,"context_lines":[{"line_number":979,"context_line":"                    self.db.volume_attachment_get_by_host(context, volume_id,"},{"line_number":980,"context_line":"                                                          host_name_sanitized)"},{"line_number":981,"context_line":"                if attachments:"},{"line_number":982,"context_line":"                    attachment \u003d attachments[0]"},{"line_number":983,"context_line":"            if attachment is not None:"},{"line_number":984,"context_line":"                self.db.volume_update(context, volume_id,"},{"line_number":985,"context_line":"                                      {\u0027status\u0027: \u0027in-use\u0027})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_a1ccdabb","line":982,"range":{"start_line":982,"start_character":33,"end_line":982,"end_character":47},"updated":"2016-05-26 07:51:14.000000000","message":"Same as above.","commit_id":"d58f1f64305eecaea649944241c7fa5c0800fc70"},{"author":{"_account_id":12732,"name":"Bin Zhou","email":"zhou.bin9@zte.com.cn","username":"BinZhou"},"change_message_id":"17168c0122db6ab83016005aa7676a27db24c166","unresolved":false,"context_lines":[{"line_number":990,"context_line":"            values \u003d {\u0027volume_id\u0027: volume_id,"},{"line_number":991,"context_line":"                      \u0027attach_status\u0027: \u0027attaching\u0027, }"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"            attachment \u003d self.db.volume_attach(context.elevated(), values)"},{"line_number":994,"context_line":"            volume_metadata \u003d self.db.volume_admin_metadata_update("},{"line_number":995,"context_line":"                context.elevated(), volume_id,"},{"line_number":996,"context_line":"                {\"attached_mode\": mode}, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_1cb1c101","line":993,"range":{"start_line":993,"start_character":12,"end_line":993,"end_character":22},"updated":"2016-05-26 11:20:50.000000000","message":"The attachment is rewrite here, it\u0027s no need to get this variable from the list.","commit_id":"d58f1f64305eecaea649944241c7fa5c0800fc70"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"fc553d1ba5f1e220ac0c46dbc45a6a859145cf24","unresolved":false,"context_lines":[{"line_number":990,"context_line":"            values \u003d {\u0027volume_id\u0027: volume_id,"},{"line_number":991,"context_line":"                      \u0027attach_status\u0027: \u0027attaching\u0027, }"},{"line_number":992,"context_line":""},{"line_number":993,"context_line":"            attachment \u003d self.db.volume_attach(context.elevated(), values)"},{"line_number":994,"context_line":"            volume_metadata \u003d self.db.volume_admin_metadata_update("},{"line_number":995,"context_line":"                context.elevated(), volume_id,"},{"line_number":996,"context_line":"                {\"attached_mode\": mode}, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c6311f0d","line":993,"range":{"start_line":993,"start_character":12,"end_line":993,"end_character":22},"in_reply_to":"bab6814e_1cb1c101","updated":"2016-05-26 14:00:10.000000000","message":"Ahhh... yes!  Thank you, and that was what I was using as IIldiko\u0027s update.. and explains the overwrite of the host name in some other patches.  I\u0027ll get these fixed up, thanks!!","commit_id":"d58f1f64305eecaea649944241c7fa5c0800fc70"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8d488629f44aac5c7e877dab33cc49d8612d3be2","unresolved":false,"context_lines":[{"line_number":965,"context_line":"                raise exception.InvalidVolume("},{"line_number":966,"context_line":"                    reason\u003d_(\"volume is already attached\"))"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"            attachment \u003d None"},{"line_number":969,"context_line":"            host_name_sanitized \u003d utils.sanitize_hostname("},{"line_number":970,"context_line":"                host_name) if host_name else None"},{"line_number":971,"context_line":"            if instance_uuid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_fb85e3ce","line":968,"range":{"start_line":968,"start_character":12,"end_line":968,"end_character":29},"updated":"2016-05-31 17:02:27.000000000","message":"-1: This is no longer necessary, so I think it should be removed in this patch.","commit_id":"40b80e6e182772f2e172d24ce087c54613a055d0"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"26daeaf238eea09165bfb707d8fcdd6263f809d7","unresolved":false,"context_lines":[{"line_number":965,"context_line":"                raise exception.InvalidVolume("},{"line_number":966,"context_line":"                    reason\u003d_(\"volume is already attached\"))"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"            attachment \u003d None"},{"line_number":969,"context_line":"            host_name_sanitized \u003d utils.sanitize_hostname("},{"line_number":970,"context_line":"                host_name) if host_name else None"},{"line_number":971,"context_line":"            if instance_uuid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_5eccdd69","line":968,"range":{"start_line":968,"start_character":12,"end_line":968,"end_character":29},"in_reply_to":"9abb7d3a_9e492563","updated":"2016-05-31 17:11:34.000000000","message":"Or just remove it, the scoping of the if/else will cover the declaration of the variable here.","commit_id":"40b80e6e182772f2e172d24ce087c54613a055d0"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"afe71235c285d3538a9f7c58f0234823cda08525","unresolved":false,"context_lines":[{"line_number":965,"context_line":"                raise exception.InvalidVolume("},{"line_number":966,"context_line":"                    reason\u003d_(\"volume is already attached\"))"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"            attachment \u003d None"},{"line_number":969,"context_line":"            host_name_sanitized \u003d utils.sanitize_hostname("},{"line_number":970,"context_line":"                host_name) if host_name else None"},{"line_number":971,"context_line":"            if instance_uuid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_9e492563","line":968,"range":{"start_line":968,"start_character":12,"end_line":968,"end_character":29},"in_reply_to":"9abb7d3a_fb85e3ce","updated":"2016-05-31 17:03:31.000000000","message":"It should get replaced with attachments \u003d None","commit_id":"40b80e6e182772f2e172d24ce087c54613a055d0"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"26daeaf238eea09165bfb707d8fcdd6263f809d7","unresolved":false,"context_lines":[{"line_number":965,"context_line":"                raise exception.InvalidVolume("},{"line_number":966,"context_line":"                    reason\u003d_(\"volume is already attached\"))"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"            attachment \u003d None"},{"line_number":969,"context_line":"            host_name_sanitized \u003d utils.sanitize_hostname("},{"line_number":970,"context_line":"                host_name) if host_name else None"},{"line_number":971,"context_line":"            if instance_uuid:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_5ea5fd9f","line":968,"range":{"start_line":968,"start_character":12,"end_line":968,"end_character":29},"in_reply_to":"9abb7d3a_fb85e3ce","updated":"2016-05-31 17:11:34.000000000","message":"Yep, you\u0027re right... thanks!","commit_id":"40b80e6e182772f2e172d24ce087c54613a055d0"}]}