)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19153,"name":"jingtao liang","email":"liang.jingtao@zte.com.cn","username":"liangjingtao"},"change_message_id":"7f832458cd0b74fe2c64918c918fd3ba3659f4b5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-05-27 15:12:11 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp: Log unexpected errors from backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I13d8366355eaa07d338a95e2765fbe9eae6ddd2d"},{"line_number":10,"context_line":"Closes-Bug: 1583615"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_d9469abe","line":8,"updated":"2016-05-28 03:02:43.000000000","message":"And may be some detailed description to show why it shoud log will be better here,tks","commit_id":"784a07b5e44c63bd85102e79ab8f137dd4e69aba"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6e30d03a773b0c6378b9648f2f132bdd9d71da24","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-05-27 15:12:11 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp: Log unexpected errors from backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I13d8366355eaa07d338a95e2765fbe9eae6ddd2d"},{"line_number":10,"context_line":"Closes-Bug: 1583615"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_79778d3a","line":8,"in_reply_to":"9abb7d3a_d9469abe","updated":"2016-05-30 10:07:32.000000000","message":"nit: I agree, this would benefit from a small detailed description.","commit_id":"784a07b5e44c63bd85102e79ab8f137dd4e69aba"}],"cinder/volume/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6e30d03a773b0c6378b9648f2f132bdd9d71da24","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        except urllib.error.HTTPError as e:"},{"line_number":225,"context_line":"            raise NaApiError(e.code, e.msg)"},{"line_number":226,"context_line":"        except Exception:"},{"line_number":227,"context_line":"            LOG.exception(_LE(\"Error communicating with NetApp filer.\"))"},{"line_number":228,"context_line":"            raise NaApiError(\u0027Unexpected error\u0027)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        response_xml \u003d response.read()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_d9b799f3","line":227,"range":{"start_line":227,"start_character":63,"end_line":227,"end_character":68},"updated":"2016-05-30 10:07:32.000000000","message":"?: Wouldn\u0027t it be better to say API here?","commit_id":"784a07b5e44c63bd85102e79ab8f137dd4e69aba"},{"author":{"_account_id":19153,"name":"jingtao liang","email":"liang.jingtao@zte.com.cn","username":"liangjingtao"},"change_message_id":"da204996cee1ac9f4d1c86a5bcb4701f02a61550","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        except urllib.error.HTTPError as e:"},{"line_number":225,"context_line":"            raise NaApiError(e.code, e.msg)"},{"line_number":226,"context_line":"        except Exception:"},{"line_number":227,"context_line":"            LOG.exception(_LE(\"Error communicating with NetApp filer.\"))"},{"line_number":228,"context_line":"            raise NaApiError(\u0027Unexpected error\u0027)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        response_xml \u003d response.read()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_19302256","line":227,"updated":"2016-05-28 03:00:44.000000000","message":"I don\u0027t think it need to log again,because when meet exception,it will raise and also log.","commit_id":"784a07b5e44c63bd85102e79ab8f137dd4e69aba"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8d9366b5e811aa09039694988ce363f5af12cd2","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        except urllib.error.HTTPError as e:"},{"line_number":225,"context_line":"            raise NaApiError(e.code, e.msg)"},{"line_number":226,"context_line":"        except Exception:"},{"line_number":227,"context_line":"            LOG.exception(_LE(\"Error communicating with NetApp filer.\"))"},{"line_number":228,"context_line":"            raise NaApiError(\u0027Unexpected error\u0027)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        response_xml \u003d response.read()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_a93a5e34","line":227,"in_reply_to":"9abb7d3a_19302256","updated":"2016-05-29 03:34:02.000000000","message":"not if you suppress it in the calling method without logging it..","commit_id":"784a07b5e44c63bd85102e79ab8f137dd4e69aba"}]}