)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"60295da59cfd673798e1c5171e3644cf3aad400c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yuyafei \u003cyu.yafei@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-31 03:56:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"EMC driver should get ceiling of volume size"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The function manage_existing_object_get_size returns the floor of"},{"line_number":10,"context_line":"volume size in emc driver.For example, if the volume is less than"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abb7d3a_28b8da29","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":21},"updated":"2016-05-31 11:16:33.000000000","message":"return","commit_id":"34b874c115238e37860a855e02d66b3fbddec6a2"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"60295da59cfd673798e1c5171e3644cf3aad400c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The function manage_existing_object_get_size returns the floor of"},{"line_number":10,"context_line":"volume size in emc driver.For example, if the volume is less than"},{"line_number":11,"context_line":"1024MB, the return size would be 0G. So I think it should return"},{"line_number":12,"context_line":"the ceiling of volume size, just like LVM driver."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id3a1aa4ecfdfff6c36114c93c75b33872a5645ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9abb7d3a_68eb0214","line":11,"range":{"start_line":11,"start_character":37,"end_line":11,"end_character":64},"updated":"2016-05-31 11:16:33.000000000","message":"This patch fixes it by returning","commit_id":"34b874c115238e37860a855e02d66b3fbddec6a2"}],"cinder/tests/unit/test_emc_vmax.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1db98e24b1023c6e90b37c4c4f1f666ec7079d80","unresolved":false,"context_lines":[{"line_number":4918,"context_line":"        size \u003d self.driver.manage_existing_get_size(volume, external_ref)"},{"line_number":4919,"context_line":"        self.assertEqual(gbSize, size)"},{"line_number":4920,"context_line":""},{"line_number":4921,"context_line":"    def test_manage_existing_get_non_integer_size(self):"},{"line_number":4922,"context_line":"        volume \u003d {}"},{"line_number":4923,"context_line":"        metadata \u003d {\u0027key\u0027: \u0027array\u0027,"},{"line_number":4924,"context_line":"                    \u0027value\u0027: \u002712345\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_c9c9907a","line":4921,"updated":"2016-05-30 08:13:20.000000000","message":"This is similar to test_manage_existing_get_size except the input and expected output. We can use ddt to have a single test for both cases.\n\nUse this decorator:\n\n@ddt.data((2, 2), (1.75, 2))\n\n def test_manage_existing_get_size(self, test_data):\n\n    (gb_size, exp_size) \u003d test_data","commit_id":"8eb610b34bc4d0dce5c93bd38f746dfd68389a31"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"7d8dbf3c807c89d0893e2367489d41483fb0e1a8","unresolved":false,"context_lines":[{"line_number":4918,"context_line":"        size \u003d self.driver.manage_existing_get_size(volume, external_ref)"},{"line_number":4919,"context_line":"        self.assertEqual(gbSize, size)"},{"line_number":4920,"context_line":""},{"line_number":4921,"context_line":"    def test_manage_existing_get_non_integer_size(self):"},{"line_number":4922,"context_line":"        volume \u003d {}"},{"line_number":4923,"context_line":"        metadata \u003d {\u0027key\u0027: \u0027array\u0027,"},{"line_number":4924,"context_line":"                    \u0027value\u0027: \u002712345\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_5e640b21","line":4921,"in_reply_to":"9abb7d3a_c9c9907a","updated":"2016-05-31 03:52:22.000000000","message":"Thank you for your advices and I fixed it.","commit_id":"8eb610b34bc4d0dce5c93bd38f746dfd68389a31"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"76c80f71a9945718cb8ff4e4ce39637a161fa6f1","unresolved":false,"context_lines":[{"line_number":4904,"context_line":""},{"line_number":4905,"context_line":"    @ddt.data((2, 2), (1.75, 2))"},{"line_number":4906,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":4907,"context_line":"        gb_size, exp_size \u003d test_data"},{"line_number":4908,"context_line":"        volume \u003d {}"},{"line_number":4909,"context_line":"        metadata \u003d {\u0027key\u0027: \u0027array\u0027,"},{"line_number":4910,"context_line":"                    \u0027value\u0027: \u002712345\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_8d4d6840","line":4907,"range":{"start_line":4907,"start_character":8,"end_line":4907,"end_character":37},"updated":"2016-06-08 10:14:59.000000000","message":"nit: I think @ddt.unpack is a cleaner way of doing this","commit_id":"f4cee9b646311b88e5e4b6bda7ff8774ef390aa0"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5a1a5295e94dea4bc89002b3b5e43683285adab6","unresolved":false,"context_lines":[{"line_number":4904,"context_line":""},{"line_number":4905,"context_line":"    @ddt.data((2, 2), (1.75, 2))"},{"line_number":4906,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":4907,"context_line":"        gb_size, exp_size \u003d test_data"},{"line_number":4908,"context_line":"        volume \u003d {}"},{"line_number":4909,"context_line":"        metadata \u003d {\u0027key\u0027: \u0027array\u0027,"},{"line_number":4910,"context_line":"                    \u0027value\u0027: \u002712345\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_e9b5877e","line":4907,"range":{"start_line":4907,"start_character":8,"end_line":4907,"end_character":37},"in_reply_to":"7aa08908_8d4d6840","updated":"2016-06-10 02:34:36.000000000","message":"Can you make this change suggested by Gorka?  Thanks.","commit_id":"f4cee9b646311b88e5e4b6bda7ff8774ef390aa0"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"8a9387c6741bcf301a45723c51845dd60a664c40","unresolved":false,"context_lines":[{"line_number":4904,"context_line":""},{"line_number":4905,"context_line":"    @ddt.data((2, 2), (1.75, 2))"},{"line_number":4906,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":4907,"context_line":"        gb_size, exp_size \u003d test_data"},{"line_number":4908,"context_line":"        volume \u003d {}"},{"line_number":4909,"context_line":"        metadata \u003d {\u0027key\u0027: \u0027array\u0027,"},{"line_number":4910,"context_line":"                    \u0027value\u0027: \u002712345\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_eff46788","line":4907,"range":{"start_line":4907,"start_character":8,"end_line":4907,"end_character":37},"in_reply_to":"7aa08908_8d4d6840","updated":"2016-06-10 03:55:07.000000000","message":"Thank you and I fixed it.","commit_id":"f4cee9b646311b88e5e4b6bda7ff8774ef390aa0"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"8a9387c6741bcf301a45723c51845dd60a664c40","unresolved":false,"context_lines":[{"line_number":4904,"context_line":""},{"line_number":4905,"context_line":"    @ddt.data((2, 2), (1.75, 2))"},{"line_number":4906,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":4907,"context_line":"        gb_size, exp_size \u003d test_data"},{"line_number":4908,"context_line":"        volume \u003d {}"},{"line_number":4909,"context_line":"        metadata \u003d {\u0027key\u0027: \u0027array\u0027,"},{"line_number":4910,"context_line":"                    \u0027value\u0027: \u002712345\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_4ff2db9b","line":4907,"range":{"start_line":4907,"start_character":8,"end_line":4907,"end_character":37},"in_reply_to":"7aa08908_e9b5877e","updated":"2016-06-10 03:55:07.000000000","message":"Thank you and I fixed it.","commit_id":"f4cee9b646311b88e5e4b6bda7ff8774ef390aa0"}]}