)]}'
{"cinder/tests/unit/test_volume_transfer.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"caec8c64eaedc02df96e9e1bde49ca2f8c367d78","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # QUOTAS.limit_check"},{"line_number":186,"context_line":"        values \u003d {\u0027per_volume_gigabytes\u0027: 1}"},{"line_number":187,"context_line":"        mock_quota_limit.assert_called_with(self.ctxt,"},{"line_number":188,"context_line":"                                            project_id\u003dfake.PROJECT2_ID,"},{"line_number":189,"context_line":"                                            **values)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_44394cd8","line":187,"range":{"start_line":187,"start_character":25,"end_line":187,"end_character":43},"updated":"2016-06-02 09:46:45.000000000","message":"assert_called_once_with","commit_id":"0bdf725ed6534cebc929dea3273d23c255da1a7f"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"0d4e02610fc29a30022393433d7a2e6d82d2d2a5","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        # QUOTAS.limit_check"},{"line_number":186,"context_line":"        values \u003d {\u0027per_volume_gigabytes\u0027: 1}"},{"line_number":187,"context_line":"        mock_quota_limit.assert_called_with(self.ctxt,"},{"line_number":188,"context_line":"                                            project_id\u003dfake.PROJECT2_ID,"},{"line_number":189,"context_line":"                                            **values)"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_c761b9aa","line":187,"range":{"start_line":187,"start_character":25,"end_line":187,"end_character":43},"in_reply_to":"9abb7d3a_44394cd8","updated":"2016-06-02 11:27:35.000000000","message":"Nice suggestion.","commit_id":"0bdf725ed6534cebc929dea3273d23c255da1a7f"}],"cinder/transfer/api.py":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"cac32a41c7f75b568d9774863ccd65dc57de31b2","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            LOG.error(msg)"},{"line_number":169,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        volume_utils.notify_about_volume_usage(context, vol_ref,"},{"line_number":172,"context_line":"                                               \"transfer.accept.start\")"},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            values \u003d {\u0027per_volume_gigabytes\u0027: vol_ref.size}"},{"line_number":175,"context_line":"            QUOTAS.limit_check(context, project_id\u003dcontext.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_a30564c3","line":172,"range":{"start_line":171,"start_character":0,"end_line":172,"end_character":71},"updated":"2016-05-28 08:10:33.000000000","message":"We are notifying for volume usage at the time of volume transfer start but this is not reverted in case of any failure..\n\nFor ex, in case per_volume_gigabytes check fails, we will just return and nothing will happen for notfication related to transfer.accept.end..\n\nThough this is not related to your code changes but I think we have opportunity to udpate notifications as well *if required* .(need to discuss for this further)","commit_id":"9442886732b82b7edb9c2ed01b6b92c704d21975"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"ec1274a76b3d31abbee3a610c99cfdda625b8c05","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            LOG.error(msg)"},{"line_number":169,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        volume_utils.notify_about_volume_usage(context, vol_ref,"},{"line_number":172,"context_line":"                                               \"transfer.accept.start\")"},{"line_number":173,"context_line":"        try:"},{"line_number":174,"context_line":"            values \u003d {\u0027per_volume_gigabytes\u0027: vol_ref.size}"},{"line_number":175,"context_line":"            QUOTAS.limit_check(context, project_id\u003dcontext.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_561c2213","line":172,"range":{"start_line":171,"start_character":0,"end_line":172,"end_character":71},"in_reply_to":"9abb7d3a_a30564c3","updated":"2016-05-30 03:50:22.000000000","message":"Done","commit_id":"9442886732b82b7edb9c2ed01b6b92c704d21975"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"a220a2c26acfe14e5f437007f48b274817c2bfda","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            LOG.error(msg)"},{"line_number":170,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        try:"},{"line_number":173,"context_line":"            values \u003d {\u0027per_volume_gigabytes\u0027: vol_ref.size}"},{"line_number":174,"context_line":"            QUOTAS.limit_check(context, project_id\u003dcontext.project_id,"},{"line_number":175,"context_line":"                               **values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_d63f48d4","line":172,"range":{"start_line":172,"start_character":7,"end_line":172,"end_character":12},"updated":"2016-08-27 19:37:12.000000000","message":"Each of the try/except blocks dealing with QUOTAS should be moved to a new method that deals with QUOTA checks. This will help by reducing the lines of code in the accept method and make testing easier.","commit_id":"18dd59018e662a8bad0dd8e2a2ad4af8d2809c66"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"ff5e9647334cadcefdbf4138cc84f08f9bea57e4","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        try:"},{"line_number":173,"context_line":"            values \u003d {\u0027per_volume_gigabytes\u0027: vol_ref.size}"},{"line_number":174,"context_line":"            QUOTAS.limit_check(context, project_id\u003dcontext.project_id,"},{"line_number":175,"context_line":"                               **values)"},{"line_number":176,"context_line":"        except exception.OverQuota as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_a3544721","line":173,"range":{"start_line":173,"start_character":12,"end_line":173,"end_character":18},"updated":"2016-08-27 14:24:08.000000000","message":"why not use a more accurate name,like volume_size,etc","commit_id":"18dd59018e662a8bad0dd8e2a2ad4af8d2809c66"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"a220a2c26acfe14e5f437007f48b274817c2bfda","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            raise exception.VolumeSizeExceedsLimit("},{"line_number":179,"context_line":"                size\u003dvol_ref.size, limit\u003dquotas[\u0027per_volume_gigabytes\u0027])"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        try:"},{"line_number":182,"context_line":"            reserve_opts \u003d {\u0027volumes\u0027: 1, \u0027gigabytes\u0027: vol_ref.size}"},{"line_number":183,"context_line":"            QUOTAS.add_volume_type_opts(context,"},{"line_number":184,"context_line":"                                        reserve_opts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_f6260ccd","line":181,"range":{"start_line":181,"start_character":8,"end_line":181,"end_character":12},"updated":"2016-08-27 19:37:12.000000000","message":"Same as above","commit_id":"18dd59018e662a8bad0dd8e2a2ad4af8d2809c66"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"a220a2c26acfe14e5f437007f48b274817c2bfda","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            quota_utils.process_reserve_over_quota(context, e,"},{"line_number":189,"context_line":"                                                   resource\u003d\u0027volumes\u0027,"},{"line_number":190,"context_line":"                                                   size\u003dvol_ref.size)"},{"line_number":191,"context_line":"        try:"},{"line_number":192,"context_line":"            donor_id \u003d vol_ref[\u0027project_id\u0027]"},{"line_number":193,"context_line":"            reserve_opts \u003d {\u0027volumes\u0027: -1, \u0027gigabytes\u0027: -vol_ref.size}"},{"line_number":194,"context_line":"            QUOTAS.add_volume_type_opts(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_162290b9","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":12},"updated":"2016-08-27 19:37:12.000000000","message":"Same as above","commit_id":"18dd59018e662a8bad0dd8e2a2ad4af8d2809c66"}]}