)]}'
{"cinder/cmd/manage.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"776a7dc0cb47270d0e6ff881e93dc683df63e033","unresolved":false,"context_lines":[{"line_number":231,"context_line":"            print(_(\"Must supply a positive, non-zero value for age\"))"},{"line_number":232,"context_line":"            sys.exit(1)"},{"line_number":233,"context_line":"        if age_in_days \u003e\u003d (int(time.time()) / 86400):"},{"line_number":234,"context_line":"            print(_(\"Maximal age is count of days since epoch.\"))"},{"line_number":235,"context_line":"            sys.exit(1)"},{"line_number":236,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":237,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_c6927bf5","line":234,"range":{"start_line":234,"start_character":21,"end_line":234,"end_character":28},"updated":"2016-06-01 21:59:08.000000000","message":"Maximum","commit_id":"d5481ba92312a4b2fff58df2e2cc2ab75cc580d6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"53f1740817befd98d0fbc02245b792c0f26beb09","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        \"\"\"Purge deleted rows older than a given age from cinder tables.\"\"\""},{"line_number":229,"context_line":"        age_in_days \u003d int(age_in_days)"},{"line_number":230,"context_line":"        if age_in_days \u003c\u003d 0:"},{"line_number":231,"context_line":"            print(_(\"Must supply a positive, non-zero value for age\"))"},{"line_number":232,"context_line":"            sys.exit(1)"},{"line_number":233,"context_line":"        if age_in_days \u003e\u003d (int(time.time()) / 86400):"},{"line_number":234,"context_line":"            print(_(\"Maximum age is count of days since epoch.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_8dab46d6","line":231,"updated":"2016-06-02 14:37:11.000000000","message":"My bad, didn\u0027t notice this before.","commit_id":"25f5eed56faa81969a0e0cd6a732f789deaddb0c"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"776a7dc0cb47270d0e6ff881e93dc683df63e033","unresolved":false,"context_lines":[{"line_number":4231,"context_line":"        msg \u003d _(\u0027Invalid value for age, %(age)s\u0027) % {\u0027age\u0027: age_in_days}"},{"line_number":4232,"context_line":"        LOG.exception(msg)"},{"line_number":4233,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":4234,"context_line":"    if age_in_days \u003c\u003d 0:"},{"line_number":4235,"context_line":"        msg \u003d _(\u0027Must supply a positive value for age\u0027)"},{"line_number":4236,"context_line":"        LOG.error(msg)"},{"line_number":4237,"context_line":"        raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_46b5eb7b","side":"PARENT","line":4234,"updated":"2016-06-01 21:59:08.000000000","message":"Why are we removing this check.  Seems like it is still valid.  If it is because the new code will catch values less than 0 then we need to update the error message to indicate that it also needs to be greater than zero.","commit_id":"9a0bd4f17270828742f4682a28fe17bbf3ec983a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"338a5e265c5137d4814059df7c52941998e73058","unresolved":false,"context_lines":[{"line_number":4231,"context_line":"        msg \u003d _(\u0027Invalid value for age, %(age)s\u0027) % {\u0027age\u0027: age_in_days}"},{"line_number":4232,"context_line":"        LOG.exception(msg)"},{"line_number":4233,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":4234,"context_line":"    if age_in_days \u003c\u003d 0:"},{"line_number":4235,"context_line":"        msg \u003d _(\u0027Must supply a positive value for age\u0027)"},{"line_number":4236,"context_line":"        LOG.error(msg)"},{"line_number":4237,"context_line":"        raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_49dcc574","side":"PARENT","line":4234,"in_reply_to":"9abb7d3a_46b5eb7b","updated":"2016-06-02 09:31:57.000000000","message":"+1\n\nWe need to fix the error message in cinder.cmd.manage if we remove this check.\n\nBtw, there is nothing wrong keeping this validation even if it is done at a higher layer.","commit_id":"9a0bd4f17270828742f4682a28fe17bbf3ec983a"},{"author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"change_message_id":"1ea3b7199a0fdee84761633b10483a98102dc40f","unresolved":false,"context_lines":[{"line_number":4231,"context_line":"        msg \u003d _(\u0027Invalid value for age, %(age)s\u0027) % {\u0027age\u0027: age_in_days}"},{"line_number":4232,"context_line":"        LOG.exception(msg)"},{"line_number":4233,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":4234,"context_line":"    if age_in_days \u003c\u003d 0:"},{"line_number":4235,"context_line":"        msg \u003d _(\u0027Must supply a positive value for age\u0027)"},{"line_number":4236,"context_line":"        LOG.error(msg)"},{"line_number":4237,"context_line":"        raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_fb29fa38","side":"PARENT","line":4234,"in_reply_to":"9abb7d3a_49dcc574","updated":"2016-06-02 10:16:44.000000000","message":"Hi vipin, As we have already checked this condition at higher level (cinder.cmd.manage) so this line of code will never be executed so there is no use of keeping this duplicate validation here.\n\nJay/Vipin, Please let me know your opinion.","commit_id":"9a0bd4f17270828742f4682a28fe17bbf3ec983a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"27eb45f3c53e1c77bcc516afb6258c449cee23af","unresolved":false,"context_lines":[{"line_number":4231,"context_line":"        msg \u003d _(\u0027Invalid value for age, %(age)s\u0027) % {\u0027age\u0027: age_in_days}"},{"line_number":4232,"context_line":"        LOG.exception(msg)"},{"line_number":4233,"context_line":"        raise exception.InvalidParameterValue(msg)"},{"line_number":4234,"context_line":"    if age_in_days \u003c\u003d 0:"},{"line_number":4235,"context_line":"        msg \u003d _(\u0027Must supply a positive value for age\u0027)"},{"line_number":4236,"context_line":"        LOG.error(msg)"},{"line_number":4237,"context_line":"        raise exception.InvalidParameterValue(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_db2fd6a5","side":"PARENT","line":4234,"in_reply_to":"9abb7d3a_fb29fa38","updated":"2016-06-02 10:26:09.000000000","message":"Ok, but as Jay suggested update the error message in cinder.cmd.manage to cover negative values.","commit_id":"9a0bd4f17270828742f4682a28fe17bbf3ec983a"}]}