)]}'
{"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":19906,"name":"Erez A. Korn","email":"ek844y@att.com","username":"erez"},"change_message_id":"7cba4d1a7d3260fcb7e2151c9ceb7352587bc536","unresolved":false,"context_lines":[{"line_number":2278,"context_line":"        result \u003d db.driver_initiator_data_insert_by_key("},{"line_number":2279,"context_line":"            self.ctxt, self.initiator, self.namespace, key, value)"},{"line_number":2280,"context_line":"        self.assertEqual(expected_result, result)"},{"line_number":2281,"context_line":""},{"line_number":2282,"context_line":"        data \u003d db.driver_initiator_data_get(self.ctxt, self.initiator,"},{"line_number":2283,"context_line":"                                            self.namespace)"},{"line_number":2284,"context_line":"        self.assertEqual(data[0].key, key)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_bfd81154","line":2281,"updated":"2016-06-02 02:19:48.000000000","message":"Do you feel removing values test is no longer required with this approach?","commit_id":"eca360a171ec5b161b9b8394bd7767b97e02807f"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"5120ff916d0397f76bc79284c9eb20a707b47080","unresolved":false,"context_lines":[{"line_number":2278,"context_line":"        result \u003d db.driver_initiator_data_insert_by_key("},{"line_number":2279,"context_line":"            self.ctxt, self.initiator, self.namespace, key, value)"},{"line_number":2280,"context_line":"        self.assertEqual(expected_result, result)"},{"line_number":2281,"context_line":""},{"line_number":2282,"context_line":"        data \u003d db.driver_initiator_data_get(self.ctxt, self.initiator,"},{"line_number":2283,"context_line":"                                            self.namespace)"},{"line_number":2284,"context_line":"        self.assertEqual(data[0].key, key)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_1462bb16","line":2281,"in_reply_to":"9abb7d3a_bfd81154","updated":"2016-06-02 15:49:37.000000000","message":"Those api\u0027s are being removed as well, so no need to test them.","commit_id":"eca360a171ec5b161b9b8394bd7767b97e02807f"}],"cinder/volume/driver_utils.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"265053c62e030b557207b739ff92f07091e71e87","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                key,"},{"line_number":63,"context_line":"                value"},{"line_number":64,"context_line":"            )"},{"line_number":65,"context_line":"        except exception.CinderException:"},{"line_number":66,"context_line":"            LOG.exception(_LE(\"Failed to update initiator data for\""},{"line_number":67,"context_line":"                              \" initiator %(initiator)s and backend\""},{"line_number":68,"context_line":"                              \" %(backend)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_685ebe77","line":65,"updated":"2016-06-02 20:00:37.000000000","message":"It seems like we should now update this exception message to include the key/value that we were attempting to update.  It would narrow down problems if they occur.","commit_id":"8bd94bc915e4fdb15b36fceac5d678e259dba3d8"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9c9e3fdcea43fd1777616d466844b901418795cb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                key,"},{"line_number":63,"context_line":"                value"},{"line_number":64,"context_line":"            )"},{"line_number":65,"context_line":"        except exception.CinderException:"},{"line_number":66,"context_line":"            LOG.exception(_LE(\"Failed to update initiator data for\""},{"line_number":67,"context_line":"                              \" initiator %(initiator)s and backend\""},{"line_number":68,"context_line":"                              \" %(backend)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_bba54e05","line":65,"in_reply_to":"9abb7d3a_2835d6f6","updated":"2016-06-03 18:08:28.000000000","message":"Latest version adds the key to the exception message, leaves out the value. Still open to other options though.","commit_id":"8bd94bc915e4fdb15b36fceac5d678e259dba3d8"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"9b8415669061a4e6df0f6a1ee64de02bc2e4ae85","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                key,"},{"line_number":63,"context_line":"                value"},{"line_number":64,"context_line":"            )"},{"line_number":65,"context_line":"        except exception.CinderException:"},{"line_number":66,"context_line":"            LOG.exception(_LE(\"Failed to update initiator data for\""},{"line_number":67,"context_line":"                              \" initiator %(initiator)s and backend\""},{"line_number":68,"context_line":"                              \" %(backend)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_2835d6f6","line":65,"in_reply_to":"9abb7d3a_685ebe77","updated":"2016-06-02 20:05:04.000000000","message":"Yea I thought about that, maybe adding the key would be better, but the values we may not want to log. The main use-case for this right now being CHAP credentials. Since we don\u0027t swallow the exception and drivers have a chance to catch it and can log their own error message I lean towards keeping this simple, or even removing this try/catch entirely. Thoughts?","commit_id":"8bd94bc915e4fdb15b36fceac5d678e259dba3d8"}]}