)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"f7f681db9d4c4253a2b833871f472cb24f0ae990","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Volume status must be available, and the format is:"},{"line_number":13,"context_line":"    extend \u003cvol-id\u003e \u003cnew-size\u003e"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\twhere new-size must be \u003e current size."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Adding support to drivers will be handled in follow up"},{"line_number":18,"context_line":"patches for each of the existing drivers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2Fx6c%3D","line":15,"updated":"2013-06-10 23:43:43.000000000","message":"Is the tab intentional?","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"}],"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2105dde250442cfc35c64dbe841da84e45bac7e6","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        \"\"\"Extend size of volume.\"\"\""},{"line_number":192,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":193,"context_line":"        volume \u003d self.volume_api.get(context, id)"},{"line_number":194,"context_line":"        size \u003d body[\u0027os-extend\u0027][\u0027new_size\u0027]"},{"line_number":195,"context_line":"        self.volume_api.extend(context, volume, size)"},{"line_number":196,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FpGw%3D","line":194,"updated":"2013-06-13 16:52:09.000000000","message":"Does it make sense to do some validation on the size string?  To make sure its an number?","commit_id":"2d8d50c2efc980b77a1bb359ef8506430587fd82"}],"cinder/tests/test_volume.py":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"f7f681db9d4c4253a2b833871f472cb24f0ae990","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        volume_api.extend(self.context, volume, 3)"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        volume \u003d db.volume_get(context.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":1205,"context_line":"        #self.assertEquals(volume[\u0027status\u0027], \u0027extending\u0027)"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"        # clean up"},{"line_number":1208,"context_line":"        self.volume.delete_volume(self.context, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fx6Q%3D","line":1205,"updated":"2013-06-10 23:43:43.000000000","message":"Why is this test commented?","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"bd04d71d7485758e098049a9c3b02c6fee9541a9","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"        volume_api.extend(self.context, volume, 3)"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        volume \u003d db.volume_get(context.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":1205,"context_line":"        #self.assertEquals(volume[\u0027status\u0027], \u0027extending\u0027)"},{"line_number":1206,"context_line":""},{"line_number":1207,"context_line":"        # clean up"},{"line_number":1208,"context_line":"        self.volume.delete_volume(self.context, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fvhg%3D","line":1205,"in_reply_to":"AAAAPX%2F%2Fx6Q%3D","updated":"2013-06-11 15:46:27.000000000","message":"Done","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2105dde250442cfc35c64dbe841da84e45bac7e6","unresolved":false,"context_lines":[{"line_number":1201,"context_line":"        # works when new_size \u003e orig_size"},{"line_number":1202,"context_line":"        volume_api.extend(self.context, volume, 3)"},{"line_number":1203,"context_line":""},{"line_number":1204,"context_line":"        volume \u003d db.volume_get(context.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":1205,"context_line":""},{"line_number":1206,"context_line":"        # clean up"},{"line_number":1207,"context_line":"        self.volume.delete_volume(self.context, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FpGg%3D","line":1204,"updated":"2013-06-13 16:52:09.000000000","message":"Can we test the size at this point?   It should be 3.","commit_id":"2d8d50c2efc980b77a1bb359ef8506430587fd82"}],"cinder/volume/api.py":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"f7f681db9d4c4253a2b833871f472cb24f0ae990","unresolved":false,"context_lines":[{"line_number":778,"context_line":"                return (usages[name][\u0027reserved\u0027] + usages[name][\u0027in_use\u0027])"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"            if \u0027gigabytes\u0027 in overs:"},{"line_number":781,"context_line":"                msg \u003d _(\"Quota exceeded for %(s_pid)s, tried to create \""},{"line_number":782,"context_line":"                        \"%(s_size)sG volume (%(d_consumed)dG of %(d_quota)dG \""},{"line_number":783,"context_line":"                        \"already consumed)\")"},{"line_number":784,"context_line":"                LOG.warn(msg % {\u0027s_pid\u0027: context.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fx5o%3D","line":781,"updated":"2013-06-10 23:43:43.000000000","message":"I feel the message should reflect the fact that an extension (and not a creation) was attempted.","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"bd04d71d7485758e098049a9c3b02c6fee9541a9","unresolved":false,"context_lines":[{"line_number":778,"context_line":"                return (usages[name][\u0027reserved\u0027] + usages[name][\u0027in_use\u0027])"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"            if \u0027gigabytes\u0027 in overs:"},{"line_number":781,"context_line":"                msg \u003d _(\"Quota exceeded for %(s_pid)s, tried to create \""},{"line_number":782,"context_line":"                        \"%(s_size)sG volume (%(d_consumed)dG of %(d_quota)dG \""},{"line_number":783,"context_line":"                        \"already consumed)\")"},{"line_number":784,"context_line":"                LOG.warn(msg % {\u0027s_pid\u0027: context.project_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FvfY%3D","line":781,"in_reply_to":"AAAAPX%2F%2Fx5o%3D","updated":"2013-06-11 15:46:27.000000000","message":"Done","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"}],"cinder/volume/driver.py":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"f7f681db9d4c4253a2b833871f472cb24f0ae990","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    def accept_transfer(self, volume):"},{"line_number":541,"context_line":"        pass"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":544,"context_line":"        msg \u003d _(\"Extend volume not implemented\")"},{"line_number":545,"context_line":"        raise NotImplementedError(msg)"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fx5E%3D","line":543,"updated":"2013-06-10 23:43:43.000000000","message":"Shouldn\u0027t this method be part of VolumeDriver instead? It isn\u0027t specific to ISCSIDriver.\n\nIt is also missing docstring.","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"bd04d71d7485758e098049a9c3b02c6fee9541a9","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    def accept_transfer(self, volume):"},{"line_number":541,"context_line":"        pass"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":544,"context_line":"        msg \u003d _(\"Extend volume not implemented\")"},{"line_number":545,"context_line":"        raise NotImplementedError(msg)"},{"line_number":546,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FvfE%3D","line":543,"in_reply_to":"AAAAPX%2F%2Fx5E%3D","updated":"2013-06-11 15:46:27.000000000","message":"Done","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"}],"cinder/volume/manager.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"0c917dbe3245cc8f36ec009da0f9d854c2e57bf8","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class VolumeManager(manager.SchedulerDependentManager):"},{"line_number":108,"context_line":"    \"\"\"Manages attachable block storage devices.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    RPC_API_VERSION \u003d \u00271.4\u0027"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def __init__(self, volume_driver\u003dNone, service_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fwr8%3D","line":109,"updated":"2013-06-11 06:54:07.000000000","message":"Update to 1.6?","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"bd04d71d7485758e098049a9c3b02c6fee9541a9","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class VolumeManager(manager.SchedulerDependentManager):"},{"line_number":108,"context_line":"    \"\"\"Manages attachable block storage devices.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    RPC_API_VERSION \u003d \u00271.4\u0027"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def __init__(self, volume_driver\u003dNone, service_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fve8%3D","line":109,"in_reply_to":"AAAAPX%2F%2Fwr8%3D","updated":"2013-06-11 15:46:27.000000000","message":"Done","commit_id":"43ecae187c702eb5c8539dbd53d73718b88f1020"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2105dde250442cfc35c64dbe841da84e45bac7e6","unresolved":false,"context_lines":[{"line_number":107,"context_line":"class VolumeManager(manager.SchedulerDependentManager):"},{"line_number":108,"context_line":"    \"\"\"Manages attachable block storage devices.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    RPC_API_VERSION \u003d \u00271.6\u0027"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def __init__(self, volume_driver\u003dNone, service_name\u003dNone,"},{"line_number":113,"context_line":"                 *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPX%2F%2FpGU%3D","line":110,"updated":"2013-06-13 16:52:09.000000000","message":"1.4 to 1.6 ?  not 1.5?","commit_id":"2d8d50c2efc980b77a1bb359ef8506430587fd82"}]}