)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"043d2761f6b36f6c1e74a4fb3e1ba056d9f12d25","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The function manage_existing_get_size returns size of volume to be"},{"line_number":10,"context_line":"managed by manage_existing and when calculating the size, rounds up to"},{"line_number":11,"context_line":"the next GB. But in the unittest case test_manage_existing_get_size,"},{"line_number":12,"context_line":"when calculating the size, gets the floor of volume size. This patch"},{"line_number":13,"context_line":"fixes it and adds a unittest case."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibcb7d96766bd8bfb2bf188267c52fce30cd80597"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_ddd517ba","line":12,"range":{"start_line":12,"start_character":27,"end_line":12,"end_character":41},"updated":"2016-06-04 06:54:14.000000000","message":"Not true for Python 3.0; it performs floating point division in 3.0.","commit_id":"196376a9594e632f37683d84fdcc9e53f24e39cc"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c1afcff365964d9d4c942fbc53a26e4c394e2c6a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"modifies the unittest case test_manage_existing_get_size."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibcb7d96766bd8bfb2bf188267c52fce30cd80597"},{"line_number":14,"context_line":"Closes-Bug: #1588592"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7aa08908_ad5280db","line":14,"updated":"2016-06-06 06:46:18.000000000","message":"The description in the bug is not matching, please fix it here:\nhttps://bugs.launchpad.net/cinder/+bug/1588592","commit_id":"4384f1477378d25112706922ac1aa8f3b31a5d6c"}],"cinder/tests/unit/test_tintri.py":[{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"7a8149b2a4e82434857830e2d2e2465b5ab8aa54","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                              self._driver.manage_existing,"},{"line_number":253,"context_line":"                              volume, existing)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @ddt.data((123 * units.Gi, 123.0), (int(123.5 * units.Gi), 124.0))"},{"line_number":256,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":257,"context_line":"        volume \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":258,"context_line":"        existing \u003d {\u0027source-name\u0027: self._provider_location + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_06529913","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":4},"updated":"2016-06-06 03:20:11.000000000","message":"It should be init type.","commit_id":"196376a9594e632f37683d84fdcc9e53f24e39cc"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"043d2761f6b36f6c1e74a4fb3e1ba056d9f12d25","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                              self._driver.manage_existing,"},{"line_number":253,"context_line":"                              volume, existing)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @ddt.data((123 * units.Gi, 123.0), (int(123.5 * units.Gi), 124.0))"},{"line_number":256,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":257,"context_line":"        volume \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":258,"context_line":"        existing \u003d {\u0027source-name\u0027: self._provider_location + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_3df89b7c","line":255,"range":{"start_line":255,"start_character":31,"end_line":255,"end_character":36},"updated":"2016-06-04 06:54:14.000000000","message":"Why this is float? Do we need to fix this in tintri.py?","commit_id":"196376a9594e632f37683d84fdcc9e53f24e39cc"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"c152e76ae045058b3e602c80884e56201b257d16","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                              self._driver.manage_existing,"},{"line_number":253,"context_line":"                              volume, existing)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @ddt.data((123 * units.Gi, 123.0), (int(123.5 * units.Gi), 124.0))"},{"line_number":256,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":257,"context_line":"        volume \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":258,"context_line":"        existing \u003d {\u0027source-name\u0027: self._provider_location + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_c65ff10c","line":255,"range":{"start_line":255,"start_character":0,"end_line":255,"end_character":4},"in_reply_to":"7aa08908_06529913","updated":"2016-06-06 03:23:59.000000000","message":"I agree with you and I fixed it.","commit_id":"196376a9594e632f37683d84fdcc9e53f24e39cc"},{"author":{"_account_id":20146,"name":"yuyafei","email":"yu.yafei@foxmail.com","username":"yuyafei"},"change_message_id":"c152e76ae045058b3e602c80884e56201b257d16","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                              self._driver.manage_existing,"},{"line_number":253,"context_line":"                              volume, existing)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @ddt.data((123 * units.Gi, 123.0), (int(123.5 * units.Gi), 124.0))"},{"line_number":256,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":257,"context_line":"        volume \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":258,"context_line":"        existing \u003d {\u0027source-name\u0027: self._provider_location + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8665e9e2","line":255,"range":{"start_line":255,"start_character":31,"end_line":255,"end_character":36},"in_reply_to":"7aa08908_3df89b7c","updated":"2016-06-06 03:23:59.000000000","message":"I agree with you and I fixed it.","commit_id":"196376a9594e632f37683d84fdcc9e53f24e39cc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"774687ede51929fcf4eb9289062094d6d63879e5","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                              self._driver.manage_existing,"},{"line_number":253,"context_line":"                              volume, existing)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    @ddt.data((123 * units.Gi, 123), (int(123.5 * units.Gi), 124))"},{"line_number":256,"context_line":"    def test_manage_existing_get_size(self, test_data):"},{"line_number":257,"context_line":"        volume \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":258,"context_line":"        existing \u003d {\u0027source-name\u0027: self._provider_location + \u0027/\u0027 +"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_8d6f282a","line":255,"range":{"start_line":255,"start_character":19,"end_line":255,"end_character":29},"updated":"2016-06-08 10:22:11.000000000","message":"nit: Maybe it would be a good idea to move this inside the test itself.","commit_id":"4384f1477378d25112706922ac1aa8f3b31a5d6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"774687ede51929fcf4eb9289062094d6d63879e5","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        volume \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":258,"context_line":"        existing \u003d {\u0027source-name\u0027: self._provider_location + \u0027/\u0027 +"},{"line_number":259,"context_line":"                    volume.name}"},{"line_number":260,"context_line":"        st_size, exp_size \u003d test_data"},{"line_number":261,"context_line":"        file \u003d mock.Mock(st_size\u003dst_size)"},{"line_number":262,"context_line":"        with mock.patch(\u0027os.path.isfile\u0027, return_value\u003dTrue):"},{"line_number":263,"context_line":"            with mock.patch(\u0027os.stat\u0027, return_value\u003dfile):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_0ddfb80d","line":260,"range":{"start_line":260,"start_character":8,"end_line":260,"end_character":37},"updated":"2016-06-08 10:22:11.000000000","message":"nit: I think it\u0027s better to use @ddt.unpack instead","commit_id":"4384f1477378d25112706922ac1aa8f3b31a5d6c"}],"cinder/volume/drivers/tintri.py":[{"author":{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},"change_message_id":"0e435f5bae86ff8ad3a27c062c838d5ccb9a9337","unresolved":false,"context_lines":[{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        try:"},{"line_number":735,"context_line":"            volume_path \u003d os.path.join(nfs_mount, volume_name)"},{"line_number":736,"context_line":"            vol_size \u003d math.ceil(float(utils.get_file_size(volume_path)) /"},{"line_number":737,"context_line":"                                 units.Gi)"},{"line_number":738,"context_line":"        except OSError:"},{"line_number":739,"context_line":"            msg \u003d (_(\u0027Failed to get size of volume %s\u0027) %"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_bb4d629b","line":736,"range":{"start_line":736,"start_character":22,"end_line":736,"end_character":23},"updated":"2016-06-07 02:31:58.000000000","message":"I think the better way is add int() here","commit_id":"4384f1477378d25112706922ac1aa8f3b31a5d6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"774687ede51929fcf4eb9289062094d6d63879e5","unresolved":false,"context_lines":[{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        try:"},{"line_number":735,"context_line":"            volume_path \u003d os.path.join(nfs_mount, volume_name)"},{"line_number":736,"context_line":"            vol_size \u003d math.ceil(float(utils.get_file_size(volume_path)) /"},{"line_number":737,"context_line":"                                 units.Gi)"},{"line_number":738,"context_line":"        except OSError:"},{"line_number":739,"context_line":"            msg \u003d (_(\u0027Failed to get size of volume %s\u0027) %"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_2d9c345c","line":736,"range":{"start_line":736,"start_character":22,"end_line":736,"end_character":23},"in_reply_to":"7aa08908_bb4d629b","updated":"2016-06-08 10:22:11.000000000","message":"I agree, that would make this code consistent with other drivers.","commit_id":"4384f1477378d25112706922ac1aa8f3b31a5d6c"}]}