)]}'
{"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"05c8f674f329c0e2e18cbd1acdc117bf02779900","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def __formatUrl(self, url):"},{"line_number":113,"context_line":"        baseurl \u003d self.baseUrl"},{"line_number":114,"context_line":"        if url.find(\u0027api/rest\u0027) \u003c 0:"},{"line_number":115,"context_line":"            baseurl \u003d baseurl + \u0027api/rest/\u0027"},{"line_number":116,"context_line":"        return \u0027%s%s\u0027 % (baseurl, url if url[0] !\u003d \u0027/\u0027 else url[1:])"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_06ea72ac","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":36},"updated":"2016-06-10 09:31:26.000000000","message":"nit: Not very pythonic:\n\n if \u0027api/rest\u0027 not in url:","commit_id":"8d1344dd5c816044ab890f222f2ec9f0cc6ae72c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"5f33a7af3bf52003a1d04beb162550fd364385ac","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def __formatUrl(self, url):"},{"line_number":113,"context_line":"        baseurl \u003d self.baseUrl"},{"line_number":114,"context_line":"        if url.find(\u0027api/rest\u0027) \u003c 0:"},{"line_number":115,"context_line":"            baseurl \u003d baseurl + \u0027api/rest/\u0027"},{"line_number":116,"context_line":"        return \u0027%s%s\u0027 % (baseurl, url if url[0] !\u003d \u0027/\u0027 else url[1:])"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_286da932","line":114,"range":{"start_line":114,"start_character":8,"end_line":114,"end_character":36},"in_reply_to":"7aa08908_06ea72ac","updated":"2016-06-10 15:45:58.000000000","message":"Done","commit_id":"8d1344dd5c816044ab890f222f2ec9f0cc6ae72c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"05c8f674f329c0e2e18cbd1acdc117bf02779900","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def __formatUrl(self, url):"},{"line_number":113,"context_line":"        baseurl \u003d self.baseUrl"},{"line_number":114,"context_line":"        if url.find(\u0027api/rest\u0027) \u003c 0:"},{"line_number":115,"context_line":"            baseurl \u003d baseurl + \u0027api/rest/\u0027"},{"line_number":116,"context_line":"        return \u0027%s%s\u0027 % (baseurl, url if url[0] !\u003d \u0027/\u0027 else url[1:])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_header(self, async):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_0601d26a","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":43},"updated":"2016-06-10 09:31:26.000000000","message":"nit:\n\n baseurl +\u003d \u0027api/rest/\u0027","commit_id":"8d1344dd5c816044ab890f222f2ec9f0cc6ae72c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"5f33a7af3bf52003a1d04beb162550fd364385ac","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def __formatUrl(self, url):"},{"line_number":113,"context_line":"        baseurl \u003d self.baseUrl"},{"line_number":114,"context_line":"        if url.find(\u0027api/rest\u0027) \u003c 0:"},{"line_number":115,"context_line":"            baseurl \u003d baseurl + \u0027api/rest/\u0027"},{"line_number":116,"context_line":"        return \u0027%s%s\u0027 % (baseurl, url if url[0] !\u003d \u0027/\u0027 else url[1:])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def _get_header(self, async):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_0868ad20","line":115,"range":{"start_line":115,"start_character":12,"end_line":115,"end_character":43},"in_reply_to":"7aa08908_0601d26a","updated":"2016-06-10 15:45:58.000000000","message":"Done","commit_id":"8d1344dd5c816044ab890f222f2ec9f0cc6ae72c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"05c8f674f329c0e2e18cbd1acdc117bf02779900","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        \"\"\"Handle a bug in SC API that gives a full url.\"\"\""},{"line_number":127,"context_line":"        url \u003d asyncTask.get(\u0027returnValue\u0027)"},{"line_number":128,"context_line":"        id \u003d asyncTask.get(\u0027instanceId\u0027)"},{"line_number":129,"context_line":"        if \u0027http\u0027 in url:"},{"line_number":130,"context_line":"            # Strip off the host/port part"},{"line_number":131,"context_line":"            proto_mark \u003d url.find(\u0027:\u0027)"},{"line_number":132,"context_line":"            url \u003d url[url.find(\u0027/\u0027, proto_mark + 3) + 1:]"},{"line_number":133,"context_line":"        if url.endswith(\u0027/\u0027):"},{"line_number":134,"context_line":"            if id:"},{"line_number":135,"context_line":"                # We have an id so note the error and add the id."}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_0923a5a8","line":132,"range":{"start_line":129,"start_character":8,"end_line":132,"end_character":57},"updated":"2016-06-10 09:31:26.000000000","message":"nit: This is probably better handled using urlparser or even url.split(\u0027://\u0027)","commit_id":"8d1344dd5c816044ab890f222f2ec9f0cc6ae72c"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"5f33a7af3bf52003a1d04beb162550fd364385ac","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        \"\"\"Handle a bug in SC API that gives a full url.\"\"\""},{"line_number":127,"context_line":"        url \u003d asyncTask.get(\u0027returnValue\u0027)"},{"line_number":128,"context_line":"        id \u003d asyncTask.get(\u0027instanceId\u0027)"},{"line_number":129,"context_line":"        if \u0027http\u0027 in url:"},{"line_number":130,"context_line":"            # Strip off the host/port part"},{"line_number":131,"context_line":"            proto_mark \u003d url.find(\u0027:\u0027)"},{"line_number":132,"context_line":"            url \u003d url[url.find(\u0027/\u0027, proto_mark + 3) + 1:]"},{"line_number":133,"context_line":"        if url.endswith(\u0027/\u0027):"},{"line_number":134,"context_line":"            if id:"},{"line_number":135,"context_line":"                # We have an id so note the error and add the id."}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_2e7771d5","line":132,"range":{"start_line":129,"start_character":8,"end_line":132,"end_character":57},"in_reply_to":"7aa08908_0923a5a8","updated":"2016-06-10 15:45:58.000000000","message":"k","commit_id":"8d1344dd5c816044ab890f222f2ec9f0cc6ae72c"}]}