)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"f3a8aaafd1d9602ce49c14fbd9e7bfca3a700f51","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        if source_volume and volume_type:"},{"line_number":251,"context_line":"            if (source_volume[\u0027volume_type_id\u0027] and"},{"line_number":252,"context_line":"                    volume_type[\u0027id\u0027] !\u003d source_volume[\u0027volume_type_id\u0027]):"},{"line_number":253,"context_line":"                if not self._retype_is_possible("},{"line_number":254,"context_line":"                        context,"},{"line_number":255,"context_line":"                        volume_type[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_feea38ab","line":252,"updated":"2016-06-07 02:52:52.000000000","message":"This is not correct fix. \n\nCurrently Cinder only supports to create volume from source volume in same backend storage.\n\nFor example, there are two backend storages A and B.\n\nThere is one volume in storage A without volume type.\n\nIf there is another volume type T2 with extra_specs volume_backend_name as B.\n\nNow to create a new volume from the above volume with type T2, it should not be created. But with your codes, it succeeds.","commit_id":"66bc633dd432fced6d5960ff6785904e8f2fb84b"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"9e2fecfc756a070253a605ce848fcd2064536741","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        if source_volume and volume_type:"},{"line_number":251,"context_line":"            if (source_volume[\u0027volume_type_id\u0027] and"},{"line_number":252,"context_line":"                    volume_type[\u0027id\u0027] !\u003d source_volume[\u0027volume_type_id\u0027]):"},{"line_number":253,"context_line":"                if not self._retype_is_possible("},{"line_number":254,"context_line":"                        context,"},{"line_number":255,"context_line":"                        volume_type[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_be1b907f","line":252,"in_reply_to":"7aa08908_feea38ab","updated":"2016-06-07 03:12:18.000000000","message":"Agree with LisaLi, we should also check whether retype is possible when source volume\u0027s type is None and new volume\u0027s type is not none.\nBut with this change we can\u0027t go into the check code in line 253.","commit_id":"66bc633dd432fced6d5960ff6785904e8f2fb84b"}]}