)]}'
{"doc/source/devref/api_conditional_updates.rst":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"c6996b042718f4f171d255bbb6511cb35750d23b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"the inherent uncertainty of the cause of failure resulting in more generic"},{"line_number":207,"context_line":"error messages."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"When we use the `conditional_update` method we\u0027ll use returned value to"},{"line_number":210,"context_line":"determine the success of the operation, as a value of 0 indicates that no rows"},{"line_number":211,"context_line":"have been updated and the conditions were not met.  But we don\u0027t know which"},{"line_number":212,"context_line":"one, or which ones, were the cause of the failure."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_744bf987","line":209,"range":{"start_line":209,"start_character":44,"end_line":209,"end_character":49},"updated":"2016-06-07 09:55:33.000000000","message":"s/we\u0027ll/we","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c66747258a3e59e60df9105728c9f24de1db1070","unresolved":false,"context_lines":[{"line_number":206,"context_line":"the inherent uncertainty of the cause of failure resulting in more generic"},{"line_number":207,"context_line":"error messages."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"When we use the `conditional_update` method we\u0027ll use returned value to"},{"line_number":210,"context_line":"determine the success of the operation, as a value of 0 indicates that no rows"},{"line_number":211,"context_line":"have been updated and the conditions were not met.  But we don\u0027t know which"},{"line_number":212,"context_line":"one, or which ones, were the cause of the failure."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_c7915d54","line":209,"range":{"start_line":209,"start_character":44,"end_line":209,"end_character":49},"in_reply_to":"7aa08908_744bf987","updated":"2016-06-07 10:37:43.000000000","message":"I\u0027m no native speaker, but afaik this is grammatically correct.","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"228f317eeeacb24ce4a5a9c8788260065f836a4a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"the inherent uncertainty of the cause of failure resulting in more generic"},{"line_number":207,"context_line":"error messages."},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"When we use the `conditional_update` method we\u0027ll use returned value to"},{"line_number":210,"context_line":"determine the success of the operation, as a value of 0 indicates that no rows"},{"line_number":211,"context_line":"have been updated and the conditions were not met.  But we don\u0027t know which"},{"line_number":212,"context_line":"one, or which ones, were the cause of the failure."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_161a756e","line":209,"range":{"start_line":209,"start_character":44,"end_line":209,"end_character":49},"in_reply_to":"7aa08908_c7915d54","updated":"2016-06-07 11:16:25.000000000","message":"Yes, we\u0027ll is correct.","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"c6996b042718f4f171d255bbb6511cb35750d23b","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"When we use the `conditional_update` method we\u0027ll use returned value to"},{"line_number":210,"context_line":"determine the success of the operation, as a value of 0 indicates that no rows"},{"line_number":211,"context_line":"have been updated and the conditions were not met.  But we don\u0027t know which"},{"line_number":212,"context_line":"one, or which ones, were the cause of the failure."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"There are 2 approaches to this issue:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_7405b978","line":211,"range":{"start_line":211,"start_character":50,"end_line":211,"end_character":52},"updated":"2016-06-07 09:55:33.000000000","message":"more spaces...\n\nmay be below normalized:\n\nBut we don\u0027t know which one, or which ones, were the cause of the failure\n\nBut we don\u0027t know which one(s) caused failure.","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c66747258a3e59e60df9105728c9f24de1db1070","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"When we use the `conditional_update` method we\u0027ll use returned value to"},{"line_number":210,"context_line":"determine the success of the operation, as a value of 0 indicates that no rows"},{"line_number":211,"context_line":"have been updated and the conditions were not met.  But we don\u0027t know which"},{"line_number":212,"context_line":"one, or which ones, were the cause of the failure."},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"There are 2 approaches to this issue:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_2722e100","line":211,"range":{"start_line":211,"start_character":50,"end_line":211,"end_character":52},"in_reply_to":"7aa08908_7405b978","updated":"2016-06-07 10:37:43.000000000","message":"While both sentences may be similar, they don\u0027t convey the exact same meaning, and I wanted to stress the possibility of having multiple failure causes, hence the way the sentence is built.\n\nAs for double spaces, they are intentional and they are fine.  We use them a lot in commit messages and in rst files to make it easier to read during review, and in rendered documentation they are reduced to single spaces.","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f100f58166cdaeae835006682ceaf9a993426957","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"It was decided that we would go with the second approach, because even though"},{"line_number":223,"context_line":"the first approach was closer to what we already had and would give a better"},{"line_number":224,"context_line":"user experience had considerable implications such as:"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"- More code was needed to do individual checks making operations considerable"},{"line_number":227,"context_line":"  longer and less readable.  This was greatly alleviated using helper methods"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_b40a811f","line":224,"range":{"start_line":224,"start_character":15,"end_line":224,"end_character":19},"updated":"2016-06-07 09:42:20.000000000","message":"Shouldn\u0027t it be \"it had\"? Or a comma is missing here?","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c66747258a3e59e60df9105728c9f24de1db1070","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"It was decided that we would go with the second approach, because even though"},{"line_number":223,"context_line":"the first approach was closer to what we already had and would give a better"},{"line_number":224,"context_line":"user experience had considerable implications such as:"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"- More code was needed to do individual checks making operations considerable"},{"line_number":227,"context_line":"  longer and less readable.  This was greatly alleviated using helper methods"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_4709eddc","line":224,"range":{"start_line":224,"start_character":15,"end_line":224,"end_character":19},"in_reply_to":"7aa08908_b40a811f","updated":"2016-06-07 10:37:43.000000000","message":"I think I\u0027ll go with both.","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"c6996b042718f4f171d255bbb6511cb35750d23b","unresolved":false,"context_lines":[{"line_number":224,"context_line":"user experience had considerable implications such as:"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"- More code was needed to do individual checks making operations considerable"},{"line_number":227,"context_line":"  longer and less readable.  This was greatly alleviated using helper methods"},{"line_number":228,"context_line":"  to return the errors."},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- Higher number of DB queries required to determine failure cause."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_74ef7987","line":227,"range":{"start_line":227,"start_character":27,"end_line":227,"end_character":29},"updated":"2016-06-07 09:55:33.000000000","message":"more spaces :)","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c66747258a3e59e60df9105728c9f24de1db1070","unresolved":false,"context_lines":[{"line_number":224,"context_line":"user experience had considerable implications such as:"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"- More code was needed to do individual checks making operations considerable"},{"line_number":227,"context_line":"  longer and less readable.  This was greatly alleviated using helper methods"},{"line_number":228,"context_line":"  to return the errors."},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"- Higher number of DB queries required to determine failure cause."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_47f28d70","line":227,"range":{"start_line":227,"start_character":27,"end_line":227,"end_character":29},"in_reply_to":"7aa08908_74ef7987","updated":"2016-06-07 10:37:43.000000000","message":"ditto","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"c6996b042718f4f171d255bbb6511cb35750d23b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"  specific error, a loop would be needed to make sure that either the"},{"line_number":235,"context_line":"  conditional update succeeds or one of the condition checks fails."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"- Having such a loop meant that a small error in the code could lead to an"},{"line_number":238,"context_line":"  endless loop in a production environment.  This coding error could be an"},{"line_number":239,"context_line":"  incorrect conditional update filter that would always fail or a missing or"},{"line_number":240,"context_line":"  incorrect condition that checked for the specific issue to return the error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_1490b5eb","line":237,"range":{"start_line":237,"start_character":21,"end_line":237,"end_character":26},"updated":"2016-06-07 09:55:33.000000000","message":"s/meant/means","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c66747258a3e59e60df9105728c9f24de1db1070","unresolved":false,"context_lines":[{"line_number":234,"context_line":"  specific error, a loop would be needed to make sure that either the"},{"line_number":235,"context_line":"  conditional update succeeds or one of the condition checks fails."},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"- Having such a loop meant that a small error in the code could lead to an"},{"line_number":238,"context_line":"  endless loop in a production environment.  This coding error could be an"},{"line_number":239,"context_line":"  incorrect conditional update filter that would always fail or a missing or"},{"line_number":240,"context_line":"  incorrect condition that checked for the specific issue to return the error."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_e70d793f","line":237,"range":{"start_line":237,"start_character":21,"end_line":237,"end_character":26},"in_reply_to":"7aa08908_1490b5eb","updated":"2016-06-07 10:37:43.000000000","message":"Yes, I\u0027ll change it.\n\nMy mind slipped because I had actually implemented it that way on the first patches, that\u0027s why I used meant.   XD","commit_id":"e0380d6d2b2a35211bfa2fd1d0af96a29f565535"}]}