)]}'
{"doc/source/devref/testing.rst":[{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"896325d00f2ac58b3e25989c4f4cafc22480ca74","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Unit Tests"},{"line_number":12,"context_line":"~~~~~~~~~~"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Unit tests are tests ideally for individual methods, with at the most a small"},{"line_number":15,"context_line":"handful of modules involved. Mock should be used to remove any external"},{"line_number":16,"context_line":"dependencies."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"All significant code changes should have unit test coverage validating the code"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_32beecd4","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":28},"updated":"2016-06-09 18:21:53.000000000","message":"Awkward sentence. Ditch ideally. \"with at the most\" should probably be \"with at most\".","commit_id":"6f85cda50787c8a3325a99189e9c2c5e33c5fdd0"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"896325d00f2ac58b3e25989c4f4cafc22480ca74","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Tempest Tests"},{"line_number":32,"context_line":"~~~~~~~~~~~~~"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"The tempest tests in the Cinder tree validate the entire operational"},{"line_number":35,"context_line":"correctness between Cinder and external components such as Nova, Glance, etc."},{"line_number":36,"context_line":"These are integration tests driven via public APIs to verify actual end user"},{"line_number":37,"context_line":"usage scenarios."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_7286b414","line":34,"range":{"start_line":34,"start_character":50,"end_line":34,"end_character":56},"updated":"2016-06-09 18:21:53.000000000","message":"Whack","commit_id":"6f85cda50787c8a3325a99189e9c2c5e33c5fdd0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e0e9f2df91dbf1dbbcd8ae7d5eba97faae8aad26","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Functional tests validate a code path within Cinder. These tests should"},{"line_number":27,"context_line":"validate the interaction of various modules within the project to verify the"},{"line_number":28,"context_line":"code is logically correct."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Tempest Tests"},{"line_number":31,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_d825090b","line":28,"updated":"2016-06-09 18:53:50.000000000","message":"I would like to see a description here along the lines of \"functional tests run with an SQL database present and may start a Cinder service that accepts requests, but will not have access to other OpenStack services\".\n\n(Or some version of that that\u0027s more accurate/understandable.)","commit_id":"cbbae98cb1660daa4acf871c6da387980a99a269"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6d431482ccbb556473316c88f6af1295b56858de","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Functional tests validate a code path within Cinder. These tests should"},{"line_number":27,"context_line":"validate the interaction of various modules within the project to verify the"},{"line_number":28,"context_line":"code is logically correct."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Tempest Tests"},{"line_number":31,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7aa08908_3899ad20","line":28,"in_reply_to":"7aa08908_d825090b","updated":"2016-06-09 18:56:38.000000000","message":"Good idea.","commit_id":"cbbae98cb1660daa4acf871c6da387980a99a269"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"c9dfd2590570bd2ade3c6216e29aca5d57c2f2dd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Cinder contains a few different test suites in the cinder/tests/ directory. The"},{"line_number":5,"context_line":"different test suites are Unit Tests, Functional Tests, and Tempest Test."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Test Types"},{"line_number":8,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7aa08908_a67bba7a","line":5,"updated":"2016-06-09 19:26:16.000000000","message":"Test -\u003e Tests","commit_id":"11dac1c6657b3520517dce32117e485a66d496c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0093cc2bc89efee9469510463b7e384c03fae50b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"The tempest tests in the Cinder tree validate the operational correctness"},{"line_number":38,"context_line":"between Cinder and external components such as Nova, Glance, etc. These are"},{"line_number":39,"context_line":"integration tests driven via public APIs to verify actual end user usage"},{"line_number":40,"context_line":"scenarios."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Running the tests"},{"line_number":43,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_eee99080","line":40,"updated":"2016-06-13 20:28:27.000000000","message":"A lot of the tempest tests aren\u0027t really for user scenarios.  Many are to ensure that API behavior is stable, especially when it comes to the negative tests in tempest.","commit_id":"61238e2e544e5ff5ecb288c26b4bf57953ec1c56"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"713e12659e7d9ea060adb517f06beee7e0037aee","unresolved":false,"context_lines":[{"line_number":37,"context_line":"The tempest tests in the Cinder tree validate the operational correctness"},{"line_number":38,"context_line":"between Cinder and external components such as Nova, Glance, etc. These are"},{"line_number":39,"context_line":"integration tests driven via public APIs to verify actual end user usage"},{"line_number":40,"context_line":"scenarios."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Running the tests"},{"line_number":43,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_55f1cc94","line":40,"in_reply_to":"7aa08908_b0fa46bb","updated":"2016-06-16 04:33:36.000000000","message":"I still think this is a vast improvement over what we had.  I\u0027m not keen on holding anything up but Eric\u0027s point is valid.  I think there\u0027s always room to improve  these sorts of things but would rather see it get started than to polish it until perfect.\n\nIn other words, how about a follow up?","commit_id":"61238e2e544e5ff5ecb288c26b4bf57953ec1c56"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"acd9f2b64986c5682fb5668d0d3a1610660664b7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"The tempest tests in the Cinder tree validate the operational correctness"},{"line_number":38,"context_line":"between Cinder and external components such as Nova, Glance, etc. These are"},{"line_number":39,"context_line":"integration tests driven via public APIs to verify actual end user usage"},{"line_number":40,"context_line":"scenarios."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Running the tests"},{"line_number":43,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_b0fa46bb","line":40,"in_reply_to":"7aa08908_eee99080","updated":"2016-06-13 20:38:34.000000000","message":"True. If I do another update I will clarify that statement to be explain it is using the public APIs to driver different operations. Unless you would prefer I do that right now. Just let me know.","commit_id":"61238e2e544e5ff5ecb288c26b4bf57953ec1c56"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0093cc2bc89efee9469510463b7e384c03fae50b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Gotchas"},{"line_number":105,"context_line":"-------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"**Running Tests from Shared Folders**"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"If you are running the unit tests from a shared folder, you may see tests start"},{"line_number":110,"context_line":"to fail or stop completely as a result of Python lockfile issues. You"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_2e2398be","line":107,"updated":"2016-06-13 20:28:27.000000000","message":"This whole section seems like an odd thing to document here.","commit_id":"61238e2e544e5ff5ecb288c26b4bf57953ec1c56"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"acd9f2b64986c5682fb5668d0d3a1610660664b7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"Gotchas"},{"line_number":105,"context_line":"-------"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"**Running Tests from Shared Folders**"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"If you are running the unit tests from a shared folder, you may see tests start"},{"line_number":110,"context_line":"to fail or stop completely as a result of Python lockfile issues. You"}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_302db646","line":107,"in_reply_to":"7aa08908_2e2398be","updated":"2016-06-13 20:38:34.000000000","message":"I actually agree, but this was in the doc before so I didn\u0027t know if there was a reason it was there in the first place.","commit_id":"61238e2e544e5ff5ecb288c26b4bf57953ec1c56"}],"doc/source/devref/unit_tests.rst":[{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"896325d00f2ac58b3e25989c4f4cafc22480ca74","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Running the tests"},{"line_number":10,"context_line":"-----------------"},{"line_number":11,"context_line":"There are a number of ways to run unit tests currently, and there\u0027s a combination"},{"line_number":12,"context_line":"of frameworks used depending on what commands you use.  The preferred method"},{"line_number":13,"context_line":"is to use tox, which calls ostestr via the tox.ini file.  To run all tests simply run::"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_322f0cf8","side":"PARENT","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":55},"updated":"2016-06-09 18:21:53.000000000","message":"comma with an and?","commit_id":"5804a3d7565bbf66edeae25f53c7112035251622"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"896325d00f2ac58b3e25989c4f4cafc22480ca74","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    ./run_tests.sh"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This script is a wrapper around the testr testrunner and the flake8 checker. Note that"},{"line_number":45,"context_line":"there has been talk around deprecating this wrapper and this method of testing, it\u0027s currently"},{"line_number":46,"context_line":"available still but it may be good to get used to using tox or even ostestr directly."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Documentation is left in place for those that still use it."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_d26cc838","side":"PARENT","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":85},"updated":"2016-06-09 18:21:53.000000000","message":"We\u0027re warning that something might be deprecated before it is deprecated?","commit_id":"5804a3d7565bbf66edeae25f53c7112035251622"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6203b585c1a9a2ead509d7ef3e2ea4067e750a18","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    ./run_tests.sh"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"This script is a wrapper around the testr testrunner and the flake8 checker. Note that"},{"line_number":45,"context_line":"there has been talk around deprecating this wrapper and this method of testing, it\u0027s currently"},{"line_number":46,"context_line":"available still but it may be good to get used to using tox or even ostestr directly."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Documentation is left in place for those that still use it."},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7aa08908_f5ff2ea8","side":"PARENT","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":85},"in_reply_to":"7aa08908_d26cc838","updated":"2016-06-09 18:27:45.000000000","message":"This is the content being removed.","commit_id":"5804a3d7565bbf66edeae25f53c7112035251622"}]}