)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"d1e8b587fdd9188a3f94cac780fbcee04bbfbeff","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the volume when clone has finished. This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icd626ff894e052f557f3da9439b217ed4924014e"},{"line_number":14,"context_line":"Close-Bug: #1554764"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_32b95a16","line":14,"updated":"2016-06-13 09:59:48.000000000","message":"use \u0027Closes-Bug\u0027 as Closes-Bug: #1554764\n\nGuide lines mentioned here: https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"70d89bba08b9c562f27fe316a71c8eabe12638dc"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"7033f247ef0af51834621b38f735782d4515b4df","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the volume when clone has finished. This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icd626ff894e052f557f3da9439b217ed4924014e"},{"line_number":14,"context_line":"Close-Bug: #1554764"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7aa08908_92276eb5","line":14,"updated":"2016-06-13 10:05:21.000000000","message":"Use keyword as Closes-Bug: #1554764\nGuide lines metinoed here: https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"54cca5d94ee96387c85be5b668255ce00db04f7c"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"7f16a9fe2f77e462a112ede611cd29d7f0ed84f9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the volume when clone has finished. This patch fixes it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Icd626ff894e052f557f3da9439b217ed4924014e"},{"line_number":14,"context_line":"Closes-Bug: #1554764"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_955f9b40","line":14,"updated":"2016-06-22 18:51:18.000000000","message":"Depends-on: I829c0e6f99fff0ec0bd5366c9d2e79b1b073f0a3\n\nTempest currently does not cover the path touched by this fix. So, we should run this extend test as dependency so we can assure they work for all backends after CIs runs.","commit_id":"2eff6524805fb5de351845ce0cdcc60754d24ad9"}],"cinder/tests/unit/test_xio.py":[{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"d1e8b587fdd9188a3f94cac780fbcee04bbfbeff","unresolved":false,"context_lines":[{"line_number":59,"context_line":"CLONE1 \u003d {\u0027id\u0027: \u00273\u0027, \u0027name\u0027: \u0027clone1\u0027,"},{"line_number":60,"context_line":"          \u0027size\u0027: VOLUME_SIZE, \u0027volume_type_id\u0027: \u0027type4\u0027}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"CLONE2\u003d {\u0027id\u0027: \u00273\u0027, \u0027name\u0027: \u0027clone2\u0027,"},{"line_number":63,"context_line":"          \u0027size\u0027: NEW_VOLUME_SIZE, \u0027volume_type_id\u0027: \u0027type4\u0027}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"HOST1 \u003d \u0027host1\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_525346e2","line":62,"updated":"2016-06-13 09:59:48.000000000","message":"Be consistent here CLONE2[space]\u003d","commit_id":"70d89bba08b9c562f27fe316a71c8eabe12638dc"}],"cinder/volume/drivers/xio.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3356cfb4741a6e5f679c71a8479e6405deba11b5","unresolved":false,"context_lines":[{"line_number":1165,"context_line":"        \"\"\"Create clone\"\"\""},{"line_number":1166,"context_line":"        LOG.debug(\"X-IO create_cloned_volume called.\")"},{"line_number":1167,"context_line":"        self._create_clone(src_vref, volume, \u0027clone\u0027)"},{"line_number":1168,"context_line":"        if volume[\u0027size\u0027] !\u003d src_vref[\u0027size\u0027]:"},{"line_number":1169,"context_line":"            LOG.debug(\"modify volume \u0027%(dst_vol)s\u0027 from %(src_size)d to \""},{"line_number":1170,"context_line":"                      \"%(dst_size)d\","},{"line_number":1171,"context_line":"                      {\u0027dst_vol\u0027: volume[\u0027name\u0027], \u0027src_size\u0027: src_vref[\u0027size\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_71a69cc2","line":1168,"range":{"start_line":1168,"start_character":8,"end_line":1168,"end_character":46},"updated":"2016-06-22 11:51:13.000000000","message":"-1: We should not be using Versioned Objects as dictionaries in new code:\n\n if volume.size \u003e src_vref.size:","commit_id":"2eff6524805fb5de351845ce0cdcc60754d24ad9"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9a3545cca0b255906e092f246d87de9b15be6000","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        LOG.debug(\"X-IO create_cloned_volume called.\")"},{"line_number":1167,"context_line":"        self._create_clone(src_vref, volume, \u0027clone\u0027)"},{"line_number":1168,"context_line":"        if volume[\u0027size\u0027] !\u003d src_vref[\u0027size\u0027]:"},{"line_number":1169,"context_line":"            LOG.debug(\"modify volume \u0027%(dst_vol)s\u0027 from %(src_size)d to \""},{"line_number":1170,"context_line":"                      \"%(dst_size)d\","},{"line_number":1171,"context_line":"                      {\u0027dst_vol\u0027: volume[\u0027name\u0027], \u0027src_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1172,"context_line":"                       \u0027dst_size\u0027: volume[\u0027size\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_65b34f4e","line":1169,"range":{"start_line":1169,"start_character":0,"end_line":1169,"end_character":73},"updated":"2016-06-16 16:55:47.000000000","message":"Might want to consider making this a little more clear.  \"Increasing size of cloned volume\"\n\nSomething simple, but still indicating what\u0027s going on.","commit_id":"2eff6524805fb5de351845ce0cdcc60754d24ad9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3356cfb4741a6e5f679c71a8479e6405deba11b5","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"        LOG.debug(\"X-IO create_cloned_volume called.\")"},{"line_number":1167,"context_line":"        self._create_clone(src_vref, volume, \u0027clone\u0027)"},{"line_number":1168,"context_line":"        if volume[\u0027size\u0027] !\u003d src_vref[\u0027size\u0027]:"},{"line_number":1169,"context_line":"            LOG.debug(\"modify volume \u0027%(dst_vol)s\u0027 from %(src_size)d to \""},{"line_number":1170,"context_line":"                      \"%(dst_size)d\","},{"line_number":1171,"context_line":"                      {\u0027dst_vol\u0027: volume[\u0027name\u0027], \u0027src_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1172,"context_line":"                       \u0027dst_size\u0027: volume[\u0027size\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_91ba28e0","line":1169,"range":{"start_line":1169,"start_character":0,"end_line":1169,"end_character":73},"in_reply_to":"7aa08908_65b34f4e","updated":"2016-06-22 11:51:13.000000000","message":"I agree, and I would use Extend, since that\u0027s how we call that operation (regardless of the method name called here).","commit_id":"2eff6524805fb5de351845ce0cdcc60754d24ad9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3356cfb4741a6e5f679c71a8479e6405deba11b5","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"        if volume[\u0027size\u0027] !\u003d src_vref[\u0027size\u0027]:"},{"line_number":1169,"context_line":"            LOG.debug(\"modify volume \u0027%(dst_vol)s\u0027 from %(src_size)d to \""},{"line_number":1170,"context_line":"                      \"%(dst_size)d\","},{"line_number":1171,"context_line":"                      {\u0027dst_vol\u0027: volume[\u0027name\u0027], \u0027src_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1172,"context_line":"                       \u0027dst_size\u0027: volume[\u0027size\u0027]})"},{"line_number":1173,"context_line":"            self._modify_volume(volume, {\u0027size\u0027: volume[\u0027size\u0027]})"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"    def create_snapshot(self, snapshot):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_7194dc36","line":1172,"range":{"start_line":1171,"start_character":22,"end_line":1172,"end_character":51},"updated":"2016-06-22 11:51:13.000000000","message":"-1: Same here: volume.name, src_vref.size, volume.size","commit_id":"2eff6524805fb5de351845ce0cdcc60754d24ad9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3356cfb4741a6e5f679c71a8479e6405deba11b5","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"                      \"%(dst_size)d\","},{"line_number":1171,"context_line":"                      {\u0027dst_vol\u0027: volume[\u0027name\u0027], \u0027src_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1172,"context_line":"                       \u0027dst_size\u0027: volume[\u0027size\u0027]})"},{"line_number":1173,"context_line":"            self._modify_volume(volume, {\u0027size\u0027: volume[\u0027size\u0027]})"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":1176,"context_line":"        \"\"\"Create snapshot\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_d1995070","line":1173,"range":{"start_line":1173,"start_character":49,"end_line":1173,"end_character":63},"updated":"2016-06-22 11:51:13.000000000","message":"-1: volume.size","commit_id":"2eff6524805fb5de351845ce0cdcc60754d24ad9"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"bb215a7d985dbe32fb1492cc1480b02d7d27b8c0","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"        if volume[\u0027size\u0027] !\u003d src_vref[\u0027size\u0027]:"},{"line_number":1174,"context_line":"            LOG.debug(\"modify volume \u0027%(dst_vol)s\u0027 from %(src_size)d to \""},{"line_number":1175,"context_line":"                      \"%(dst_size)d\","},{"line_number":1176,"context_line":"                      {\u0027dst_vol\u0027: volume[\u0027name\u0027], \u0027src_size\u0027: src_vref[\u0027size\u0027],"},{"line_number":1177,"context_line":"                       \u0027dst_size\u0027: volume[\u0027size\u0027]})"},{"line_number":1178,"context_line":"            self._modify_volume(volume, {\u0027size\u0027: volume[\u0027size\u0027]})"},{"line_number":1179,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a1ced50_7a338bab","line":1176,"updated":"2017-03-21 15:05:11.000000000","message":"Please, use volume id for the log messages","commit_id":"797abbd182596c71226940c4386e2b97ab891477"}]}
