)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7f43548c0b0c1c00270b895f5488c08526c1c3b8","unresolved":false,"context_lines":[{"line_number":2962,"context_line":"                    \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})"},{"line_number":2963,"context_line":"        model_query(context, models.VolumeTypeProjects,"},{"line_number":2964,"context_line":"                    session\u003dsession).filter_by(volume_type_id\u003did).update({"},{"line_number":2965,"context_line":"                        \u0027deleted\u0027: True, \u0027deleted_at\u0027: timeutils.utcnow(),"},{"line_number":2966,"context_line":"                        \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})"},{"line_number":2967,"context_line":""},{"line_number":2968,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d48729b3","line":2965,"range":{"start_line":2965,"start_character":24,"end_line":2965,"end_character":39},"updated":"2016-06-13 07:48:38.000000000","message":"Deleted is an Integer in that table, so you should set id in there when deleting. Simply - use oslo.db\u0027s soft_delete like in volume_type_access_remove.","commit_id":"d125b6cad3c5d7810d794742a6e0ebfc616a3e2c"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"ffa05d6f5cb7205a3d2c6115a65f579e0079756a","unresolved":false,"context_lines":[{"line_number":2960,"context_line":"            update({\u0027deleted\u0027: True,"},{"line_number":2961,"context_line":"                    \u0027deleted_at\u0027: timeutils.utcnow(),"},{"line_number":2962,"context_line":"                    \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})"},{"line_number":2963,"context_line":"        model_query(context, models.VolumeTypeProjects, session\u003dsession,"},{"line_number":2964,"context_line":"                    read_deleted\u003d\"int_no\").filter_by("},{"line_number":2965,"context_line":"            volume_type_id\u003did).soft_delete(synchronize_session\u003dFalse)"},{"line_number":2966,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_dc2ba080","line":2963,"updated":"2016-06-14 06:25:18.000000000","message":"I have one query here. do we need to permanently delete project when its volume type deleted? if yes then soft_delete function performing permanently delete? \nI have read about soft delete.(If you soft delete something it is still there so it\u0027s able to be recovered )","commit_id":"a8744e26ba665a9103f153bd516dd49d99fd0c2f"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"e4dafca2a0ecd7e9f615b4d563ef8c636ccf4d50","unresolved":false,"context_lines":[{"line_number":2960,"context_line":"            update({\u0027deleted\u0027: True,"},{"line_number":2961,"context_line":"                    \u0027deleted_at\u0027: timeutils.utcnow(),"},{"line_number":2962,"context_line":"                    \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})"},{"line_number":2963,"context_line":"        model_query(context, models.VolumeTypeProjects, session\u003dsession,"},{"line_number":2964,"context_line":"                    read_deleted\u003d\"int_no\").filter_by("},{"line_number":2965,"context_line":"            volume_type_id\u003did).soft_delete(synchronize_session\u003dFalse)"},{"line_number":2966,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_56d82c53","line":2963,"in_reply_to":"7aa08908_dc2ba080","updated":"2016-06-14 06:59:53.000000000","message":"Hi Kushal,\n\nWhen we add access of a volume-type to a project, it creates a new entry in volume_type_projects table in the database. So on deleting the volume-type we are deleting its associated volume_type_projects entry and not the project.","commit_id":"a8744e26ba665a9103f153bd516dd49d99fd0c2f"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"8e35dd9138ed95ce62ead8a31cd90b05afb316bc","unresolved":false,"context_lines":[{"line_number":2960,"context_line":"            update({\u0027deleted\u0027: True,"},{"line_number":2961,"context_line":"                    \u0027deleted_at\u0027: timeutils.utcnow(),"},{"line_number":2962,"context_line":"                    \u0027updated_at\u0027: literal_column(\u0027updated_at\u0027)})"},{"line_number":2963,"context_line":"        model_query(context, models.VolumeTypeProjects, session\u003dsession,"},{"line_number":2964,"context_line":"                    read_deleted\u003d\"int_no\").filter_by("},{"line_number":2965,"context_line":"            volume_type_id\u003did).soft_delete(synchronize_session\u003dFalse)"},{"line_number":2966,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_9642940d","line":2963,"in_reply_to":"7aa08908_dc2ba080","updated":"2016-06-14 06:57:35.000000000","message":"We\u0027re always soft-deleting everything from the DB, so it should be fine.","commit_id":"a8744e26ba665a9103f153bd516dd49d99fd0c2f"}]}