)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c5f1f3c53254cc454ac8641450c4351a9925b696","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added to the test coverage."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Minor refactor to failback."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Change-Id: Id0056ec9b9a42005b1f7cb2d8cd5aee208d8015c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"bacf61ea_84c0377e","line":15,"updated":"2016-08-03 04:59:08.000000000","message":"You call a 2000 line patch \"minor\"?:)","commit_id":"fecbf75edcfcf76915221c38d46549e030c63e0f"}],"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"5aec1cdc243b5153b2bec21de00be1ea9bc04a9f","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"        LOG.error(_LE(\u0027Unable to create SC server %s\u0027), servername)"},{"line_number":1278,"context_line":"        return None"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    def _vet_ssn(self, ssn):"},{"line_number":1281,"context_line":"        if ssn \u003d\u003d -1:"},{"line_number":1282,"context_line":"            return self.ssn"},{"line_number":1283,"context_line":"        return ssn"}],"source_content_type":"text/x-python","patch_set":18,"id":"3aaa91ec_cf84dab2","line":1280,"range":{"start_line":1280,"start_character":8,"end_line":1280,"end_character":16},"updated":"2016-06-29 02:16:27.000000000","message":"Could you add a comment as to why this new method is needed and how it is used? Is it needed because of the new live volume support and because of that, the volume may be in one of two SCs?","commit_id":"89af78ade5d78bbfd6f51444039aa963ee53bf99"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"71551b27a1693d5b3aa7193220e7f68f6177fead","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"        LOG.error(_LE(\u0027Unable to create SC server %s\u0027), servername)"},{"line_number":1278,"context_line":"        return None"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    def _vet_ssn(self, ssn):"},{"line_number":1281,"context_line":"        if ssn \u003d\u003d -1:"},{"line_number":1282,"context_line":"            return self.ssn"},{"line_number":1283,"context_line":"        return ssn"}],"source_content_type":"text/x-python","patch_set":18,"id":"3aaa91ec_bf118606","line":1280,"range":{"start_line":1280,"start_character":8,"end_line":1280,"end_character":16},"in_reply_to":"3aaa91ec_cf84dab2","updated":"2016-06-29 21:03:08.000000000","message":"That is exactly why it is needed. If I have to update the patch I\u0027ll add a comment. Otherwise I\u0027ll add the comment in the next patch.","commit_id":"89af78ade5d78bbfd6f51444039aa963ee53bf99"}],"cinder/volume/drivers/dell/dell_storagecenter_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c5f1f3c53254cc454ac8641450c4351a9925b696","unresolved":false,"context_lines":[{"line_number":1456,"context_line":"        model_update \u003d {}"},{"line_number":1457,"context_line":"        if rvol:"},{"line_number":1458,"context_line":"            LOG.info(_LI(\u0027Success failing over volume %s\u0027), id)"},{"line_number":1459,"context_line":"            model_update \u003d {\u0027replication_status\u0027: \u0027failed-over\u0027,"},{"line_number":1460,"context_line":"                            \u0027provider_id\u0027: rvol[\u0027instanceId\u0027]}"},{"line_number":1461,"context_line":"        else:"},{"line_number":1462,"context_line":"            LOG.info(_LI(\u0027Failed failing over volume %s\u0027), id)"}],"source_content_type":"text/x-python","patch_set":27,"id":"bacf61ea_4472bfae","line":1459,"updated":"2016-08-03 04:59:08.000000000","message":"Can you use ReplicationStatus defined below?  You can change it as a follow-up patch.\n\nhttps://github.com/openstack/cinder/blob/master/cinder/objects/fields.py#L67","commit_id":"fecbf75edcfcf76915221c38d46549e030c63e0f"}],"cinder/volume/drivers/dell/dell_storagecenter_fc.py":[{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"5aec1cdc243b5153b2bec21de00be1ea9bc04a9f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                if sclivevolume:"},{"line_number":188,"context_line":"                    lvlun, lvtargets, lvinit_targ_map \u003d ("},{"line_number":189,"context_line":"                        self.terminate_secondary(api, sclivevolume, wwpns))"},{"line_number":190,"context_line":"                    # Add to our"},{"line_number":191,"context_line":"                    if lvlun:"},{"line_number":192,"context_line":"                        targets +\u003d lvtargets"},{"line_number":193,"context_line":"                        init_targ_map.update(lvinit_targ_map)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3aaa91ec_d2f47dd0","line":190,"range":{"start_line":190,"start_character":22,"end_line":190,"end_character":32},"updated":"2016-06-29 02:16:27.000000000","message":"Add to our what ???","commit_id":"89af78ade5d78bbfd6f51444039aa963ee53bf99"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"71551b27a1693d5b3aa7193220e7f68f6177fead","unresolved":false,"context_lines":[{"line_number":187,"context_line":"                if sclivevolume:"},{"line_number":188,"context_line":"                    lvlun, lvtargets, lvinit_targ_map \u003d ("},{"line_number":189,"context_line":"                        self.terminate_secondary(api, sclivevolume, wwpns))"},{"line_number":190,"context_line":"                    # Add to our"},{"line_number":191,"context_line":"                    if lvlun:"},{"line_number":192,"context_line":"                        targets +\u003d lvtargets"},{"line_number":193,"context_line":"                        init_targ_map.update(lvinit_targ_map)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3aaa91ec_ff1e6e0a","line":190,"range":{"start_line":190,"start_character":22,"end_line":190,"end_character":32},"in_reply_to":"3aaa91ec_d2f47dd0","updated":"2016-06-29 21:03:08.000000000","message":"Stuff below.","commit_id":"89af78ade5d78bbfd6f51444039aa963ee53bf99"}]}