)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"6b3f23ba9b82dbe98911c417ee774b2ffb6547e8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1. Change status from \u0027creating\u0027 to \u0027available\u0027 when the volume is created"},{"line_number":10,"context_line":"2. Add a notifier when it fails to create the volume"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: notifiers for create volume"},{"line_number":13,"context_line":"Fixes: bug #1190754"},{"line_number":14,"context_line":"Change-Id: I3a7d118630b32cfa7efb6bc8984418ca9836764a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAPX%2F%2FniE%3D","line":12,"updated":"2013-06-14 08:32:25.000000000","message":"I didn\u0027t find related blueprint for this.  So I suggest remove this line since similar thing was described above in 2.","commit_id":"9392b0a3df05ffd1612c978ef86cd63adaf182fa"}],"cinder/volume/manager.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"00729a967a2668e710f85c1e9e9b1d890854710f","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                self.db.volume_update(context,"},{"line_number":291,"context_line":"                                      volume_ref[\u0027id\u0027], {\u0027status\u0027: \u0027error\u0027})"},{"line_number":292,"context_line":"                LOG.error(_(\"volume %s: create failed\"), volume_ref[\u0027name\u0027])"},{"line_number":293,"context_line":"                volume_ref[\u0027status\u0027] \u003d \u0027error\u0027"},{"line_number":294,"context_line":"                self._notify_about_volume_usage(context, volume_ref,"},{"line_number":295,"context_line":"                                                \"create.end\")"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fnj8%3D","line":293,"updated":"2013-06-14 08:17:00.000000000","message":"It looks \u0027odd\u0027 to update the volume_ref and not update the database, until you\nrealize that the database has already been updated with that value a few lines\nearlier. \n\nI would use the following at line 290, I think it is a bit tidier\n\nvolume_ref \u003d self.db.volume_update(context, volume_ref[\u0027id\u0027],\n                                   {\u0027status\u0027: \u0027error\u0027})\n\nSimilarly for lines 321 and 327 below.","commit_id":"9392b0a3df05ffd1612c978ef86cd63adaf182fa"},{"author":{"_account_id":6499,"name":"yehia-beyh","email":"yehia.beyh@hpe.com","username":"yehia-beyh"},"change_message_id":"1c29faefa6148e5c6d64625d59024b4884ff7015","unresolved":false,"context_lines":[{"line_number":290,"context_line":"                self.db.volume_update(context,"},{"line_number":291,"context_line":"                                      volume_ref[\u0027id\u0027], {\u0027status\u0027: \u0027error\u0027})"},{"line_number":292,"context_line":"                LOG.error(_(\"volume %s: create failed\"), volume_ref[\u0027name\u0027])"},{"line_number":293,"context_line":"                volume_ref[\u0027status\u0027] \u003d \u0027error\u0027"},{"line_number":294,"context_line":"                self._notify_about_volume_usage(context, volume_ref,"},{"line_number":295,"context_line":"                                                \"create.end\")"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fm84%3D","line":293,"in_reply_to":"AAAAPX%2F%2Fnj8%3D","updated":"2013-06-14 13:47:29.000000000","message":"agreed","commit_id":"9392b0a3df05ffd1612c978ef86cd63adaf182fa"}]}