)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"e1707777ec01742d185a4cae94b954d6e7d57505","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     025213a6 (Merge \"Provide Kaminario K2 all-flash array iSCSI driver\")"},{"line_number":2,"context_line":"Author:     Ji-Wei \u003cji.wei3@zte.com.cn\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-06-18 18:15:24 +0800"},{"line_number":4,"context_line":"Commit:     JiWei \u003cji.wei3@zte.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"3aaa91ec_9a86ceb7","line":1,"range":{"start_line":1,"start_character":72,"end_line":1,"end_character":80},"updated":"2016-06-22 08:37:05.000000000","message":"Over the length limit.","commit_id":"c35a968912846976fa21d6b0576af1848c6932fa"}],"cinder/tests/unit/test_v7000_common.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"741dc9f32d2d1a92ec7d59f1754afacb27b85018","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        larger_size_flag \u003d False"},{"line_number":347,"context_line":"        dest_vol \u003d VOLUME.copy()"},{"line_number":348,"context_line":"        if size \u003e VOLUME[\u0027size\u0027]:"},{"line_number":349,"context_line":"            new_size \u003d size"},{"line_number":350,"context_line":"            larger_size_flag \u003d True"},{"line_number":351,"context_line":"        object_id \u003d fake.OBJECT_ID"},{"line_number":352,"context_line":"        vdev_id \u003d 11111"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a9d85d2_6408872e","line":349,"updated":"2016-06-21 07:56:53.000000000","message":"I think we should also set dest_vol[\u0027size\u0027] to new_size for a proper testing.","commit_id":"c35a968912846976fa21d6b0576af1848c6932fa"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"741dc9f32d2d1a92ec7d59f1754afacb27b85018","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            SNAPSHOT[\u0027volume_id\u0027], dest_vdev_id\u003dvdev_id)"},{"line_number":379,"context_line":"        if larger_size_flag:"},{"line_number":380,"context_line":"            self.driver._extend_lun.assert_called_with("},{"line_number":381,"context_line":"                dest_vol, new_size)"},{"line_number":382,"context_line":"        else:"},{"line_number":383,"context_line":"            self.assertFalse(self.driver._extend_lun.called)"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a9d85d2_2724c1ad","line":381,"updated":"2016-06-21 07:56:53.000000000","message":"We should also assert for the modified dest_vol[\u0027size\u0027] (line 374 v7000_common.py) here because it should be set correctly for _extend_lun to work.","commit_id":"c35a968912846976fa21d6b0576af1848c6932fa"}],"cinder/volume/drivers/violin/v7000_common.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"593b3b0a7d1f067c8763b891ba0a61defef8ebda","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        cinder_snapshot_id \u003d snapshot[\u0027id\u0027]"},{"line_number":336,"context_line":"        src_volume_id \u003d snapshot[\u0027volume_id\u0027]"},{"line_number":337,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":338,"context_line":"        src_volume \u003d api.volume_get(ctxt, src_volume_id)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        pool \u003d None"},{"line_number":341,"context_line":"        result \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_05d61dc5","line":338,"updated":"2016-06-20 03:07:53.000000000","message":"I found that thee is a field called volume_size in snapshot:\nhttps://github.com/openstack/cinder/blob/master/cinder/objects/snapshot.py#L51\n\nI think no need to get volume info, just to use this field in Line 375 is enough. Line 336- 338 is not needed.","commit_id":"2ff44326764ba3cc640c1535c4edf4aef8e319f6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"0bf277f00b7f3ff758e0e48b81f732e52875408c","unresolved":false,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # extend the lun if requested size is larger then original snapshot"},{"line_number":372,"context_line":"        if volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":373,"context_line":"            self._extend_lun(volume, volume[\u0027size\u0027])"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def _create_lun_from_lun(self, src_vol, dest_vol):"},{"line_number":376,"context_line":"        \"\"\"Copy the contents of a lun to a new lun (i.e., full clone)."}],"source_content_type":"text/x-python","patch_set":11,"id":"5a9d85d2_81f95ccb","line":373,"updated":"2016-06-20 07:46:38.000000000","message":"This will not work because _extend_lun uses (new_size - volume[\u0027size\u0027]) to determine the delta size, which in this case becomes 0. You may need to save the volume[\u0027size\u0027] as new_size, then temporarily change the volume size to snapshot[\u0027volume_size\u0027] and call self._extend_lun(volume, new_size).","commit_id":"4d73d9a2cbd4fbdadb89e61dcf610c1fca7fb5b3"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"af632725853b417fced494d907bc4cc576a25c97","unresolved":false,"context_lines":[{"line_number":369,"context_line":"            snapshot[\u0027volume_id\u0027], dest_vdev_id\u003dinfo[\u0027virtualDeviceID\u0027])"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        # extend the lun if requested size is larger then original snapshot"},{"line_number":372,"context_line":"        if volume[\u0027size\u0027] \u003e snapshot[\u0027volume_size\u0027]:"},{"line_number":373,"context_line":"            new_size \u003d volume[\u0027size\u0027]"},{"line_number":374,"context_line":"            volume[\u0027size\u0027] \u003d snapshot[\u0027volume_size\u0027]"},{"line_number":375,"context_line":"            self._extend_lun(volume, new_size)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a9d85d2_62cb57a6","line":372,"updated":"2016-06-21 08:16:52.000000000","message":"I prefer you to change the interface of _extend_lun to \n\ndef _extend_lun(self, volume, old_size, new_size)\n\nSame to:\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/emc/scaleio.py#L547","commit_id":"c35a968912846976fa21d6b0576af1848c6932fa"}]}