)]}'
{"cinder/backup/drivers/tsm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f47a1ee749e9a4c8c35592d336dcc5f6132d90e1","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    return True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def _get_st_mode(path):"},{"line_number":191,"context_line":"    return os.stat(path).st_mode"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"def _get_volume_realpath(volume_file, volume_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_7bf22b9c","line":191,"range":{"start_line":190,"start_character":0,"end_line":191,"end_character":32},"updated":"2016-06-21 17:51:33.000000000","message":"-1: I don\u0027t see a good reason to create a helper function just for this since it\u0027s only used once.  If it\u0027s because you are mocking os.stat is giving you trouble, then you could just do `@mock.patch(\u0027cinder.backup.drivers.tsm.os.stat\u0027, fake_stat_...)` instead of mocking it globally.","commit_id":"0e2e9b9f8e415b785f6f37fd91a4865e59d778e7"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"d50ba7decfc251ea109500543b04dad0d0704fea","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    return True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def _get_st_mode(path):"},{"line_number":191,"context_line":"    return os.stat(path).st_mode"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"def _get_volume_realpath(volume_file, volume_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_4995e63e","line":191,"range":{"start_line":190,"start_character":0,"end_line":191,"end_character":32},"in_reply_to":"3aaa91ec_7bf22b9c","updated":"2016-06-21 18:58:34.000000000","message":"Awesome, will do that.","commit_id":"0e2e9b9f8e415b785f6f37fd91a4865e59d778e7"}],"cinder/tests/unit/backup/drivers/test_backup_tsm.py":[{"author":{"_account_id":14907,"name":"Alyson","email":"alyson.rodrigues.rosa@gmail.com","username":"Alyson"},"change_message_id":"24f49b8f2352537727e16bd1e0ccfe9a698ee20c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    def test_backup_invalid_mode(self):"},{"line_number":334,"context_line":"        volume_id \u003d fake.VOLUME_ID"},{"line_number":335,"context_line":"        mode \u003d \u0027illegal\u0027"},{"line_number":336,"context_line":"        self.stubs.Set(os, \u0027stat\u0027, fake_stat_illegal)"},{"line_number":337,"context_line":"        self._create_volume_db_entry(volume_id)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        self._create_backup_db_entry(fake.BACKUP_ID, mode)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_6b1cc2c1","line":336,"range":{"start_line":336,"start_character":0,"end_line":336,"end_character":53},"updated":"2016-06-21 13:22:54.000000000","message":"Change this stub to mock?","commit_id":"8ec7673ee665552453656735ec13905f8f46de83"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"518ec80fc71879ec975d56fd503a9c27d7427490","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    def test_backup_invalid_mode(self):"},{"line_number":334,"context_line":"        volume_id \u003d fake.VOLUME_ID"},{"line_number":335,"context_line":"        mode \u003d \u0027illegal\u0027"},{"line_number":336,"context_line":"        self.stubs.Set(os, \u0027stat\u0027, fake_stat_illegal)"},{"line_number":337,"context_line":"        self._create_volume_db_entry(volume_id)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        self._create_backup_db_entry(fake.BACKUP_ID, mode)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_b88719d6","line":336,"range":{"start_line":336,"start_character":0,"end_line":336,"end_character":53},"in_reply_to":"5a9d85d2_6b1cc2c1","updated":"2016-06-21 15:14:14.000000000","message":"-1: I agree, we should change 4 stub usages.","commit_id":"8ec7673ee665552453656735ec13905f8f46de83"}]}