)]}'
{"cinder/cmd/manage.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"906930035d6bd95e13eaf8f1c49e2d7d9fe9333e","unresolved":false,"context_lines":[{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    @args(\u0027--currenthost\u0027, required\u003dTrue, help\u003d\u0027Existing CG host name\u0027)"},{"line_number":495,"context_line":"    @args(\u0027--newhost\u0027, required\u003dTrue, help\u003d\u0027New CG host name\u0027)"},{"line_number":496,"context_line":"    def update_consisgroup_host(self, currenthost, newhost):"},{"line_number":497,"context_line":"        \"\"\"Modify the host name associated with a Consistency Group."},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        Particularly to recover from cases where one has moved"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_0c5508f9","line":496,"range":{"start_line":496,"start_character":8,"end_line":496,"end_character":31},"updated":"2016-06-24 09:32:52.000000000","message":"-1: I think it would be best to use either \"update_cg_host\" or just \"update_host\"","commit_id":"7ff1823075e7ce134c67a5d543b2c3730179eca4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"906930035d6bd95e13eaf8f1c49e2d7d9fe9333e","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    def update_consisgroup_host(self, currenthost, newhost):"},{"line_number":497,"context_line":"        \"\"\"Modify the host name associated with a Consistency Group."},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"        Particularly to recover from cases where one has moved"},{"line_number":500,"context_line":"        their consistency group node, or modified their backend_name in a"},{"line_number":501,"context_line":"        multi-backend config."},{"line_number":502,"context_line":"        \"\"\""},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ec7ebc68","line":501,"range":{"start_line":499,"start_character":53,"end_line":501,"end_character":29},"updated":"2016-06-24 09:32:52.000000000","message":"nit: I think this can be slightly improved: \"has moved a host from single backend to multi-backend, has changed the host configuration option, or modified the backend_name in a multi-backend config\"?","commit_id":"7ff1823075e7ce134c67a5d543b2c3730179eca4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"906930035d6bd95e13eaf8f1c49e2d7d9fe9333e","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        \"\"\""},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":505,"context_line":"        groups \u003d objects.ConsistencyGroupList.get_all_by_host(ctxt,"},{"line_number":506,"context_line":"                                                              currenthost)"},{"line_number":507,"context_line":"        for gr in groups:"},{"line_number":508,"context_line":"            gr.host \u003d newhost"},{"line_number":509,"context_line":"            gr.save()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_ac95d433","line":506,"range":{"start_line":505,"start_character":0,"end_line":506,"end_character":74},"updated":"2016-06-24 09:32:52.000000000","message":"-1: Please use existing `get_all` method instead of adding a new method:\n\n groups \u003d objects.ConsistencyGroupList.get_all(ctxt, {\u0027host\u0027: currenthost})","commit_id":"7ff1823075e7ce134c67a5d543b2c3730179eca4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"906930035d6bd95e13eaf8f1c49e2d7d9fe9333e","unresolved":false,"context_lines":[{"line_number":512,"context_line":"CATEGORIES \u003d {"},{"line_number":513,"context_line":"    \u0027backup\u0027: BackupCommands,"},{"line_number":514,"context_line":"    \u0027config\u0027: ConfigCommands,"},{"line_number":515,"context_line":"    \u0027consisgroup\u0027: ConsistencyGroupCommands,"},{"line_number":516,"context_line":"    \u0027db\u0027: DbCommands,"},{"line_number":517,"context_line":"    \u0027host\u0027: HostCommands,"},{"line_number":518,"context_line":"    \u0027logs\u0027: GetLogCommands,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_cc2780b4","line":515,"range":{"start_line":515,"start_character":5,"end_line":515,"end_character":16},"updated":"2016-06-24 09:32:52.000000000","message":"-1: We never use this name in cinder, it\u0027s either \"consistencygroup\" or \"cg\", and I prefer the latter.","commit_id":"7ff1823075e7ce134c67a5d543b2c3730179eca4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cdbd540f54a80c7bc07329a76fafc656a9143035","unresolved":false,"context_lines":[{"line_number":513,"context_line":"CATEGORIES \u003d {"},{"line_number":514,"context_line":"    \u0027backup\u0027: BackupCommands,"},{"line_number":515,"context_line":"    \u0027config\u0027: ConfigCommands,"},{"line_number":516,"context_line":"    \u0027consisgroup\u0027: ConsistencyGroupCommands,"},{"line_number":517,"context_line":"    \u0027db\u0027: DbCommands,"},{"line_number":518,"context_line":"    \u0027host\u0027: HostCommands,"},{"line_number":519,"context_line":"    \u0027logs\u0027: GetLogCommands,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_0b3c27be","line":516,"range":{"start_line":516,"start_character":5,"end_line":516,"end_character":16},"updated":"2016-06-28 17:32:12.000000000","message":"-1: I still think this should be \u0027cg\u0027","commit_id":"82fd6803218e7224f815c0c205eed82a9365dcb6"}],"cinder/db/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"906930035d6bd95e13eaf8f1c49e2d7d9fe9333e","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"                                                    sort_dirs\u003dsort_dirs)"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"def consistencygroup_get_all_by_host(context, host):"},{"line_number":1015,"context_line":"    \"\"\"Get a consistencygroup or raise if it does not exist.\"\"\""},{"line_number":1016,"context_line":"    return IMPL.consistencygroup_get_all_by_host(context, host)"},{"line_number":1017,"context_line":""},{"line_number":1018,"context_line":""},{"line_number":1019,"context_line":"def consistencygroup_update(context, consistencygroup_id, values):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4cd0b01f","line":1016,"range":{"start_line":1014,"start_character":0,"end_line":1016,"end_character":63},"updated":"2016-06-24 09:32:52.000000000","message":"-1: This method is unnecessary","commit_id":"7ff1823075e7ce134c67a5d543b2c3730179eca4"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"906930035d6bd95e13eaf8f1c49e2d7d9fe9333e","unresolved":false,"context_lines":[{"line_number":4140,"context_line":"                                     sort_keys, sort_dirs)"},{"line_number":4141,"context_line":""},{"line_number":4142,"context_line":""},{"line_number":4143,"context_line":"@require_admin_context"},{"line_number":4144,"context_line":"def consistencygroup_get_all_by_host(context, host, filters\u003dNone):"},{"line_number":4145,"context_line":"    if host and isinstance(host, six.string_types):"},{"line_number":4146,"context_line":"        session \u003d get_session()"},{"line_number":4147,"context_line":"        with session.begin():"},{"line_number":4148,"context_line":"            host_attr \u003d getattr(models.ConsistencyGroup, \u0027host\u0027)"},{"line_number":4149,"context_line":"            conditions \u003d [host_attr \u003d\u003d host,"},{"line_number":4150,"context_line":"                          host_attr.op(\u0027LIKE\u0027)(host + \u0027#%\u0027)]"},{"line_number":4151,"context_line":"            query \u003d _consistencygroups_get_query(context).filter("},{"line_number":4152,"context_line":"                or_(*conditions))"},{"line_number":4153,"context_line":"            if filters:"},{"line_number":4154,"context_line":"                query \u003d _process_consistencygroups_filters(query, filters)"},{"line_number":4155,"context_line":"                # No CG would match, return empty list"},{"line_number":4156,"context_line":"                if query is None:"},{"line_number":4157,"context_line":"                    return []"},{"line_number":4158,"context_line":"            return query.all()"},{"line_number":4159,"context_line":"    elif not host:"},{"line_number":4160,"context_line":"        return []"},{"line_number":4161,"context_line":""},{"line_number":4162,"context_line":""},{"line_number":4163,"context_line":"@handle_db_data_error"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_0ca98890","line":4160,"range":{"start_line":4143,"start_character":0,"end_line":4160,"end_character":17},"updated":"2016-06-24 09:32:52.000000000","message":"-1: This method is unnecessary","commit_id":"7ff1823075e7ce134c67a5d543b2c3730179eca4"}],"cinder/objects/consistencygroup.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"906930035d6bd95e13eaf8f1c49e2d7d9fe9333e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        return base.obj_make_list(context, cls(context),"},{"line_number":170,"context_line":"                                  objects.ConsistencyGroup,"},{"line_number":171,"context_line":"                                  consistencygroups)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @classmethod"},{"line_number":174,"context_line":"    def get_all_by_host(cls, context, host):"},{"line_number":175,"context_line":"        consistencygroups \u003d db.consistencygroup_get_all_by_host("},{"line_number":176,"context_line":"            context, host)"},{"line_number":177,"context_line":"        return base.obj_make_list(context, cls(context),"},{"line_number":178,"context_line":"                                  objects.ConsistencyGroup,"},{"line_number":179,"context_line":"                                  consistencygroups)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_6c9acc6f","line":179,"range":{"start_line":172,"start_character":0,"end_line":179,"end_character":52},"updated":"2016-06-24 09:32:52.000000000","message":"-1: This method is unnecessary","commit_id":"7ff1823075e7ce134c67a5d543b2c3730179eca4"}],"releasenotes/notes/consistency_group_manage-d30a2ad8917a7a86.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"282f8941cc6347987f04d4ef3f0ee367524623a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added update-host command for consistency groups in cinder-manage."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_67c8d275","line":3,"updated":"2016-08-08 08:51:33.000000000","message":"nit: This could be confusing, since the command is not \"update-host\" but \"update-cg-host\".  It would be good to mention that there is now a new subcommand called \"cg\".","commit_id":"67520e5eb2de79cbb270c7703e715a73c187ec09"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7eaaeed7ce9fc3a3b59d07ce2c001733dfa17016","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added update-host command for consistency groups in cinder-manage."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a89bdaa_50a4b549","line":3,"in_reply_to":"9ad45d7e_67c8d275","updated":"2016-09-13 15:21:47.000000000","message":"I agree, it would be good to show the actual command here.","commit_id":"67520e5eb2de79cbb270c7703e715a73c187ec09"}]}