)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e18840827435dc76fc16fb0a8f03bc44dc0062fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jack Lu \u003crenxlu@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-21 14:45:33 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes bug/1594294;"},{"line_number":8,"context_line":"Elevate to admin privilege when a tenant create volume, then"},{"line_number":9,"context_line":"VolumeNumberWeigher has the privilege to get volume count of each host;"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_d38ea326","line":7,"updated":"2016-06-21 18:27:26.000000000","message":"Needs to be reformatted to follow commit message guidelines mentioned.","commit_id":"b155b64897882508008375653d269a0cd540d776"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"e615b1e276d9988ab0e04178f72a54994552e297","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027context.elevated()\u0027 to VolumeNumberWeigher"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently tanent would fail to create volume, if cinder uses"},{"line_number":10,"context_line":"VolumeNumberWeigher."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This will elevate tenant to admin privilege, then VolumeNumberWeigher"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_855f9471","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":16},"updated":"2016-06-22 08:00:01.000000000","message":"tanent/tenant","commit_id":"1f77fddf084428a882e7b6019dac978bf4262b11"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"9704a63f2e6d3f0b051a246746f7a34ede5709e0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VolumeNumberWeigher."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This will elevate tenant to admin privilege, then VolumeNumberWeigher"},{"line_number":13,"context_line":"has the privilege to get volume count of each hosts. This help tenant"},{"line_number":14,"context_line":"can create volume successfully."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1aa0e8ad74d37389ad1feecef113ab8e260dfd0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3aaa91ec_84549e21","line":13,"range":{"start_line":13,"start_character":58,"end_line":13,"end_character":62},"updated":"2016-06-22 14:51:24.000000000","message":"nit: s/help/helps/","commit_id":"490db8d2d000d89277aeb6d531a93b9248c9c50a"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"7bd1404bac2bc484af1b324ee622156d65ba72b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jack Lu \u003crenxlu@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-23 08:55:18 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027context.elevated()\u0027 to VolumeNumberWeigher"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently tenant would fail to create volume, if cinder uses"},{"line_number":10,"context_line":"VolumeNumberWeigher."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_4c276212","line":7,"updated":"2016-06-23 02:18:17.000000000","message":"Better be: use elevated context to query DB in VolumeNumberWeigher","commit_id":"69831484ca558b315fc013f8b76efc21be8d4ea4"},{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"7568530bca4d692b8900b4283000e2f3c23daf20","unresolved":false,"context_lines":[{"line_number":10,"context_line":"VolumeNumberWeigher."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This will elevate tenant to admin privilege, then VolumeNumberWeigher"},{"line_number":13,"context_line":"has the privilege to get volume count of each hosts. This helps tenant"},{"line_number":14,"context_line":"can create volume successfully."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1aa0e8ad74d37389ad1feecef113ab8e260dfd0f"},{"line_number":17,"context_line":"Closes-Bug: #1594294"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_88649322","line":14,"range":{"start_line":13,"start_character":53,"end_line":14,"end_character":31},"updated":"2016-06-23 04:16:59.000000000","message":"This can help tenant create volume successfully.","commit_id":"69831484ca558b315fc013f8b76efc21be8d4ea4"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"7bd1404bac2bc484af1b324ee622156d65ba72b3","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This will elevate tenant to admin privilege, then VolumeNumberWeigher"},{"line_number":13,"context_line":"has the privilege to get volume count of each hosts. This helps tenant"},{"line_number":14,"context_line":"can create volume successfully."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1aa0e8ad74d37389ad1feecef113ab8e260dfd0f"},{"line_number":17,"context_line":"Closes-Bug: #1594294"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_2c22d601","line":14,"updated":"2016-06-23 02:18:17.000000000","message":"You can remove \"This helps tenant can create volume successfully\", it\u0027s redundent and has grammar error.","commit_id":"69831484ca558b315fc013f8b76efc21be8d4ea4"}],"cinder/scheduler/weights/volume_number.py":[{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"c6159d44f22da6f8984cc779ec08b46a9ce9d280","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3aaa91ec_f20052ad","updated":"2016-06-30 08:22:08.000000000","message":"LGTM","commit_id":"afc9cb9b2d75b58d869e10abd17fe063f210e9b5"}],"cinder/tests/unit/scheduler/test_volume_number_weigher.py":[{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"05e681b5c9823ce223b034b5a362d697300a0682","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                             utils.extract_host(weighed_host.obj.host))"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_volume_number_weight_with_tenant(self):"},{"line_number":109,"context_line":"       self.context \u003d context.RequestContext(user_id\u003dNone,"},{"line_number":110,"context_line":"                                             project_id\u003dNone,"},{"line_number":111,"context_line":"                                             is_admin\u003dFalse,"},{"line_number":112,"context_line":"                                             read_deleted\u003d\"no\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_3f098f96","line":109,"updated":"2016-06-22 07:18:05.000000000","message":"E111 indentation is not a multiple of four","commit_id":"1f77fddf084428a882e7b6019dac978bf4262b11"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"05e681b5c9823ce223b034b5a362d697300a0682","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                             is_admin\u003dFalse,"},{"line_number":112,"context_line":"                                             read_deleted\u003d\"no\","},{"line_number":113,"context_line":"                                             overwrite\u003dFalse)"},{"line_number":114,"context_line":"       self.test_volume_number_weight_multiplier2()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_7f3af737","line":114,"updated":"2016-06-22 07:18:05.000000000","message":"E111 indentation is not a multiple of four","commit_id":"1f77fddf084428a882e7b6019dac978bf4262b11"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"9704a63f2e6d3f0b051a246746f7a34ede5709e0","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_volume_number_weight_with_tenant(self):"},{"line_number":109,"context_line":"        self.context \u003d context.RequestContext(user_id\u003dNone,"},{"line_number":110,"context_line":"                                              project_id\u003dNone,"},{"line_number":111,"context_line":"                                              is_admin\u003dFalse,"},{"line_number":112,"context_line":"                                              read_deleted\u003d\"no\","},{"line_number":113,"context_line":"                                              overwrite\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_e7dda415","line":110,"range":{"start_line":110,"start_character":57,"end_line":110,"end_character":61},"updated":"2016-06-22 14:51:24.000000000","message":"This test case is for tenant user. So the project_id should be set instead of None at least. I\u0027d recommend to set dummy values for both user_id and project_id using tests/unit/fake_constants.py","commit_id":"490db8d2d000d89277aeb6d531a93b9248c9c50a"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"7bd1404bac2bc484af1b324ee622156d65ba72b3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_8c214afe","line":52,"updated":"2016-06-23 02:18:17.000000000","message":"This is not right.  self.context should be non admin context.","commit_id":"69831484ca558b315fc013f8b76efc21be8d4ea4"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"991e670034937ed561a275f54765c386692d2f7a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from cinder import test"},{"line_number":26,"context_line":"from cinder.tests.unit.scheduler import fakes"},{"line_number":27,"context_line":"from cinder.volume import utils"},{"line_number":28,"context_line":"from cinder.tests.unit import fake_constants as fake"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_6df1006b","line":28,"range":{"start_line":28,"start_character":30,"end_line":28,"end_character":44},"updated":"2016-06-25 05:23:49.000000000","message":"Please remove pep8 error.\n\n/cinder/tests/unit/scheduler/test_volume_number_weigher.py:28:1: H306  imports not in alphabetical order (cinder.volume.utils, cinder.tests.unit.fake_constants)","commit_id":"369a30a900dd0cf59f3cce6fb2bf31960f232d8d"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"10a81ff9aec2af3fcd272205718dab7981dc3433","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_2596443f","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":30},"updated":"2016-06-23 15:16:10.000000000","message":"Please use user context here instead of using admin context based on Huang\u0027s comment.\n\nself.context \u003d context.RequestContext(user_id\u003dfake.USER_ID,\n                                      project_id\u003dfake.PROJECT_ID,\n                                      is_admin\u003dFalse,\n                                      read_deleted\u003d\"no\",\n                                      overwrite\u003dFalse)","commit_id":"369a30a900dd0cf59f3cce6fb2bf31960f232d8d"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"35bbc19f53d3a589e892e85832b0cc45a455d42d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_b0985b6b","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":30},"in_reply_to":"3aaa91ec_0d531c3a","updated":"2016-06-25 06:39:43.000000000","message":"I think you are right.","commit_id":"369a30a900dd0cf59f3cce6fb2bf31960f232d8d"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"9dce1936d78dc01fb3c551f0fd0bfe33b22d7d3e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_29a9e190","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":30},"in_reply_to":"3aaa91ec_1f57fa58","updated":"2016-06-24 04:04:33.000000000","message":"I think we don\u0027t notice this bug for long time because the test cases are considered only for admin user.\nBut main operator of volume creation is tenant user. Test cases are designed for tenant user and we should confirm wether tenant user can create volume using this scheduler.\n\nFor multiplier1\u0026multiplier2 test cases, you can escalate context before required operation.","commit_id":"369a30a900dd0cf59f3cce6fb2bf31960f232d8d"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"877b0f0c1d196aa697ce40a392f6f78b1c1891a7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_1f57fa58","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":30},"in_reply_to":"3aaa91ec_2596443f","updated":"2016-06-24 01:00:28.000000000","message":"As you know, test_volume_number_weight_multiplier1 \u0026 test_volume_number_weight_multiplier2 need admin context, I don\u0027t want to change it.","commit_id":"369a30a900dd0cf59f3cce6fb2bf31960f232d8d"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"ba53637761e8895723eef8d8d1b4e7e8f51197fa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_560e7d3b","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":30},"in_reply_to":"3aaa91ec_29a9e190","updated":"2016-06-24 09:01:08.000000000","message":"Yes, after change to tenant context, it would be OK for multiplier1 and multiplier2 , but there is another issue for this test case. The issue is VolumeNumberWeigherTestCase will not cover admin context. So I will create another test case, it would be better. Do you think so?","commit_id":"369a30a900dd0cf59f3cce6fb2bf31960f232d8d"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"991e670034937ed561a275f54765c386692d2f7a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_0d531c3a","line":52,"range":{"start_line":52,"start_character":23,"end_line":52,"end_character":30},"in_reply_to":"3aaa91ec_560e7d3b","updated":"2016-06-25 05:23:49.000000000","message":"In my opinion, test cases for Admin user are not meaningful for VolumeNumberWeigher. Also if we implement tenant user\u0027s test cases, it means that these test cases cover admin test cases too because admin can do every operations.\n\nIf these test cases are for admin only APIs, I agree it is enough to cover only admin context, but this time, target is different.","commit_id":"369a30a900dd0cf59f3cce6fb2bf31960f232d8d"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"a11f7d17b2bb06a311328f9b398f99b0b3cac9ed","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from cinder import test"},{"line_number":26,"context_line":"from cinder.tests.unit.scheduler import fakes"},{"line_number":27,"context_line":"from cinder.volume import utils"},{"line_number":28,"context_line":"from cinder.tests.unit import fake_constants as fake"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_01d91c57","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":52},"updated":"2016-06-26 02:14:42.000000000","message":"Move Line 28 to Line 26 I think","commit_id":"4a787176e9b92796dc3a6479ccd4c71ee6445ada"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3e535157de210d8c92229f1a425255dcc4c97316","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from cinder import test"},{"line_number":26,"context_line":"from cinder.tests.unit.scheduler import fakes"},{"line_number":27,"context_line":"from cinder.volume import utils"},{"line_number":28,"context_line":"from cinder.tests.unit import fake_constants as fake"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_8ea5a905","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":52},"in_reply_to":"3aaa91ec_01d91c57","updated":"2016-06-29 08:41:57.000000000","message":"-1: I agree, this goes between L25 and L26.","commit_id":"4a787176e9b92796dc3a6479ccd4c71ee6445ada"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"6031ba706022e059af36a30461be1151b3d66f24","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from cinder import test"},{"line_number":26,"context_line":"from cinder.tests.unit.scheduler import fakes"},{"line_number":27,"context_line":"from cinder.volume import utils"},{"line_number":28,"context_line":"from cinder.tests.unit import fake_constants as fake"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"CONF \u003d cfg.CONF"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_1ab261e5","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":52},"in_reply_to":"3aaa91ec_01d91c57","updated":"2016-06-30 01:38:51.000000000","message":"Yes, patch 8 does this.","commit_id":"4a787176e9b92796dc3a6479ccd4c71ee6445ada"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3e535157de210d8c92229f1a425255dcc4c97316","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_6ef67dfa","line":52,"updated":"2016-06-29 08:41:57.000000000","message":"-1: As discussed in patch 5 I think that tests should be using non admin context by default, although you could add an additional one (if you really want to) with admin context in the same fashion as you are doing test on L109 now.  And this should be changed in this patch and not in another patch.","commit_id":"4a787176e9b92796dc3a6479ccd4c71ee6445ada"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"6031ba706022e059af36a30461be1151b3d66f24","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_dae299d4","line":52,"in_reply_to":"3aaa91ec_3563191c","updated":"2016-06-30 01:38:51.000000000","message":"Yes, thank you Gorka. Patch 8 do the right thing.","commit_id":"4a787176e9b92796dc3a6479ccd4c71ee6445ada"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"506717e49de7a605ae18db2b662b8d48e6ff0a2b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_3563191c","line":52,"in_reply_to":"3aaa91ec_6eeb1d79","updated":"2016-06-29 11:11:42.000000000","message":"All you have to do is make sure that you just have 1 patch on top of master HEAD and that you preserve the Change-Id that you have in this patch.\n\nSo what you can do is do a `git rebase -i HEAD~2` when you are in the other patch and then just change in the line corresponding to the other patch the word \"pick\" with \"f\".\n\nAnother way is you just drop/delete the other patch and you modify this patch, to do that you just make the changes to the code, then do `git add cinder; git commit --amend --no-edit` so that the new changes are merged into the previous patch.\n\nIs that what you were asking?","commit_id":"4a787176e9b92796dc3a6479ccd4c71ee6445ada"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"7adb11692124b4382b35403dd75a9789249153f5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumeNumberWeigherTestCase(test.TestCase):"},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":53,"context_line":"        self.host_manager \u003d fakes.FakeHostManager()"},{"line_number":54,"context_line":"        self.weight_handler \u003d weights.HostWeightHandler("},{"line_number":55,"context_line":"            \u0027cinder.scheduler.weights\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_6eeb1d79","line":52,"in_reply_to":"3aaa91ec_6ef67dfa","updated":"2016-06-29 09:06:25.000000000","message":"Yes, I agree with you and Mitsuhiro. And I have tried to use non admin context here, and tried to remove test_volume_number_weight_with_tenant test, but it was failed due to merge conflicts. So I committed another patch, maybe it was not the best way. Do you know how to fix this conflicts in this thread? I am not familiar with Gerrit, sorry for that.","commit_id":"4a787176e9b92796dc3a6479ccd4c71ee6445ada"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"5d5170fab2a8d8d8c9a62624df790d806b501c9a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.RequestContext(user_id\u003dfake_constants.USER_ID,"},{"line_number":53,"context_line":"                                              project_id\u003dfake_constants.PROJECT_ID,"},{"line_number":54,"context_line":"                                              is_admin\u003dFalse,"},{"line_number":55,"context_line":"                                              read_deleted\u003d\"no\","},{"line_number":56,"context_line":"                                              overwrite\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_00fb0f7c","line":53,"updated":"2016-06-30 05:56:24.000000000","message":"Hi Jack, line too long (83 \u003e 79 characters)","commit_id":"c0b4783c6073c201a41cca5901614dbe97034b0e"},{"author":{"_account_id":21334,"name":"Jack Lu","email":"renxlu@cisco.com","username":"renxlu"},"change_message_id":"03211840dabd4a3445b83aaeb713d94c4f5942e1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(VolumeNumberWeigherTestCase, self).setUp()"},{"line_number":52,"context_line":"        self.context \u003d context.RequestContext(user_id\u003dfake_constants.USER_ID,"},{"line_number":53,"context_line":"                                              project_id\u003dfake_constants.PROJECT_ID,"},{"line_number":54,"context_line":"                                              is_admin\u003dFalse,"},{"line_number":55,"context_line":"                                              read_deleted\u003d\"no\","},{"line_number":56,"context_line":"                                              overwrite\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_fb21549f","line":53,"in_reply_to":"3aaa91ec_00fb0f7c","updated":"2016-06-30 06:09:25.000000000","message":"Thanks Min, Patch set 9 has fixed this.","commit_id":"c0b4783c6073c201a41cca5901614dbe97034b0e"},{"author":{"_account_id":21113,"name":"Min Sun","email":"minsu@cisco.com","username":"MinSun"},"change_message_id":"5d5170fab2a8d8d8c9a62624df790d806b501c9a","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.assertEqual(1.0, weighed_host.weight)"},{"line_number":110,"context_line":"            self.assertEqual(\u0027host5\u0027,"},{"line_number":111,"context_line":"                             utils.extract_host(weighed_host.obj.host))"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_c02bc7e9","line":112,"updated":"2016-06-30 05:56:24.000000000","message":"blank line at end of file","commit_id":"c0b4783c6073c201a41cca5901614dbe97034b0e"}]}