)]}'
{"cinder/tests/unit/volume/test_manage_volume.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f05f7ca9acfa58ebb003efafb5782396f82b973","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class ManageVolumeTestCase(test_volume.BaseVolumeTestCase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(ManagerTestCase, self).setUp()"},{"line_number":36,"context_line":"        self.context \u003d context.RequestContext(fake.USER_ID, fake.PROJECT_ID,"},{"line_number":37,"context_line":"                                              True)"},{"line_number":38,"context_line":"        self.manager \u003d manager.VolumeManager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_308cb47e","line":35,"updated":"2016-07-06 08:27:26.000000000","message":"-1: This should be ManageVolumeTestCase","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd7d8e995ab118e13701230ccec62bef96292353","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class ManageVolumeTestCase(test_volume.BaseVolumeTestCase):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(ManagerTestCase, self).setUp()"},{"line_number":36,"context_line":"        self.context \u003d context.RequestContext(fake.USER_ID, fake.PROJECT_ID,"},{"line_number":37,"context_line":"                                              True)"},{"line_number":38,"context_line":"        self.manager \u003d manager.VolumeManager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_25162b4c","line":35,"in_reply_to":"1aa78d24_308cb47e","updated":"2016-07-06 11:50:17.000000000","message":"Done","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f05f7ca9acfa58ebb003efafb5782396f82b973","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.manager \u003d manager.VolumeManager()"},{"line_number":39,"context_line":"        self.manager.stats \u003d {\u0027allocated_capacity_gb\u0027: 0, \u0027pools\u0027: {}}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _stub_volume_reference(volume_reference_id, **kwargs):"},{"line_number":42,"context_line":"        volume_reference \u003d {"},{"line_number":43,"context_line":"            \u0027id\u0027: volume_reference_id,"},{"line_number":44,"context_line":"            \u0027size\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_d080d0f9","line":41,"updated":"2016-07-06 08:27:26.000000000","message":"-1:\n\n @staticmethod\n def _stub_volume_reference(volume_reference_id, **kwargs):","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd7d8e995ab118e13701230ccec62bef96292353","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.manager \u003d manager.VolumeManager()"},{"line_number":39,"context_line":"        self.manager.stats \u003d {\u0027allocated_capacity_gb\u0027: 0, \u0027pools\u0027: {}}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _stub_volume_reference(volume_reference_id, **kwargs):"},{"line_number":42,"context_line":"        volume_reference \u003d {"},{"line_number":43,"context_line":"            \u0027id\u0027: volume_reference_id,"},{"line_number":44,"context_line":"            \u0027size\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_a52e9b40","line":41,"in_reply_to":"1aa78d24_d080d0f9","updated":"2016-07-06 11:50:17.000000000","message":"Done","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f05f7ca9acfa58ebb003efafb5782396f82b973","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        volume_reference \u003d {"},{"line_number":43,"context_line":"            \u0027id\u0027: volume_reference_id,"},{"line_number":44,"context_line":"            \u0027size\u0027: 1,"},{"line_number":45,"context_line":"            \u0027host\u0027: \u0027%(host)s%(delimiter)s%(pool)s\u0027 % {"},{"line_number":46,"context_line":"                                                       \u0027host\u0027: FAKE_HOST,"},{"line_number":47,"context_line":"                                                       \u0027delimiter\u0027: \u0027#\u0027,"},{"line_number":48,"context_line":"                                                       \u0027pool\u0027: FAKE_HOST_POOL"},{"line_number":49,"context_line":"                                                       }"},{"line_number":50,"context_line":"                            }"},{"line_number":51,"context_line":"        volume_reference.update(kwargs)"},{"line_number":52,"context_line":"        return volume_reference"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_10d1b823","line":50,"range":{"start_line":45,"start_character":54,"end_line":50,"end_character":29},"updated":"2016-07-06 08:27:26.000000000","message":"-1: Wrong indentation","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd7d8e995ab118e13701230ccec62bef96292353","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        volume_reference \u003d {"},{"line_number":43,"context_line":"            \u0027id\u0027: volume_reference_id,"},{"line_number":44,"context_line":"            \u0027size\u0027: 1,"},{"line_number":45,"context_line":"            \u0027host\u0027: \u0027%(host)s%(delimiter)s%(pool)s\u0027 % {"},{"line_number":46,"context_line":"                                                       \u0027host\u0027: FAKE_HOST,"},{"line_number":47,"context_line":"                                                       \u0027delimiter\u0027: \u0027#\u0027,"},{"line_number":48,"context_line":"                                                       \u0027pool\u0027: FAKE_HOST_POOL"},{"line_number":49,"context_line":"                                                       }"},{"line_number":50,"context_line":"                            }"},{"line_number":51,"context_line":"        volume_reference.update(kwargs)"},{"line_number":52,"context_line":"        return volume_reference"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_a58a1b19","line":50,"range":{"start_line":45,"start_character":54,"end_line":50,"end_character":29},"in_reply_to":"1aa78d24_10d1b823","updated":"2016-07-06 11:50:17.000000000","message":"Done","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f05f7ca9acfa58ebb003efafb5782396f82b973","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        volume_reference.update(kwargs)"},{"line_number":52,"context_line":"        return volume_reference"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _stub_volume_reference_get():"},{"line_number":55,"context_line":"        return self._stub_volume_reference(fake.VOLUME_ID)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_manage_existing(self):"},{"line_number":58,"context_line":"        volume \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_309b1474","line":55,"range":{"start_line":54,"start_character":4,"end_line":55,"end_character":58},"updated":"2016-07-06 08:27:26.000000000","message":"-1:\n\n @classmethod\n def _stub_volume_reference_get(cls):\n     return cls._stub_volume_reference(fake.VOLUME_ID)","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd7d8e995ab118e13701230ccec62bef96292353","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        volume_reference.update(kwargs)"},{"line_number":52,"context_line":"        return volume_reference"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _stub_volume_reference_get():"},{"line_number":55,"context_line":"        return self._stub_volume_reference(fake.VOLUME_ID)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_manage_existing(self):"},{"line_number":58,"context_line":"        volume \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_05ca0f4e","line":55,"range":{"start_line":54,"start_character":4,"end_line":55,"end_character":58},"in_reply_to":"1aa78d24_309b1474","updated":"2016-07-06 11:50:17.000000000","message":"Done","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f05f7ca9acfa58ebb003efafb5782396f82b973","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \u0027name\u0027: fake.VOLUME_NAME,"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"        volume_object \u003d fake_volume.fake_volume_obj(self.context, **volume)"},{"line_number":90,"context_line":"        volume_reference \u003d stub_volume_reference_get()"},{"line_number":91,"context_line":"        mock_object_volume \u003d self.mock_object(objects.Volume, \u0027get_by_id\u0027)"},{"line_number":92,"context_line":"        mock_run_flow_engine \u003d self.mock_object("},{"line_number":93,"context_line":"            self.manager, \u0027_run_manage_existing_flow_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_104ed83a","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":52},"updated":"2016-07-06 08:27:26.000000000","message":"-1:\n\n self._stub_volume_reference_get()","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd7d8e995ab118e13701230ccec62bef96292353","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            \u0027name\u0027: fake.VOLUME_NAME,"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"        volume_object \u003d fake_volume.fake_volume_obj(self.context, **volume)"},{"line_number":90,"context_line":"        volume_reference \u003d stub_volume_reference_get()"},{"line_number":91,"context_line":"        mock_object_volume \u003d self.mock_object(objects.Volume, \u0027get_by_id\u0027)"},{"line_number":92,"context_line":"        mock_run_flow_engine \u003d self.mock_object("},{"line_number":93,"context_line":"            self.manager, \u0027_run_manage_existing_flow_engine\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_45eed7b4","line":90,"range":{"start_line":90,"start_character":27,"end_line":90,"end_character":52},"in_reply_to":"1aa78d24_104ed83a","updated":"2016-07-06 11:50:17.000000000","message":"Done","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f05f7ca9acfa58ebb003efafb5782396f82b973","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_run_manage_existing_flow_engine(self):"},{"line_number":110,"context_line":"        mock_volume \u003d mock.Mock()"},{"line_number":111,"context_line":"        volume_reference \u003d stub_volume_reference_get()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        mock_flow_engine \u003d mock.Mock()"},{"line_number":114,"context_line":"        mock_flow_engine_run \u003d self.mock_object(mock_flow_engine, \u0027run\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_b0e0a4fb","line":111,"updated":"2016-07-06 08:27:26.000000000","message":"-1:\n\n volume_reference \u003d self._stub_volume_reference_get()","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd7d8e995ab118e13701230ccec62bef96292353","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_run_manage_existing_flow_engine(self):"},{"line_number":110,"context_line":"        mock_volume \u003d mock.Mock()"},{"line_number":111,"context_line":"        volume_reference \u003d stub_volume_reference_get()"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        mock_flow_engine \u003d mock.Mock()"},{"line_number":114,"context_line":"        mock_flow_engine_run \u003d self.mock_object(mock_flow_engine, \u0027run\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_c5380740","line":111,"in_reply_to":"1aa78d24_b0e0a4fb","updated":"2016-07-06 11:50:17.000000000","message":"Done","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f05f7ca9acfa58ebb003efafb5782396f82b973","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_update_stats_for_managed(self):"},{"line_number":158,"context_line":"        self.manager._update_stats_for_managed("},{"line_number":159,"context_line":"            stub_volume_reference_get())"},{"line_number":160,"context_line":"        backend_stats \u003d self.manager.stats[\u0027pools\u0027][FAKE_HOST_POOL]"},{"line_number":161,"context_line":"        self.assertEqual("},{"line_number":162,"context_line":"            1, backend_stats[\u0027allocated_capacity_gb\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_500220b5","line":159,"updated":"2016-07-06 08:27:26.000000000","message":"-1:\n\n  self._stub_volume_reference_get())","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd7d8e995ab118e13701230ccec62bef96292353","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_update_stats_for_managed(self):"},{"line_number":158,"context_line":"        self.manager._update_stats_for_managed("},{"line_number":159,"context_line":"            stub_volume_reference_get())"},{"line_number":160,"context_line":"        backend_stats \u003d self.manager.stats[\u0027pools\u0027][FAKE_HOST_POOL]"},{"line_number":161,"context_line":"        self.assertEqual("},{"line_number":162,"context_line":"            1, backend_stats[\u0027allocated_capacity_gb\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_053faf24","line":159,"in_reply_to":"1aa78d24_500220b5","updated":"2016-07-06 11:50:17.000000000","message":"Done","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f05f7ca9acfa58ebb003efafb5782396f82b973","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.assertEqual(1, backend_stats[\u0027allocated_capacity_gb\u0027])"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test_update_stats_for_managed_default_backend(self):"},{"line_number":181,"context_line":"        volume_reference \u003d stub_volume_reference("},{"line_number":182,"context_line":"            fake.VOLUME_ID, host\u003dFAKE_HOST)"},{"line_number":183,"context_line":"        mock_safe_get \u003d self.mock_object("},{"line_number":184,"context_line":"            self.manager.driver.configuration, \u0027safe_get\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_b029c439","line":181,"updated":"2016-07-06 08:27:26.000000000","message":"-1:\n\n   self._stub_volume_reference(","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"cd7d8e995ab118e13701230ccec62bef96292353","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.assertEqual(1, backend_stats[\u0027allocated_capacity_gb\u0027])"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test_update_stats_for_managed_default_backend(self):"},{"line_number":181,"context_line":"        volume_reference \u003d stub_volume_reference("},{"line_number":182,"context_line":"            fake.VOLUME_ID, host\u003dFAKE_HOST)"},{"line_number":183,"context_line":"        mock_safe_get \u003d self.mock_object("},{"line_number":184,"context_line":"            self.manager.driver.configuration, \u0027safe_get\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_654833cd","line":181,"in_reply_to":"1aa78d24_b029c439","updated":"2016-07-06 11:50:17.000000000","message":"Done","commit_id":"457c952d7a82fa43c5351e7f228f6c79788847e4"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"dd31d4feb404e8ea9241f965f6a311508a2a2d9d","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        self.assertRaises("},{"line_number":197,"context_line":"            KeyError, self.manager._update_stats_for_managed,"},{"line_number":198,"context_line":"            stub_volume_reference_get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_7c18bc75","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":39},"updated":"2016-07-06 15:39:42.000000000","message":"There should be \"self._stub_volume_reference_get()\".","commit_id":"1929cf3716223b3e7b46046fce2034025c15b895"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d5819510135b8e1841b99bdd5a99586beb786074","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        self.assertRaises("},{"line_number":197,"context_line":"            KeyError, self.manager._update_stats_for_managed,"},{"line_number":198,"context_line":"            stub_volume_reference_get())"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_50c837a8","line":198,"range":{"start_line":198,"start_character":12,"end_line":198,"end_character":39},"in_reply_to":"1aa78d24_7c18bc75","updated":"2016-07-06 19:40:09.000000000","message":"-1: You are right, I missed that in my previous review.","commit_id":"1929cf3716223b3e7b46046fce2034025c15b895"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4fd0eb74adf161969612b621df29e3f77803ecb5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinder.tests.unit import fake_constants as fake"},{"line_number":18,"context_line":"from cinder.tests.unit import fake_volume"},{"line_number":19,"context_line":"from cinder.tests.unit import test_volume"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from cinder import context"},{"line_number":22,"context_line":"from cinder import exception"},{"line_number":23,"context_line":"from cinder import objects"},{"line_number":24,"context_line":"from cinder.volume.flows.manager import manage_existing"},{"line_number":25,"context_line":"from cinder.volume import manager"},{"line_number":26,"context_line":"from cinder.volume import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"FAKE_HOST_POOL \u003d \u0027volPool\u0027"},{"line_number":29,"context_line":"FAKE_HOST \u003d \u0027hostname@backend\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_cb3d83c5","line":26,"range":{"start_line":17,"start_character":0,"end_line":26,"end_character":31},"updated":"2016-07-07 08:25:56.000000000","message":"Not a big deal, but I think these two sections should be combined.","commit_id":"e2a80eaa92928d625f4b8c35229822771e6e8323"}],"cinder/tests/unit/volume/test_manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import mock"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinder.tests.unit import fake_constants as fake"},{"line_number":18,"context_line":"from cinder.tests.unit.test_volume import BaseVolumeTestCase"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cinder import context"},{"line_number":21,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c1079f7f","line":18,"updated":"2016-07-05 10:15:29.000000000","message":"-1: Don\u0027t import the class directly","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"FAKE_HOST \u003d \u0027hostname@backend\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def stub_volume_reference(volume_reference_id, **kwargs):"},{"line_number":32,"context_line":"    volume_reference \u003d {"},{"line_number":33,"context_line":"        \u0027id\u0027: volume_reference_id,"},{"line_number":34,"context_line":"        \u0027size\u0027: 1,"},{"line_number":35,"context_line":"        \u0027host\u0027: \u0027%(host)s%(delimiter)s%(pool)s\u0027 % {"},{"line_number":36,"context_line":"            \u0027host\u0027: FAKE_HOST,"},{"line_number":37,"context_line":"            \u0027delimiter\u0027: \u0027#\u0027,"},{"line_number":38,"context_line":"            \u0027pool\u0027: FAKE_HOST_POOL"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    volume_reference.update(kwargs)"},{"line_number":43,"context_line":"    return volume_reference"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def stub_volume_reference_get():"},{"line_number":47,"context_line":"    return stub_volume_reference(fake.VOLUME_ID)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class ManagerTestCase(BaseVolumeTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_8102b709","line":47,"range":{"start_line":31,"start_character":0,"end_line":47,"end_character":48},"updated":"2016-07-05 10:15:29.000000000","message":"-1: Why are this outside the test Class?  They should be in there as static methods.","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":28,"context_line":"FAKE_HOST \u003d \u0027hostname@backend\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def stub_volume_reference(volume_reference_id, **kwargs):"},{"line_number":32,"context_line":"    volume_reference \u003d {"},{"line_number":33,"context_line":"        \u0027id\u0027: volume_reference_id,"},{"line_number":34,"context_line":"        \u0027size\u0027: 1,"},{"line_number":35,"context_line":"        \u0027host\u0027: \u0027%(host)s%(delimiter)s%(pool)s\u0027 % {"},{"line_number":36,"context_line":"            \u0027host\u0027: FAKE_HOST,"},{"line_number":37,"context_line":"            \u0027delimiter\u0027: \u0027#\u0027,"},{"line_number":38,"context_line":"            \u0027pool\u0027: FAKE_HOST_POOL"},{"line_number":39,"context_line":"        }"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    volume_reference.update(kwargs)"},{"line_number":43,"context_line":"    return volume_reference"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def stub_volume_reference_get():"},{"line_number":47,"context_line":"    return stub_volume_reference(fake.VOLUME_ID)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class ManagerTestCase(BaseVolumeTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_dd274ec8","line":47,"range":{"start_line":31,"start_character":0,"end_line":47,"end_character":48},"in_reply_to":"1aa78d24_8102b709","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(ManagerTestCase, self).setUp()"},{"line_number":54,"context_line":"        self.ctxt \u003d context.RequestContext(fake.USER_ID, fake.PROJECT_ID, True)"},{"line_number":55,"context_line":"        self.manager \u003d manager.VolumeManager()"},{"line_number":56,"context_line":"        self.manager.stats \u003d {\u0027allocated_capacity_gb\u0027: 0, \u0027pools\u0027: {}}"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c12e7ff9","line":54,"range":{"start_line":54,"start_character":13,"end_line":54,"end_character":17},"updated":"2016-07-05 10:15:29.000000000","message":"nit: Probably better to reflect that this is a user context to differentiate it from the admin context (`self.context`)","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def setUp(self):"},{"line_number":53,"context_line":"        super(ManagerTestCase, self).setUp()"},{"line_number":54,"context_line":"        self.ctxt \u003d context.RequestContext(fake.USER_ID, fake.PROJECT_ID, True)"},{"line_number":55,"context_line":"        self.manager \u003d manager.VolumeManager()"},{"line_number":56,"context_line":"        self.manager.stats \u003d {\u0027allocated_capacity_gb\u0027: 0, \u0027pools\u0027: {}}"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_b807f016","line":54,"range":{"start_line":54,"start_character":13,"end_line":54,"end_character":17},"in_reply_to":"1aa78d24_c12e7ff9","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self.manager, \u0027_update_stats_for_managed\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        result \u003d self.manager.manage_existing("},{"line_number":99,"context_line":"            self.ctxt, volume[\u0027id\u0027], volume\u003dvolume)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertEqual(fake.VOLUME_ID, result)"},{"line_number":102,"context_line":"        mock_object_volume.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_61786bc5","line":99,"range":{"start_line":99,"start_character":44,"end_line":99,"end_character":50},"updated":"2016-07-05 10:15:29.000000000","message":"-1: This should be an OVO, not a dictionary","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self.manager, \u0027_update_stats_for_managed\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        result \u003d self.manager.manage_existing("},{"line_number":99,"context_line":"            self.ctxt, volume[\u0027id\u0027], volume\u003dvolume)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertEqual(fake.VOLUME_ID, result)"},{"line_number":102,"context_line":"        mock_object_volume.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_d840fc36","line":99,"range":{"start_line":99,"start_character":44,"end_line":99,"end_character":50},"in_reply_to":"1aa78d24_61786bc5","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"}],"cinder/volume/flows/api/manage_existing.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5f258613d93c9da20848ce368301888fd6ac5476","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027host\u0027: kwargs.pop(\u0027host\u0027),"},{"line_number":66,"context_line":"            \u0027availability_zone\u0027: kwargs.pop(\u0027availability_zone\u0027),"},{"line_number":67,"context_line":"            \u0027volume_type_id\u0027: volume_type_id,"},{"line_number":68,"context_line":"            \u0027metadata\u0027: kwargs.pop(\u0027metadata\u0027),"},{"line_number":69,"context_line":"            \u0027bootable\u0027: kwargs.pop(\u0027bootable\u0027),"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_629a3765","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":47},"updated":"2016-06-21 08:26:02.000000000","message":"I\u0027ve needed to make this line like:\n\n            \u0027metadata\u0027: kwargs.pop(\u0027metadata\u0027) or {},\n\nto get it working.","commit_id":"107d8c0408aee0d3fb6e569ace342c8bda1a6e2f"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"fd6be0c43edbe94cd6075e420c95230c619a4602","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027host\u0027: kwargs.pop(\u0027host\u0027),"},{"line_number":66,"context_line":"            \u0027availability_zone\u0027: kwargs.pop(\u0027availability_zone\u0027),"},{"line_number":67,"context_line":"            \u0027volume_type_id\u0027: volume_type_id,"},{"line_number":68,"context_line":"            \u0027metadata\u0027: kwargs.pop(\u0027metadata\u0027),"},{"line_number":69,"context_line":"            \u0027bootable\u0027: kwargs.pop(\u0027bootable\u0027),"},{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_185f64e6","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":47},"in_reply_to":"5a9d85d2_629a3765","updated":"2016-06-21 08:55:16.000000000","message":"Done","commit_id":"107d8c0408aee0d3fb6e569ace342c8bda1a6e2f"}],"cinder/volume/manager.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5f258613d93c9da20848ce368301888fd6ac5476","unresolved":false,"context_lines":[{"line_number":2227,"context_line":"            volume \u003d objects.Volume.get_by_id(ctxt, volume_id)"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"        try:"},{"line_number":2230,"context_line":"            flow_engine \u003d manage_existing.get_flow("},{"line_number":2231,"context_line":"                ctxt,"},{"line_number":2232,"context_line":"                self.db,"},{"line_number":2233,"context_line":"                self.driver,"},{"line_number":2234,"context_line":"                self.host,"},{"line_number":2235,"context_line":"                volume_id,"},{"line_number":2236,"context_line":"                ref,"},{"line_number":2237,"context_line":"                volume,"},{"line_number":2238,"context_line":"            )"},{"line_number":2239,"context_line":"        except Exception:"},{"line_number":2240,"context_line":"            msg \u003d _(\"Failed to create manage_existing flow.\")"},{"line_number":2241,"context_line":"            LOG.exception(msg, resource\u003d{\u0027type\u0027: \u0027volume\u0027, \u0027id\u0027: volume_id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_2205cf79","line":2238,"range":{"start_line":2230,"start_character":0,"end_line":2238,"end_character":13},"updated":"2016-06-21 08:26:02.000000000","message":"Looks like this should be also be changed to:\n\n            flow_engine \u003d manage_existing.get_flow(\n                ctxt,\n                self.db,\n                self.driver,\n                self.host,\n                volume,\n                ref,\n            )","commit_id":"107d8c0408aee0d3fb6e569ace342c8bda1a6e2f"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"fd6be0c43edbe94cd6075e420c95230c619a4602","unresolved":false,"context_lines":[{"line_number":2227,"context_line":"            volume \u003d objects.Volume.get_by_id(ctxt, volume_id)"},{"line_number":2228,"context_line":""},{"line_number":2229,"context_line":"        try:"},{"line_number":2230,"context_line":"            flow_engine \u003d manage_existing.get_flow("},{"line_number":2231,"context_line":"                ctxt,"},{"line_number":2232,"context_line":"                self.db,"},{"line_number":2233,"context_line":"                self.driver,"},{"line_number":2234,"context_line":"                self.host,"},{"line_number":2235,"context_line":"                volume_id,"},{"line_number":2236,"context_line":"                ref,"},{"line_number":2237,"context_line":"                volume,"},{"line_number":2238,"context_line":"            )"},{"line_number":2239,"context_line":"        except Exception:"},{"line_number":2240,"context_line":"            msg \u003d _(\"Failed to create manage_existing flow.\")"},{"line_number":2241,"context_line":"            LOG.exception(msg, resource\u003d{\u0027type\u0027: \u0027volume\u0027, \u0027id\u0027: volume_id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_987d141f","line":2238,"range":{"start_line":2230,"start_character":0,"end_line":2238,"end_character":13},"in_reply_to":"5a9d85d2_2205cf79","updated":"2016-06-21 08:55:16.000000000","message":"Done","commit_id":"107d8c0408aee0d3fb6e569ace342c8bda1a6e2f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ea706fd051289e8ad2937e7fa43ebfba163583ec","unresolved":false,"context_lines":[{"line_number":2232,"context_line":"                self.db,"},{"line_number":2233,"context_line":"                self.driver,"},{"line_number":2234,"context_line":"                self.host,"},{"line_number":2235,"context_line":"                volume,"},{"line_number":2236,"context_line":"                ref,"},{"line_number":2237,"context_line":"            )"},{"line_number":2238,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b1a48457","line":2235,"range":{"start_line":2235,"start_character":16,"end_line":2235,"end_character":22},"updated":"2016-06-22 11:59:52.000000000","message":"-1: This does not match get_flow signature.  According to that one this should be volume_id.","commit_id":"a6764d7ea974a947bee9248d2bdbae8adebcc141"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"282b27ac684f35d6f999c71588a39aa275f3f241","unresolved":false,"context_lines":[{"line_number":2232,"context_line":"                self.db,"},{"line_number":2233,"context_line":"                self.driver,"},{"line_number":2234,"context_line":"                self.host,"},{"line_number":2235,"context_line":"                volume,"},{"line_number":2236,"context_line":"                ref,"},{"line_number":2237,"context_line":"            )"},{"line_number":2238,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_df095633","line":2235,"range":{"start_line":2235,"start_character":16,"end_line":2235,"end_character":22},"in_reply_to":"3aaa91ec_69bfd4d0","updated":"2016-06-22 13:19:14.000000000","message":"My bad, this new code matches the current signature, I was checking the wrong local branch.","commit_id":"a6764d7ea974a947bee9248d2bdbae8adebcc141"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b31520e50a21e932b05076c1d8e717951b3fff3d","unresolved":false,"context_lines":[{"line_number":2232,"context_line":"                self.db,"},{"line_number":2233,"context_line":"                self.driver,"},{"line_number":2234,"context_line":"                self.host,"},{"line_number":2235,"context_line":"                volume,"},{"line_number":2236,"context_line":"                ref,"},{"line_number":2237,"context_line":"            )"},{"line_number":2238,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_69bfd4d0","line":2235,"range":{"start_line":2235,"start_character":16,"end_line":2235,"end_character":22},"in_reply_to":"3aaa91ec_b1a48457","updated":"2016-06-22 12:37:17.000000000","message":"Well - [1].\n\nYes, I\u0027ve broke that. :(\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/manage_existing.py#L94","commit_id":"a6764d7ea974a947bee9248d2bdbae8adebcc141"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"        LOG.info(_LI(\"Manage existing volume completed successfully.\"),"},{"line_number":2237,"context_line":"                 resource\u003dvol_ref)"},{"line_number":2238,"context_line":"        return vol_ref[\u0027id\u0027]"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"    def _update_stats_for_managed(self, volume_reference):"},{"line_number":2241,"context_line":"        # Update volume stats"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_41fe0f39","line":2238,"range":{"start_line":2238,"start_character":15,"end_line":2238,"end_character":28},"updated":"2016-07-05 10:15:29.000000000","message":"-1: vol_ref.id","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":2235,"context_line":""},{"line_number":2236,"context_line":"        LOG.info(_LI(\"Manage existing volume completed successfully.\"),"},{"line_number":2237,"context_line":"                 resource\u003dvol_ref)"},{"line_number":2238,"context_line":"        return vol_ref[\u0027id\u0027]"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"    def _update_stats_for_managed(self, volume_reference):"},{"line_number":2241,"context_line":"        # Update volume stats"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_3854a0c8","line":2238,"range":{"start_line":2238,"start_character":15,"end_line":2238,"end_character":28},"in_reply_to":"1aa78d24_41fe0f39","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"    def _update_stats_for_managed(self, volume_reference):"},{"line_number":2241,"context_line":"        # Update volume stats"},{"line_number":2242,"context_line":"        pool \u003d vol_utils.extract_host(volume_reference[\u0027host\u0027], \u0027pool\u0027)"},{"line_number":2243,"context_line":"        if pool is None:"},{"line_number":2244,"context_line":"            # Legacy volume, put them into default pool"},{"line_number":2245,"context_line":"            pool \u003d self.driver.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_0186c712","line":2242,"range":{"start_line":2242,"start_character":37,"end_line":2242,"end_character":62},"updated":"2016-07-05 10:15:29.000000000","message":"-1: Since volume_reference is an OVO we should use attribute notation:\n\n volume_reference.host","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"    def _update_stats_for_managed(self, volume_reference):"},{"line_number":2241,"context_line":"        # Update volume stats"},{"line_number":2242,"context_line":"        pool \u003d vol_utils.extract_host(volume_reference[\u0027host\u0027], \u0027pool\u0027)"},{"line_number":2243,"context_line":"        if pool is None:"},{"line_number":2244,"context_line":"            # Legacy volume, put them into default pool"},{"line_number":2245,"context_line":"            pool \u003d self.driver.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_f8d05821","line":2242,"range":{"start_line":2242,"start_character":37,"end_line":2242,"end_character":62},"in_reply_to":"1aa78d24_0186c712","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":2244,"context_line":"            # Legacy volume, put them into default pool"},{"line_number":2245,"context_line":"            pool \u003d self.driver.configuration.safe_get("},{"line_number":2246,"context_line":"                \u0027volume_backend_name\u0027) or vol_utils.extract_host("},{"line_number":2247,"context_line":"                    volume_reference[\u0027host\u0027], \u0027pool\u0027, True)"},{"line_number":2248,"context_line":""},{"line_number":2249,"context_line":"        try:"},{"line_number":2250,"context_line":"            self.stats[\u0027pools\u0027][pool][\u0027allocated_capacity_gb\u0027] \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_617d0b1c","line":2247,"range":{"start_line":2247,"start_character":20,"end_line":2247,"end_character":44},"updated":"2016-07-05 10:15:29.000000000","message":"-1: ditto","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":2244,"context_line":"            # Legacy volume, put them into default pool"},{"line_number":2245,"context_line":"            pool \u003d self.driver.configuration.safe_get("},{"line_number":2246,"context_line":"                \u0027volume_backend_name\u0027) or vol_utils.extract_host("},{"line_number":2247,"context_line":"                    volume_reference[\u0027host\u0027], \u0027pool\u0027, True)"},{"line_number":2248,"context_line":""},{"line_number":2249,"context_line":"        try:"},{"line_number":2250,"context_line":"            self.stats[\u0027pools\u0027][pool][\u0027allocated_capacity_gb\u0027] \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_b8a9b092","line":2247,"range":{"start_line":2247,"start_character":20,"end_line":2247,"end_character":44},"in_reply_to":"1aa78d24_617d0b1c","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":2248,"context_line":""},{"line_number":2249,"context_line":"        try:"},{"line_number":2250,"context_line":"            self.stats[\u0027pools\u0027][pool][\u0027allocated_capacity_gb\u0027] \\"},{"line_number":2251,"context_line":"                +\u003d volume_reference[\u0027size\u0027]"},{"line_number":2252,"context_line":"        except KeyError:"},{"line_number":2253,"context_line":"            self.stats[\u0027pools\u0027][pool] \u003d dict("},{"line_number":2254,"context_line":"                allocated_capacity_gb\u003dvolume_reference[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_8172b747","line":2251,"range":{"start_line":2251,"start_character":19,"end_line":2251,"end_character":43},"updated":"2016-07-05 10:15:29.000000000","message":"-1: ditto","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":2248,"context_line":""},{"line_number":2249,"context_line":"        try:"},{"line_number":2250,"context_line":"            self.stats[\u0027pools\u0027][pool][\u0027allocated_capacity_gb\u0027] \\"},{"line_number":2251,"context_line":"                +\u003d volume_reference[\u0027size\u0027]"},{"line_number":2252,"context_line":"        except KeyError:"},{"line_number":2253,"context_line":"            self.stats[\u0027pools\u0027][pool] \u003d dict("},{"line_number":2254,"context_line":"                allocated_capacity_gb\u003dvolume_reference[\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_f897b845","line":2251,"range":{"start_line":2251,"start_character":19,"end_line":2251,"end_character":43},"in_reply_to":"1aa78d24_8172b747","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":2251,"context_line":"                +\u003d volume_reference[\u0027size\u0027]"},{"line_number":2252,"context_line":"        except KeyError:"},{"line_number":2253,"context_line":"            self.stats[\u0027pools\u0027][pool] \u003d dict("},{"line_number":2254,"context_line":"                allocated_capacity_gb\u003dvolume_reference[\u0027size\u0027])"},{"line_number":2255,"context_line":""},{"line_number":2256,"context_line":"    def _run_manage_existing_flow_engine(self, ctxt, volume_id, volume, ref):"},{"line_number":2257,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e18f3b21","line":2254,"range":{"start_line":2254,"start_character":38,"end_line":2254,"end_character":62},"updated":"2016-07-05 10:15:29.000000000","message":"-1: ditto","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":2251,"context_line":"                +\u003d volume_reference[\u0027size\u0027]"},{"line_number":2252,"context_line":"        except KeyError:"},{"line_number":2253,"context_line":"            self.stats[\u0027pools\u0027][pool] \u003d dict("},{"line_number":2254,"context_line":"                allocated_capacity_gb\u003dvolume_reference[\u0027size\u0027])"},{"line_number":2255,"context_line":""},{"line_number":2256,"context_line":"    def _run_manage_existing_flow_engine(self, ctxt, volume_id, volume, ref):"},{"line_number":2257,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_d8947c44","line":2254,"range":{"start_line":2254,"start_character":38,"end_line":2254,"end_character":62},"in_reply_to":"1aa78d24_e18f3b21","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"225f84a138a0f1dd02cd97cd4eb8c8c7d1ee037d","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"            self.stats[\u0027pools\u0027][pool] \u003d dict("},{"line_number":2254,"context_line":"                allocated_capacity_gb\u003dvolume_reference[\u0027size\u0027])"},{"line_number":2255,"context_line":""},{"line_number":2256,"context_line":"    def _run_manage_existing_flow_engine(self, ctxt, volume_id, volume, ref):"},{"line_number":2257,"context_line":"        try:"},{"line_number":2258,"context_line":"            flow_engine \u003d manage_existing.get_flow("},{"line_number":2259,"context_line":"                ctxt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_8168f788","line":2256,"range":{"start_line":2256,"start_character":4,"end_line":2256,"end_character":77},"updated":"2016-07-05 10:15:29.000000000","message":"-1: We don\u0027t need to pass volume_id, we should use volume.id instead.","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"baf58c446121be471ebdac2736d8ca4141deda30","unresolved":false,"context_lines":[{"line_number":2253,"context_line":"            self.stats[\u0027pools\u0027][pool] \u003d dict("},{"line_number":2254,"context_line":"                allocated_capacity_gb\u003dvolume_reference[\u0027size\u0027])"},{"line_number":2255,"context_line":""},{"line_number":2256,"context_line":"    def _run_manage_existing_flow_engine(self, ctxt, volume_id, volume, ref):"},{"line_number":2257,"context_line":"        try:"},{"line_number":2258,"context_line":"            flow_engine \u003d manage_existing.get_flow("},{"line_number":2259,"context_line":"                ctxt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_788aa81c","line":2256,"range":{"start_line":2256,"start_character":4,"end_line":2256,"end_character":77},"in_reply_to":"1aa78d24_8168f788","updated":"2016-07-06 06:31:05.000000000","message":"Done","commit_id":"7fc23ecbc59aa7bf2dcb00c9e7d15152a06b3293"}]}