)]}'
{"cinder/db/sqlalchemy/migrate_repo/versions/046_cinder_init.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"da76dd788594344289ee57d1cf47eea73bdd8cae","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        Column(\u0027status\u0027, String(255)),"},{"line_number":70,"context_line":"        Column(\u0027cgsnapshot_id\u0027, String(36)),"},{"line_number":71,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":72,"context_line":"        mysql_charset\u003d\u0027utf8\u0027"},{"line_number":73,"context_line":"    )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    cgsnapshots \u003d Table("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_29e48139","line":72,"updated":"2016-06-21 13:57:53.000000000","message":"Well, actually that\u0027s against our hacking rules [1].\n\n[1] http://docs.openstack.org/developer/hacking/#dictionaries-lists","commit_id":"d54027b781ca03f8bab8e00633cb3ee584135413"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"a73292e83c5723fe5c1cb60a02ea0907e96e2e78","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        Column(\u0027status\u0027, String(255)),"},{"line_number":70,"context_line":"        Column(\u0027cgsnapshot_id\u0027, String(36)),"},{"line_number":71,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":72,"context_line":"        mysql_charset\u003d\u0027utf8\u0027"},{"line_number":73,"context_line":"    )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    cgsnapshots \u003d Table("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_cc0a2b21","line":72,"in_reply_to":"5a9d85d2_29e48139","updated":"2016-06-21 14:06:02.000000000","message":"Thanks for reminding me of this, I will update it tomorrow.","commit_id":"d54027b781ca03f8bab8e00633cb3ee584135413"},{"author":{"_account_id":8256,"name":"Ivo Vasev","email":"ivasev@softlayer.com","username":"Ivo"},"change_message_id":"fa16e99c0b963a37234833a7ee3dfa5b493bbfb0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        Column(\u0027status\u0027, String(255)),"},{"line_number":70,"context_line":"        Column(\u0027cgsnapshot_id\u0027, String(36)),"},{"line_number":71,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":72,"context_line":"        mysql_charset\u003d\u0027utf8\u0027"},{"line_number":73,"context_line":"    )"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    cgsnapshots \u003d Table("}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_efb5bd7e","line":72,"in_reply_to":"5a9d85d2_cc0a2b21","updated":"2016-06-21 16:33:52.000000000","message":"I was just testing this change/fix before actually existed because of failed migrations(before this PR), wonder is it possible to add some unit tests/ ci job doing migrations","commit_id":"d54027b781ca03f8bab8e00633cb3ee584135413"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"da76dd788594344289ee57d1cf47eea73bdd8cae","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                  \"driver_initiator_data\"]"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        migrate_engine.execute(\"SET foreign_key_checks \u003d 0\")"},{"line_number":541,"context_line":"        for table in tables:"},{"line_number":542,"context_line":"            migrate_engine.execute("},{"line_number":543,"context_line":"                \"ALTER TABLE %s CONVERT TO CHARACTER SET utf8\" % table)"},{"line_number":544,"context_line":"        migrate_engine.execute(\"SET foreign_key_checks \u003d 1\")"},{"line_number":545,"context_line":"        migrate_engine.execute("},{"line_number":546,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_e96ef994","line":543,"range":{"start_line":541,"start_character":8,"end_line":543,"end_character":71},"updated":"2016-06-21 13:57:53.000000000","message":"Do we still need this here?","commit_id":"d54027b781ca03f8bab8e00633cb3ee584135413"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"a73292e83c5723fe5c1cb60a02ea0907e96e2e78","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                  \"driver_initiator_data\"]"},{"line_number":539,"context_line":""},{"line_number":540,"context_line":"        migrate_engine.execute(\"SET foreign_key_checks \u003d 0\")"},{"line_number":541,"context_line":"        for table in tables:"},{"line_number":542,"context_line":"            migrate_engine.execute("},{"line_number":543,"context_line":"                \"ALTER TABLE %s CONVERT TO CHARACTER SET utf8\" % table)"},{"line_number":544,"context_line":"        migrate_engine.execute(\"SET foreign_key_checks \u003d 1\")"},{"line_number":545,"context_line":"        migrate_engine.execute("},{"line_number":546,"context_line":"            \"ALTER DATABASE %s DEFAULT CHARACTER SET utf8\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a9d85d2_0c439343","line":543,"range":{"start_line":541,"start_character":8,"end_line":543,"end_character":71},"in_reply_to":"5a9d85d2_e96ef994","updated":"2016-06-21 14:06:02.000000000","message":"I will research and update it.\nThanks.","commit_id":"d54027b781ca03f8bab8e00633cb3ee584135413"}]}