)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"ca1c0c99cf4a8d5a21eeff51052ee2c762d8be37","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     alexey-mr \u003calexey.morlang@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-21 12:31:32 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use provisioning type from config file if it is not specified in volue type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a2df4b2b4296972a46a15b9dca259f9256c1f0d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_e7a59004","line":7,"updated":"2016-06-21 10:37:16.000000000","message":"This line should be restricted to 50 characters and shouldn\u0027t end with a period.","commit_id":"0ed5668cf3de11ccf55fc476c59006c00a3fdaf6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"ca1c0c99cf4a8d5a21eeff51052ee2c762d8be37","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use provisioning type from config file if it is not specified in volue type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2a2df4b2b4296972a46a15b9dca259f9256c1f0d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9d85d2_4768e487","line":9,"updated":"2016-06-21 10:37:16.000000000","message":"It looks like there is documentation impact. Please add the line DocImpact.\n\nSee https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"0ed5668cf3de11ccf55fc476c59006c00a3fdaf6"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"169ec483ca3edd121e9749bccc618d312f8fc731","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ScaleIO allows to define provisioning type via volume types,"},{"line_number":10,"context_line":"but default value is hardcoded. Cinder has appropriate option in config"},{"line_number":11,"context_line":"and some customers want to have ability to set default volume type via"},{"line_number":12,"context_line":"this config option for a whole cluster rather than using volume types."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"Change-Id: I2a2df4b2b4296972a46a15b9dca259f9256c1f0d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_9b75b0fb","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":38},"updated":"2016-06-24 08:34:18.000000000","message":"Looks like there is some upgrade impact. The behavior is changed based on an existing option which was previously ignored. Please add a release note.\n\nSee http://docs.openstack.org/developer/cinder/devref/releasenotes.html","commit_id":"1a1dec3d20b8478bd4d9206f77690eb4d7fa2269"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b940f3d94123cc0fd612957f4dc22545cd4b5392","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ScaleIO allows to define provisioning type via volume types,"},{"line_number":10,"context_line":"but default value is hardcoded. Cinder has appropriate option in config"},{"line_number":11,"context_line":"and some customers want to have ability to set default volume type via"},{"line_number":12,"context_line":"this config option for a whole cluster rather than using volume types."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3aaa91ec_36d43fea","line":11,"range":{"start_line":11,"start_character":55,"end_line":11,"end_character":61},"updated":"2016-06-27 11:52:18.000000000","message":"volume -\u003e provisioning\n\nPlease fix this if you revise this patch.","commit_id":"dc4a02556f5248c729b362b9fdf521f2cd1445f7"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"86520962921b0adc6675aaefe8d040ea4df0a6a9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ScaleIO allows to define provisioning type via volume types,"},{"line_number":10,"context_line":"but default value is hardcoded. Cinder has appropriate option in config"},{"line_number":11,"context_line":"and some customers want to have ability to set default volume"},{"line_number":12,"context_line":"provisioning via this config option for a whole cluster rather"},{"line_number":13,"context_line":"than using volume types."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1aa78d24_0df37f9f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":12},"updated":"2016-07-11 14:10:35.000000000","message":"nit: provisioning type","commit_id":"a3e9f298e4fb7c4546b8eac907a8efd86b8a6437"}],"cinder/tests/unit/volume/drivers/emc/scaleio/test_misc.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"13f850765f2358ba0fe26f0b634a444a53ee3555","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    def test_default_provisioning_type_unspecified(self):"},{"line_number":193,"context_line":"        empty_storage_type \u003d {}"},{"line_number":194,"context_line":"        self.assertEqual("},{"line_number":195,"context_line":"            self.driver._find_provisioning_type(empty_storage_type),"},{"line_number":196,"context_line":"            \u0027thin\u0027)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def test_default_provisioning_type_thin(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_7298a078","line":195,"updated":"2016-07-07 16:56:50.000000000","message":"Please change the order of arguments.\n\nself.assertEqual(expected, observed)","commit_id":"1c5cbb4f456773d08e791e09425db8977915621d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"13f850765f2358ba0fe26f0b634a444a53ee3555","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    def test_default_provisioning_type_thin(self):"},{"line_number":199,"context_line":"        self.driver \u003d mocks.ScaleIODriver(san_thin_provision\u003dTrue)"},{"line_number":200,"context_line":"        empty_storage_type \u003d {}"},{"line_number":201,"context_line":"        self.assertEqual("},{"line_number":202,"context_line":"            self.driver._find_provisioning_type(empty_storage_type),"},{"line_number":203,"context_line":"            \u0027thin\u0027)"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_b2f16897","line":201,"updated":"2016-07-07 16:56:50.000000000","message":"same comment","commit_id":"1c5cbb4f456773d08e791e09425db8977915621d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"13f850765f2358ba0fe26f0b634a444a53ee3555","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            self.driver._find_provisioning_type(empty_storage_type),"},{"line_number":203,"context_line":"            \u0027thin\u0027)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def test_default_provisioning_type_thick(self):"},{"line_number":206,"context_line":"        self.driver \u003d mocks.ScaleIODriver(san_thin_provision\u003dFalse)"},{"line_number":207,"context_line":"        empty_storage_type \u003d {}"},{"line_number":208,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_126f9cfc","line":205,"updated":"2016-07-07 16:56:50.000000000","message":"We can combine test_default_provisioning_type_thin and test_default_provisioning_type_thick using ddt.","commit_id":"1c5cbb4f456773d08e791e09425db8977915621d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"86520962921b0adc6675aaefe8d040ea4df0a6a9","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @ddt.data([True, \u0027thin\u0027], [False, \u0027thick\u0027])"},{"line_number":202,"context_line":"    @ddt.unpack"},{"line_number":203,"context_line":"    def test_default_provisioning_type_thin(self, first, second):"},{"line_number":204,"context_line":"        self.driver \u003d mocks.ScaleIODriver(san_thin_provision\u003dfirst)"},{"line_number":205,"context_line":"        empty_storage_type \u003d {}"},{"line_number":206,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_4dc74712","line":203,"range":{"start_line":203,"start_character":50,"end_line":203,"end_character":63},"updated":"2016-07-11 14:10:35.000000000","message":"nit: more readable names would be is_thin_provisioned, config_provisioning_type","commit_id":"a3e9f298e4fb7c4546b8eac907a8efd86b8a6437"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c18fdbea142d0f0fd655e5694ee52e8ddd4b5c6b","unresolved":false,"context_lines":[{"line_number":198,"context_line":"            \u0027thin\u0027,"},{"line_number":199,"context_line":"            self.driver._find_provisioning_type(empty_storage_type))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @ddt.data([True, \u0027thin\u0027], [False, \u0027thick\u0027])"},{"line_number":202,"context_line":"    @ddt.unpack"},{"line_number":203,"context_line":"    def test_default_provisioning_type_thin(self, is_thin_provisioned,"},{"line_number":204,"context_line":"                                            config_provisioning_type):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_9846861f","line":201,"updated":"2016-07-11 15:19:07.000000000","message":"@ddt.data((True, \u0027thin\u0027), (False, \u0027thick\u0027))","commit_id":"95bf10b8f90766e2b01bdefaa0d0ff404fe4b4ce"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c18fdbea142d0f0fd655e5694ee52e8ddd4b5c6b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    def test_default_provisioning_type_thin(self, is_thin_provisioned,"},{"line_number":204,"context_line":"                                            config_provisioning_type):"},{"line_number":205,"context_line":"        self.driver \u003d mocks.ScaleIODriver("},{"line_number":206,"context_line":"            san_thin_provision\u003dis_thin_provisioned)"},{"line_number":207,"context_line":"        empty_storage_type \u003d {}"},{"line_number":208,"context_line":"        self.assertEqual("},{"line_number":209,"context_line":"            config_provisioning_type,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_b868a2bb","line":206,"range":{"start_line":206,"start_character":31,"end_line":206,"end_character":50},"updated":"2016-07-11 15:19:07.000000000","message":"config_provisioning_type","commit_id":"95bf10b8f90766e2b01bdefaa0d0ff404fe4b4ce"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c18fdbea142d0f0fd655e5694ee52e8ddd4b5c6b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            san_thin_provision\u003dis_thin_provisioned)"},{"line_number":207,"context_line":"        empty_storage_type \u003d {}"},{"line_number":208,"context_line":"        self.assertEqual("},{"line_number":209,"context_line":"            config_provisioning_type,"},{"line_number":210,"context_line":"            self.driver._find_provisioning_type(empty_storage_type))"}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_58a89edb","line":209,"range":{"start_line":209,"start_character":12,"end_line":209,"end_character":36},"updated":"2016-07-11 15:19:07.000000000","message":"is_thin_provisioned","commit_id":"95bf10b8f90766e2b01bdefaa0d0ff404fe4b4ce"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"24ce7215663d66c70de5fe56ad47d5253cd1bddd","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @ddt.data((True, \u0027thin\u0027), (False, \u0027thick\u0027))"},{"line_number":202,"context_line":"    @ddt.unpack"},{"line_number":203,"context_line":"    def test_default_provisioning_type_thin(self, config_provisioning_type,"},{"line_number":204,"context_line":"                                            expected_provisioning_type):"},{"line_number":205,"context_line":"        self.driver \u003d mocks.ScaleIODriver("},{"line_number":206,"context_line":"            san_thin_provision\u003dconfig_provisioning_type)"},{"line_number":207,"context_line":"        empty_storage_type \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_449c34c0","line":204,"range":{"start_line":203,"start_character":50,"end_line":204,"end_character":70},"updated":"2016-07-11 17:55:40.000000000","message":"Now config_provisioning_type will be set to boolean instead of string. Please reverse the order of arguments.","commit_id":"8319ea4c497aa2e25ae9b8be671ac33378aa95db"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"acd0addca5cef6ecb46920e3e6fdcf0f7d2eda51","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @ddt.data((True, \u0027thin\u0027), (False, \u0027thick\u0027))"},{"line_number":202,"context_line":"    @ddt.unpack"},{"line_number":203,"context_line":"    def test_default_provisioning_type_thin(self, config_provisioning_type,"},{"line_number":204,"context_line":"                                            expected_provisioning_type):"},{"line_number":205,"context_line":"        self.driver \u003d mocks.ScaleIODriver("},{"line_number":206,"context_line":"            san_thin_provision\u003dconfig_provisioning_type)"},{"line_number":207,"context_line":"        empty_storage_type \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_8441fc65","line":204,"range":{"start_line":203,"start_character":50,"end_line":204,"end_character":70},"in_reply_to":"1aa78d24_449c34c0","updated":"2016-07-11 18:17:54.000000000","message":"I didn\u0027t realize that config provisioning type is boolean, please ignore this.","commit_id":"8319ea4c497aa2e25ae9b8be671ac33378aa95db"}],"releasenotes/notes/scaleio-default-volume-provisioning-c648118fcc8f297f.yaml":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1f2d610de065d0ea4ada5b29257e75998a9ba399","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Start using config option san_thin_provision for"},{"line_number":4,"context_line":"    default provisioning type instead of hardcoded"},{"line_number":5,"context_line":"    Thick value."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_0dd2185c","line":3,"updated":"2016-06-24 14:02:12.000000000","message":"We need to mention the driver name.","commit_id":"d9f6c744926344eb219b13ea5855ccbb31c2187c"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"1f2d610de065d0ea4ada5b29257e75998a9ba399","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Start using config option san_thin_provision for"},{"line_number":4,"context_line":"    default provisioning type instead of hardcoded"},{"line_number":5,"context_line":"    Thick value."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_0d2e9842","line":4,"range":{"start_line":4,"start_character":41,"end_line":4,"end_character":50},"updated":"2016-06-24 14:02:12.000000000","message":"I don\u0027t think we should refer things in the code.\n\nHow about \"EMC ScaleIO driver now uses the config option san_thin_provision to determine the default provisioning type\" ?","commit_id":"d9f6c744926344eb219b13ea5855ccbb31c2187c"}]}