)]}'
{"cinder/backup/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ff301a825e46d003934d6b8b7b2bd5cba4c450d2","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if \u0027default\u0027 not in self.volume_managers:"},{"line_number":127,"context_line":"            # For multi-backend we just pick the top of the list."},{"line_number":128,"context_line":"            return list(self.volume_managers.keys())[0]"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return \u0027default\u0027"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_770ac922","line":128,"range":{"start_line":128,"start_character":19,"end_line":128,"end_character":55},"updated":"2016-06-23 13:16:19.000000000","message":"nit: I would prefer if we used\n\n return next(iter(self.volume_managers))\n\nSince it\u0027s more efficient both in Python 2 and 3.","commit_id":"7bd37754f3b85df9a706ae63fbf69b7e31b77c70"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ff301a825e46d003934d6b8b7b2bd5cba4c450d2","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                      \u0027backend2\u0027: \u0027backend2\u0027}"},{"line_number":341,"context_line":"        backend \u003d backup_mgr._get_volume_backend(allow_null_host\u003dTrue)"},{"line_number":342,"context_line":"        # For multi-backend _get_volume_backend() returns the top backend."},{"line_number":343,"context_line":"        self.assertEqual(\u0027backend1\u0027, backend)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def test_cleanup_incomplete_backup_operations_with_exceptions(self):"},{"line_number":346,"context_line":"        \"\"\"Test cleanup resilience in the face of exceptions.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_575cedec","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":45},"updated":"2016-06-23 13:16:19.000000000","message":"-1: Not a good idea to assume that you will be getting things in a specific order on methods related to sets, it should be:\n\n self.assertIn(backend, backup_mgr.volume_managers)","commit_id":"7bd37754f3b85df9a706ae63fbf69b7e31b77c70"}]}