)]}'
{"cinder/openstack/common/exception.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"13947e57576ac88dc17c114af51c1f24be06b375","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        except Exception as e:"},{"line_number":126,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"},{"line_number":127,"context_line":"                raise"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                # at least get the core message out if something happened"},{"line_number":130,"context_line":"                self._error_string \u003d self.message"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FtOE%3D","line":127,"updated":"2013-06-24 21:13:02.000000000","message":"Are we sure we want to be editing files from OSLO?   Shouldn\u0027t we get this change in oslo and then update instead?","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"d4e1ade5c5099fa1fcd83fba93d35ad1043a4c22","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        except Exception as e:"},{"line_number":126,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"},{"line_number":127,"context_line":"                raise"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                # at least get the core message out if something happened"},{"line_number":130,"context_line":"                self._error_string \u003d self.message"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Fryk%3D","line":127,"in_reply_to":"AAAAPn%2F%2FsXg%3D","updated":"2013-06-25 11:05:17.000000000","message":"Done\n\nhttps://review.openstack.org/#/c/34349/","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d47c1bb903dea7e855c84cfdc5e1a1272d073931","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        except Exception as e:"},{"line_number":126,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"},{"line_number":127,"context_line":"                raise"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                # at least get the core message out if something happened"},{"line_number":130,"context_line":"                self._error_string \u003d self.message"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FsXg%3D","line":127,"in_reply_to":"AAAAPn%2F%2FtJA%3D","updated":"2013-06-25 05:58:52.000000000","message":"Agreed, you need to submit a change to OSLO and do an update rather than edit directly here.","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e988ec770b5dcd60c1ac0637b6efa38972d65dbd","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        except Exception as e:"},{"line_number":126,"context_line":"            if _FATAL_EXCEPTION_FORMAT_ERRORS:"},{"line_number":127,"context_line":"                raise"},{"line_number":128,"context_line":"            else:"},{"line_number":129,"context_line":"                # at least get the core message out if something happened"},{"line_number":130,"context_line":"                self._error_string \u003d self.message"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FtJA%3D","line":127,"in_reply_to":"AAAAPn%2F%2FtOE%3D","updated":"2013-06-24 21:24:30.000000000","message":"Agreed... should just drop from this patchset and handle this one in Oslo.","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"}],"cinder/transfer/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d47c1bb903dea7e855c84cfdc5e1a1272d073931","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                QUOTAS.commit(context, donor_reservations, project_id\u003ddonor_id)"},{"line_number":195,"context_line":"            LOG.info(_(\"Volume %s has been transferred.\") % volume_id)"},{"line_number":196,"context_line":"        except Exception:"},{"line_number":197,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":198,"context_line":"            QUOTAS.rollback(context, reservations)"},{"line_number":199,"context_line":"            if donor_reservations:"},{"line_number":200,"context_line":"                QUOTAS.rollback(context, donor_reservations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FsWo%3D","line":197,"updated":"2013-06-25 05:58:52.000000000","message":"Not sure the sys.exc_info() is needed here as opposed to just:\nexcept Exception as e:\n  blah \n  blah\n  ....\n  raise","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"2180e34d7fdc1811f8d0f32daf71e577706a880a","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                QUOTAS.commit(context, donor_reservations, project_id\u003ddonor_id)"},{"line_number":195,"context_line":"            LOG.info(_(\"Volume %s has been transferred.\") % volume_id)"},{"line_number":196,"context_line":"        except Exception:"},{"line_number":197,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":198,"context_line":"            QUOTAS.rollback(context, reservations)"},{"line_number":199,"context_line":"            if donor_reservations:"},{"line_number":200,"context_line":"                QUOTAS.rollback(context, donor_reservations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FrQ0%3D","line":197,"in_reply_to":"AAAAPn%2F%2FsWo%3D","updated":"2013-06-25 14:05:18.000000000","message":"In this case:\n\nTypeError: exceptions must be old-style classes or derived from BaseException, not NoneType","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"d4e1ade5c5099fa1fcd83fba93d35ad1043a4c22","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                QUOTAS.commit(context, donor_reservations, project_id\u003ddonor_id)"},{"line_number":195,"context_line":"            LOG.info(_(\"Volume %s has been transferred.\") % volume_id)"},{"line_number":196,"context_line":"        except Exception:"},{"line_number":197,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":198,"context_line":"            QUOTAS.rollback(context, reservations)"},{"line_number":199,"context_line":"            if donor_reservations:"},{"line_number":200,"context_line":"                QUOTAS.rollback(context, donor_reservations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Frw0%3D","line":197,"in_reply_to":"AAAAPn%2F%2FsWo%3D","updated":"2013-06-25 11:05:17.000000000","message":"Was wrong.\n\nDone","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"}],"cinder/volume/drivers/hds/hds.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d47c1bb903dea7e855c84cfdc5e1a1272d073931","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        return None"},{"line_number":88,"context_line":"    except ETree.ParseError as e:"},{"line_number":89,"context_line":"        if check:"},{"line_number":90,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":91,"context_line":"                LOG.error(_(\"XML exception reading parameter: %s\") % element)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            LOG.info(_(\"XML exception reading parameter: %s\") % element)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FsWg%3D","line":90,"updated":"2013-06-25 05:58:52.000000000","message":"not sure of the logic here again (ie use of excutils.save and reraise) as opposed to just:\n\nif check:\n    LOG.error xxxx\n    raise\n\nI\u0027m used to this sort of thing with more work/decisions being made and new exceptions being built from the caught exception.  Maybe you could just explain a bit and educate me a bit :)","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"d4e1ade5c5099fa1fcd83fba93d35ad1043a4c22","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        return None"},{"line_number":88,"context_line":"    except ETree.ParseError as e:"},{"line_number":89,"context_line":"        if check:"},{"line_number":90,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":91,"context_line":"                LOG.error(_(\"XML exception reading parameter: %s\") % element)"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            LOG.info(_(\"XML exception reading parameter: %s\") % element)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Frxo%3D","line":90,"in_reply_to":"AAAAPn%2F%2FsWg%3D","updated":"2013-06-25 11:05:17.000000000","message":"\u003e\u003e If we are doing some other actions before reraising we should\nstore information about exception then do all actions and then\nreraise it. This is caused by eventlet bug. It lost information\nabout exception if it switch threads.\n\ni/o operations can switch greenthreads.","commit_id":"53e83603a14ddec891918dc62f2b31518184c923"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"b4a418452c8c2bf9e44f15d27e1ae73ea09bb406","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            LOG.error(str(ex))"},{"line_number":639,"context_line":"            raise exception.Invalid(ex.get_description())"},{"line_number":640,"context_line":"        except exception.InvalidInput as ex:"},{"line_number":641,"context_line":"            LOG.error(str(ex))"},{"line_number":642,"context_line":"            raise ex"},{"line_number":643,"context_line":"        except Exception as ex:"},{"line_number":644,"context_line":"            LOG.error(str(ex))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F03w%3D","line":641,"updated":"2013-06-20 10:25:10.000000000","message":"Is this line also the case of reraise?","commit_id":"3a49008b767680ebc629824499b45bc31f295805"},{"author":{"_account_id":7708,"name":"Sergey Vilgelm","username":"svilgelm","inactive":true},"change_message_id":"8f026a82e6e17e966ceac4f6a149e4cdf1d46592","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            LOG.error(str(ex))"},{"line_number":639,"context_line":"            raise exception.Invalid(ex.get_description())"},{"line_number":640,"context_line":"        except exception.InvalidInput as ex:"},{"line_number":641,"context_line":"            LOG.error(str(ex))"},{"line_number":642,"context_line":"            raise ex"},{"line_number":643,"context_line":"        except Exception as ex:"},{"line_number":644,"context_line":"            LOG.error(str(ex))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2F0XA%3D","line":641,"in_reply_to":"AAAAPn%2F%2F03w%3D","updated":"2013-06-20 14:47:46.000000000","message":"I dont know. It is raised by another exception.","commit_id":"3a49008b767680ebc629824499b45bc31f295805"}]}