)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"a438e91f927e55a1f80b084f209d6de1494d5dc0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But the truth is that we don\u0027t really need to retrieve the volume again"},{"line_number":14,"context_line":"in any of existing cases, since the caller either doesn\u0027t care about"},{"line_number":15,"context_line":"current value in the DB -for example when setting status to error- or it"},{"line_number":16,"context_line":"already has that information -composing it with the current value it has"},{"line_number":17,"context_line":"and the updated fields it\u0027s passing- and doesn\u0027t need to reload it."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_63223f03","line":15,"range":{"start_line":15,"start_character":24,"end_line":15,"end_character":25},"updated":"2016-08-27 13:54:39.000000000","message":"I\u0027m sorry that what this \u0027-\u0027 stands for,kind of rst symbols or something?","commit_id":"b0d97eed8bafee139272fea55c44d09cbbe7e782"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d696b89d70db3224c2b433d31fa87fb7661432d8","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"But the truth is that we don\u0027t really need to retrieve the volume again"},{"line_number":14,"context_line":"in any of existing cases, since the caller either doesn\u0027t care about"},{"line_number":15,"context_line":"current value in the DB -for example when setting status to error- or it"},{"line_number":16,"context_line":"already has that information -composing it with the current value it has"},{"line_number":17,"context_line":"and the updated fields it\u0027s passing- and doesn\u0027t need to reload it."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa7ab95a_ef1e06ba","line":15,"range":{"start_line":15,"start_character":24,"end_line":15,"end_character":25},"in_reply_to":"fa7ab95a_63223f03","updated":"2016-08-29 12:52:47.000000000","message":"It\u0027s a dash, which is a punctuation mark just like a comma or a parenthesis.","commit_id":"b0d97eed8bafee139272fea55c44d09cbbe7e782"}],"cinder/tests/unit/db/test_name_id.py":[{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"968ac4060a168c522e13057e95473541be1cda6f","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_name_id_diff(self):"},{"line_number":45,"context_line":"        \"\"\"Change name ID to mimic volume after migration.\"\"\""},{"line_number":46,"context_line":"        vol_ref \u003d testutils.create_volume(self.ctxt, size\u003d1,"},{"line_number":47,"context_line":"                                          _name_id\u003dfake.VOLUME2_ID)"},{"line_number":48,"context_line":"        vol_ref \u003d db.volume_get(self.ctxt, vol_ref[\u0027id\u0027])"},{"line_number":49,"context_line":"        expected_name \u003d CONF.volume_name_template % fake.VOLUME2_ID"},{"line_number":50,"context_line":"        self.assertEqual(expected_name, vol_ref[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_fa66924f","line":47,"range":{"start_line":46,"start_character":8,"end_line":47,"end_character":67},"updated":"2016-09-07 19:07:34.000000000","message":"This changes how the test previously worked as db.volume_update is no longer called. Was the previous test not really valid in this case since you just want to verify that the id and name_id can be set to different values?","commit_id":"163f0e8b6926cd13639bd96e317b9c0187148a08"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8d5afeae1452d7b337b10f82fd913098e449c520","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def test_name_id_diff(self):"},{"line_number":45,"context_line":"        \"\"\"Change name ID to mimic volume after migration.\"\"\""},{"line_number":46,"context_line":"        vol_ref \u003d testutils.create_volume(self.ctxt, size\u003d1,"},{"line_number":47,"context_line":"                                          _name_id\u003dfake.VOLUME2_ID)"},{"line_number":48,"context_line":"        vol_ref \u003d db.volume_get(self.ctxt, vol_ref[\u0027id\u0027])"},{"line_number":49,"context_line":"        expected_name \u003d CONF.volume_name_template % fake.VOLUME2_ID"},{"line_number":50,"context_line":"        self.assertEqual(expected_name, vol_ref[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_2c4d089a","line":47,"range":{"start_line":46,"start_character":8,"end_line":47,"end_character":67},"in_reply_to":"9a89bdaa_fa66924f","updated":"2016-09-08 11:21:57.000000000","message":"Previous code was just wrong, there is no name_id field on the DB, the field is _name_id, and we don\u0027t need a second DB query just to add it.","commit_id":"163f0e8b6926cd13639bd96e317b9c0187148a08"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"968ac4060a168c522e13057e95473541be1cda6f","unresolved":false,"context_lines":[{"line_number":927,"context_line":""},{"line_number":928,"context_line":"    def test_volume_update(self):"},{"line_number":929,"context_line":"        volume \u003d db.volume_create(self.ctxt, {\u0027host\u0027: \u0027h1\u0027})"},{"line_number":930,"context_line":"        volume \u003d db.volume_get(self.ctxt, volume.id)"},{"line_number":931,"context_line":"        db.volume_update(self.ctxt, volume[\u0027id\u0027],"},{"line_number":932,"context_line":"                         {\u0027host\u0027: \u0027h2\u0027,"},{"line_number":933,"context_line":"                          \u0027metadata\u0027: {\u0027m1\u0027: \u0027v1\u0027}})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_3ad47abb","line":930,"range":{"start_line":930,"start_character":8,"end_line":930,"end_character":52},"updated":"2016-09-07 19:07:34.000000000","message":"This line doesn\u0027t seem to be necessary.","commit_id":"163f0e8b6926cd13639bd96e317b9c0187148a08"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8d5afeae1452d7b337b10f82fd913098e449c520","unresolved":false,"context_lines":[{"line_number":927,"context_line":""},{"line_number":928,"context_line":"    def test_volume_update(self):"},{"line_number":929,"context_line":"        volume \u003d db.volume_create(self.ctxt, {\u0027host\u0027: \u0027h1\u0027})"},{"line_number":930,"context_line":"        volume \u003d db.volume_get(self.ctxt, volume.id)"},{"line_number":931,"context_line":"        db.volume_update(self.ctxt, volume[\u0027id\u0027],"},{"line_number":932,"context_line":"                         {\u0027host\u0027: \u0027h2\u0027,"},{"line_number":933,"context_line":"                          \u0027metadata\u0027: {\u0027m1\u0027: \u0027v1\u0027}})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_478ea72e","line":930,"range":{"start_line":930,"start_character":8,"end_line":930,"end_character":52},"in_reply_to":"9a89bdaa_3ad47abb","updated":"2016-09-08 11:21:57.000000000","message":"I don\u0027t know why I put that there, since that should have replaced L934.","commit_id":"163f0e8b6926cd13639bd96e317b9c0187148a08"}]}