)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"eb0587080eb5f19726cd9de27738e776fa6f2c3d","unresolved":false,"context_lines":[{"line_number":2212,"context_line":""},{"line_number":2213,"context_line":""},{"line_number":2214,"context_line":"@require_context"},{"line_number":2215,"context_line":"def volume_attachment_update(context, attachment_id, values):"},{"line_number":2216,"context_line":"    query \u003d model_query(context, models.VolumeAttachment)"},{"line_number":2217,"context_line":"    result \u003d query.filter_by(id\u003dattachment_id).update(values)"},{"line_number":2218,"context_line":"    if not result:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_f8a774ba","line":2215,"range":{"start_line":2215,"start_character":4,"end_line":2215,"end_character":28},"updated":"2016-11-18 02:07:37.000000000","message":"A little impact that I can think is we need to change it again if we need the updated object in future.  Or should we consider to redefine all update operation to do not return ORM object in db/api.py, if you want to get updated object then using \u0027get\u0027 operation again?","commit_id":"19807af3297f3f20b84115899901e5551bd6fe9d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e5531fab164e532e8a0bb872800f9563b252f645","unresolved":false,"context_lines":[{"line_number":2212,"context_line":""},{"line_number":2213,"context_line":""},{"line_number":2214,"context_line":"@require_context"},{"line_number":2215,"context_line":"def volume_attachment_update(context, attachment_id, values):"},{"line_number":2216,"context_line":"    query \u003d model_query(context, models.VolumeAttachment)"},{"line_number":2217,"context_line":"    result \u003d query.filter_by(id\u003dattachment_id).update(values)"},{"line_number":2218,"context_line":"    if not result:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a77a97e_b6b85dea","line":2215,"range":{"start_line":2215,"start_character":4,"end_line":2215,"end_character":28},"in_reply_to":"7a77a97e_f8a774ba","updated":"2016-11-21 11:19:54.000000000","message":"This is not being used right now and is doubling our DB queries on updates. So, in this case, we should not hinder our present performance by what may or may not be needed in the future considering how easy it would be to add it in the future if we need it.\n\nThis patch is following on the work already done in other patches: https://review.openstack.org/#/c/332943/","commit_id":"19807af3297f3f20b84115899901e5551bd6fe9d"}]}