)]}'
{"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"59b7664b5fc6d435a8f9432fbaff9c2529203ab7","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _get_extra_config(self, volume):"},{"line_number":388,"context_line":"        return {EXTRA_CONFIG_VOLUME_ID_KEY: volume[\u0027id\u0027],"},{"line_number":389,"context_line":"                volumeops.BACKING_UUID: volume[\u0027id\u0027]}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def _create_backing(self, volume, host\u003dNone, create_params\u003dNone):"},{"line_number":392,"context_line":"        \"\"\"Create volume backing under the given host."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_e3227151","line":389,"range":{"start_line":389,"start_character":16,"end_line":389,"end_character":52},"updated":"2016-06-23 16:24:43.000000000","message":"Lets not add it in extra_config. \nWhat if we want to add \"annotation\", \"version\", \"managedBy\" etc to the shadow VM?\n\nwe can have a namedtuple, VirtualMachineConfigSpec, having \"instanceUuid\" for now ?","commit_id":"88cfa78ae3081557195c50a9b94a93dbbada2cfa"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"4585672ee988523fc2cfefd3b84be0361868de5c","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _get_extra_config(self, volume):"},{"line_number":388,"context_line":"        return {EXTRA_CONFIG_VOLUME_ID_KEY: volume[\u0027id\u0027],"},{"line_number":389,"context_line":"                volumeops.BACKING_UUID: volume[\u0027id\u0027]}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def _create_backing(self, volume, host\u003dNone, create_params\u003dNone):"},{"line_number":392,"context_line":"        \"\"\"Create volume backing under the given host."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_39eabaac","line":389,"range":{"start_line":389,"start_character":16,"end_line":389,"end_character":52},"in_reply_to":"3aaa91ec_159cf25b","updated":"2016-06-24 12:53:50.000000000","message":"Correct, but we also use these functions for creating temporary backings (needed for disk type conversions) and annotations etc will be optional params then. So we need if statements in both cases (params vs dict). In the dictionary based approach, the code changes will be minimal compared to adding optional params. Previously we were adding optional params as you can see in volumeops. Then we thought it is a better idea to use a dict for all optional fields. We started off with extra_config, but we can extend it to other optional fields. For volumeops, uuid etc. is only an optional field for creating a backing","commit_id":"88cfa78ae3081557195c50a9b94a93dbbada2cfa"},{"author":{"_account_id":10210,"name":"Chinmaya Bharadwaj","email":"chinmaya-bharadwaj.a@hpe.com","username":"chinmay"},"change_message_id":"097a0c07830119bc46c2fd8bd034045a2fb29fa4","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _get_extra_config(self, volume):"},{"line_number":388,"context_line":"        return {EXTRA_CONFIG_VOLUME_ID_KEY: volume[\u0027id\u0027],"},{"line_number":389,"context_line":"                volumeops.BACKING_UUID: volume[\u0027id\u0027]}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def _create_backing(self, volume, host\u003dNone, create_params\u003dNone):"},{"line_number":392,"context_line":"        \"\"\"Create volume backing under the given host."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_159cf25b","line":389,"range":{"start_line":389,"start_character":16,"end_line":389,"end_character":52},"in_reply_to":"3aaa91ec_4eac458c","updated":"2016-06-24 06:28:10.000000000","message":"But when handling more parameters it\u0027ll involve more condition statements in volumeops.","commit_id":"88cfa78ae3081557195c50a9b94a93dbbada2cfa"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"912345f2dc5d715d8fc72855e751d6f3caa82fe7","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def _get_extra_config(self, volume):"},{"line_number":388,"context_line":"        return {EXTRA_CONFIG_VOLUME_ID_KEY: volume[\u0027id\u0027],"},{"line_number":389,"context_line":"                volumeops.BACKING_UUID: volume[\u0027id\u0027]}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def _create_backing(self, volume, host\u003dNone, create_params\u003dNone):"},{"line_number":392,"context_line":"        \"\"\"Create volume backing under the given host."}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_4eac458c","line":389,"range":{"start_line":389,"start_character":16,"end_line":389,"end_character":52},"in_reply_to":"3aaa91ec_e3227151","updated":"2016-06-23 18:47:54.000000000","message":"I wrote this function for additions like this. We may need to rename this function and also change its return value.\n\n{\n \u0027extra_config\u0027: {\u0027key\u0027: \u0027value\u0027},\n \u0027instanceUuid\u0027: vol_uuid\n}\n\nWe were adding parameters before and it was affecting many parts of the code. For all optional parts, this looks cleaner.","commit_id":"88cfa78ae3081557195c50a9b94a93dbbada2cfa"}]}