)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c5d4b386d9c273ca3bcc8ea8a8a0bc4df50d82f6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add strict Boolean checking for volume create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is no strict boolean checking for the parameter"},{"line_number":10,"context_line":"\"multiattach\" of API /volumes, so that"},{"line_number":11,"context_line":"any invalid boolean value can be specified."},{"line_number":12,"context_line":"This patch adds a strict checking for it to prevent"},{"line_number":13,"context_line":"invalid value, and adds tests for this change as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_fecfe9b0","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":29},"updated":"2016-06-28 13:40:00.000000000","message":"There is no mentioning about this in the referred bug. You may need to update the bug to include this description.","commit_id":"dc6f89c116595fb14c52a70eef4918959528097d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c5d4b386d9c273ca3bcc8ea8a8a0bc4df50d82f6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\"multiattach\" of API /volumes, so that"},{"line_number":11,"context_line":"any invalid boolean value can be specified."},{"line_number":12,"context_line":"This patch adds a strict checking for it to prevent"},{"line_number":13,"context_line":"invalid value, and adds tests for this change as well."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2a5dc45a3b238a2d875d7fbf7159eb91d1f111bf"},{"line_number":16,"context_line":"Partial-Bug: #1594261"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_eb760aa2","line":13,"range":{"start_line":13,"start_character":24,"end_line":13,"end_character":29},"updated":"2016-06-28 13:40:00.000000000","message":"nit: there is only one test","commit_id":"dc6f89c116595fb14c52a70eef4918959528097d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a7a750a5150d586e5e84c81b0a38d2aabdcbf093","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add strict Boolean checking for volume create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is no strict boolean checking for the parameter"},{"line_number":10,"context_line":"\"multiattach\" of API /volumes, so that"},{"line_number":11,"context_line":"any invalid boolean value can be specified."},{"line_number":12,"context_line":"This patch adds a strict checking for it to prevent"},{"line_number":13,"context_line":"invalid value, and adds tests for this change as well."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_eb4b7457","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":13},"updated":"2016-06-29 11:31:29.000000000","message":"There is no mentioning about this in the referred bug. You may need to update the bug to include this description.","commit_id":"f1caa46a602d823b8b214edf875fb1677daae5f2"}],"cinder/tests/unit/api/v2/test_volumes.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"c5d4b386d9c273ca3bcc8ea8a8a0bc4df50d82f6","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                          req,"},{"line_number":564,"context_line":"                          body)"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    def test_volume_create_with_multiattach_invalid_bool(self):"},{"line_number":567,"context_line":"        vol \u003d self._vol_in_request_body()"},{"line_number":568,"context_line":"        vol[\u0027multiattach\u0027] \u003d \"InvalidBool\""},{"line_number":569,"context_line":"        body \u003d {\"volume\": vol}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_2b23f2a8","line":566,"range":{"start_line":566,"start_character":8,"end_line":566,"end_character":56},"updated":"2016-06-28 13:40:00.000000000","message":"test_volume_create_with_invalid_multiattach\n\n..to be consistent with your test case names in other related patches.","commit_id":"dc6f89c116595fb14c52a70eef4918959528097d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"a7a750a5150d586e5e84c81b0a38d2aabdcbf093","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        volume_type_get.side_effect \u003d stubs.stub_volume_type_get"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        vol \u003d self._vol_in_request_body()"},{"line_number":589,"context_line":"        vol[\u0027multiattach\u0027] \u003d True"},{"line_number":590,"context_line":"        body \u003d {\"volume\": vol}"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        ex \u003d self._expected_vol_from_controller()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_eb1d3467","line":589,"updated":"2016-06-29 11:31:29.000000000","message":"We could add a kwarg in _vol_in_request_body and _expected_vol_from_controller with default value False.","commit_id":"f1caa46a602d823b8b214edf875fb1677daae5f2"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"b445a5d11cbd4a3cb1f7b195784de84dd1a046bb","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        volume_type_get.side_effect \u003d stubs.stub_volume_type_get"},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        vol \u003d self._vol_in_request_body()"},{"line_number":589,"context_line":"        vol[\u0027multiattach\u0027] \u003d True"},{"line_number":590,"context_line":"        body \u003d {\"volume\": vol}"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        ex \u003d self._expected_vol_from_controller()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_a3f069fe","line":589,"in_reply_to":"3aaa91ec_eb1d3467","updated":"2016-06-29 14:19:17.000000000","message":"Done","commit_id":"f1caa46a602d823b8b214edf875fb1677daae5f2"}]}