)]}'
{"cinder/volume/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3afdef0671d43e026b07965622ffbb923950fab7","unresolved":false,"context_lines":[{"line_number":1187,"context_line":"                                         desired_attributes\u003ddesired_attributes)"},{"line_number":1188,"context_line":"        except netapp_api.NaApiError:"},{"line_number":1189,"context_line":"            msg \u003d _(\u0027Failed to get info for aggregate %s.\u0027)"},{"line_number":1190,"context_line":"            LOG.exception(msg % aggregate_name)"},{"line_number":1191,"context_line":"            return {}"},{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"        if len(aggrs) \u003c 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_a1743c9c","line":1190,"range":{"start_line":1190,"start_character":30,"end_line":1190,"end_character":31},"updated":"2016-07-04 12:18:30.000000000","message":"Since msg is only used for the LOG.exception, please change % to , to just pass in to the logger rather than doing the string formatting up front. Also, this needs to be _LE(), not _().","commit_id":"a846a1af21bb69c8ac374e30a6a93268cd2fa576"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e69c40d009b1463234f91f7006d5eb87eed19ff6","unresolved":false,"context_lines":[{"line_number":1187,"context_line":"                                         desired_attributes\u003ddesired_attributes)"},{"line_number":1188,"context_line":"        except netapp_api.NaApiError:"},{"line_number":1189,"context_line":"            msg \u003d _(\u0027Failed to get info for aggregate %s.\u0027)"},{"line_number":1190,"context_line":"            LOG.exception(msg % aggregate_name)"},{"line_number":1191,"context_line":"            return {}"},{"line_number":1192,"context_line":""},{"line_number":1193,"context_line":"        if len(aggrs) \u003c 1:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_e0699a8d","line":1190,"range":{"start_line":1190,"start_character":30,"end_line":1190,"end_character":31},"in_reply_to":"1aa78d24_a1743c9c","updated":"2016-07-12 14:28:01.000000000","message":"Thanks, Sean.  I\u0027ve made this correction here and elsewhere in this file as appropriate.","commit_id":"a846a1af21bb69c8ac374e30a6a93268cd2fa576"}]}